Skip to content

Commit fd84128

Browse files
committed
feat: addressed review comments
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 18d14d4 commit fd84128

File tree

5 files changed

+19
-33
lines changed

5 files changed

+19
-33
lines changed

lib/node_modules/@stdlib/math/base/special/minmaxabsf/README.md

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -99,20 +99,14 @@ var bool = ( v === out );
9999
<!-- eslint no-undef: "error" -->
100100

101101
```javascript
102-
var randu = require( '@stdlib/random/base/randu' );
102+
var uniform = require( '@stdlib/random/array/uniform' );
103+
var logEachMap = require( '@stdlib/console/log-each-map' );
103104
var minmaxabsf = require( '@stdlib/math/base/special/minmaxabsf' );
104105

105-
var x;
106-
var y;
107-
var v;
108-
var i;
106+
var x = uniform( 100, -50, 50);
107+
var y = uniform( 100, -50, 50);
109108

110-
for ( i = 0; i < 100; i++ ) {
111-
x = ( randu()*100.0 ) - 50.0;
112-
y = ( randu()*100.0 ) - 50.0;
113-
v = minmaxabsf( x, y );
114-
console.log( 'minmaxabsf(%d,%d) = [%d, %d]', x, y, v[0], v[1] );
115-
}
109+
logEachMap( 'minmaxabsf(%f,%f) = [%s]', x, y, minmaxabsf );
116110
```
117111

118112
</section>
@@ -153,18 +147,16 @@ Returns the minimum and maximum absolute single-precision floating-point values
153147
float min;
154148
float max;
155149
stdlib_base_minmaxabsf( -4.2f, 3.14f, &min, &max );
156-
// [ 3.14, 4.2 ]
157150

158151
stdlib_base_minmaxabsf( 0.0f, -0.0f, &min, &max );
159-
// [ 0.0, 0.0 ]
160152
```
161153
162154
The function accepts the following arguments:
163155
164156
- **x**: `[in] float` input value.
165157
- **y**: `[in] float` input value.
166-
- **min**: `[in] *float` output min.
167-
- **max**: `[in] *float` output max.
158+
- **min**: `[out] *float` output min.
159+
- **max**: `[out] *float` output max.
168160
169161
```c
170162
void stdlib_base_minmaxabsf( const float x, const float y, float* min, float* max );

lib/node_modules/@stdlib/math/base/special/minmaxabsf/examples/c/example.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
* limitations under the License.
1717
*/
1818

19-
#include "stdlib/math/base/special/minmaxabsf.h"
20-
#include <stdlib.h>
2119
#include <stdio.h>
20+
#include <stdlib.h>
21+
#include "stdlib/math/base/special/minmaxabsf.h"
2222

2323
int main( void ) {
2424
float x;

lib/node_modules/@stdlib/math/base/special/minmaxabsf/examples/index.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,11 @@
1818

1919
'use strict';
2020

21-
var randu = require( '@stdlib/random/base/randu' );
21+
var uniform = require( '@stdlib/random/array/uniform' );
22+
var logEachMap = require( '@stdlib/console/log-each-map' );
2223
var minmaxabsf = require( './../lib' );
2324

24-
var x;
25-
var y;
26-
var v;
27-
var i;
25+
var x = uniform( 100, -50, 50 );
26+
var y = uniform( 100, -50, 50 );
2827

29-
for ( i = 0; i < 100; i++ ) {
30-
x = ( randu()*100.0 ) - 50.0;
31-
y = ( randu()*100.0 ) - 50.0;
32-
v = minmaxabsf( x, y );
33-
console.log( 'minmaxabs(%d,%d) = [%d, %d]', x, y, v[0], v[1] );
34-
}
28+
logEachMap( 'minmaxabsf(%f,%f) = [%s]', x, y, minmaxabsf );

lib/node_modules/@stdlib/math/base/special/minmaxabsf/src/addon.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
* limitations under the License.
1717
*/
1818

19-
#include "stdlib/math/base/special/minmaxabsf.h"
19+
#include <node_api.h>
2020
#include "stdlib/napi/argv.h"
21+
#include "stdlib/napi/export.h"
2122
#include "stdlib/napi/argv_float.h"
2223
#include "stdlib/napi/argv_float32array.h"
23-
#include "stdlib/napi/export.h"
24-
#include <node_api.h>
24+
#include "stdlib/math/base/special/minmaxabsf.h"
2525

2626
/**
2727
* Receives JavaScript callback invocation data.

lib/node_modules/@stdlib/math/base/special/minmaxabsf/src/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
* limitations under the License.
1717
*/
1818

19-
#include "stdlib/math/base/special/minmaxabsf.h"
20-
#include "stdlib/math/base/assert/is_nanf.h"
2119
#include "stdlib/math/base/special/absf.h"
20+
#include "stdlib/math/base/assert/is_nanf.h"
21+
#include "stdlib/math/base/special/minmaxabsf.h"
2222

2323
/**
2424
* Evaluates the single-precision min and max value.

0 commit comments

Comments
 (0)