Skip to content

Error in git repo regex when inserting equations #138

@rreusser

Description

@rreusser

Checklist

Please ensure the following tasks are completed before filing an issue.

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • If this is a general question, searched the FAQ for an existing answer.
  • If this is a feature request, the issue name begins with RFC:.

Description

Description of the issue (or feature request).

Encountered error when running:

$ make MARKDOWN_FILTER=.*/math/base/special/fresnel/.* markdown-img-equations-src-urls
out: [email protected]:stdlib-js/stdlib.git

lib/node_modules/@stdlib/math/base/special/fresnel/README.md
  1:1  error  Error: Cannot parse given file `etc/remark/.remarkrc.js`
Error: Cannot parse script `tools/remark/plugins/remark-img-equations-src-urls/lib/index.js`
TypeError: Cannot read property '1' of null
    at git (/Users/rreusser/projects/node/stdlib/stdlib/tools/remark/plugins/remark-img-equations-src-urls/lib/git.js:50:28)
    at Object.<anonymous> (/Users/rreusser/projects/node/stdlib/stdlib/tools/remark/plugins/remark-img-equations-src-urls/lib/git.js:75:18)

The remote is parsed is parsed to expect github.com/stdlib/stdlib.git instead of also allowing github.com:stdlib/stdlib.git. Actually getting the rawgit url correct is a slightly different matter, but it seems like it'd be reasonable to parse it either way.

Related Issues

Does this issue (or feature request) have any related issues?

No.

Questions

Any questions for reviewers?

No.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working.ToolsIssue or pull request related to project tooling.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions