Algorithm to remove last string character is not Unicode aware

[kgryte]

Checklist

Please ensure the following tasks are completed before filing a bug report.

• Read and understood the Code of Conduct.
• Searched for existing issues and pull requests.

Description

Description of the issue.

Encountered an error when attempting to remove the last character of a string. Issues arise when using @stdlib/string/remove-last because a visual character can be comprised of multiple code points.

We should evaluate whether to make the implementation Unicode aware.

Related Issues

Does this issue have any related issues?

None.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

N/A

Demo

If relevant, provide a link to a live demo.

N/A

Reproduction

What steps are required to reproduce the unexpected output?

In order to reproduce this bug, do the following:

• attempt to remove the last character when comprised of two Unicode code points.

Expected Results

What are the expected results?

The visual character to be removed, not just a single code point.

Actual Results

What are the actual results?

The last code point is removed, not the full character.

Environments

What environments are affected (e.g., Node v0.4.x, Chrome, IE 11)? If Node.js, include the npm version, operating system, and any other potentially relevant platform information.

The following environments are affected:

• all

[unworld11]

is this still open?

[kgryte]

@unworld11 Looks like this has already been addressed. See

• https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/string/remove-last
• https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/string/base (remove-last* packages)

Closing...