Skip to content

feat: add C implementation for math/base/special/nanmin #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 19, 2024
Merged

feat: add C implementation for math/base/special/nanmin #3004

merged 6 commits into from
Oct 19, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_nanmin( const double x, const double y );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 13, 2024
@gunjjoshi
Copy link
Member Author

The CI errors look similar to what we face here: #3001 (comment)

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Oct 19, 2024
kgryte
kgryte reviewed Oct 19, 2024
View reviewed changes
kgryte and others added 3 commits October 19, 2024 01:38
@kgryte
Copy link
Member

kgryte commented Oct 19, 2024

@Planeshifter Upgrading cppcheck seems to have resulted in new C lint issues resulting in CI failures where there usually wouldn't be any.

kgryte
kgryte approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi.

I'll go ahead and merge, as it seems like the C lint error is spurious.

@kgryte kgryte merged commit 04b72af into stdlib-js:develop Oct 19, 2024
9 of 10 checks passed
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@gunjjoshi @kgryte @aayush0325
feat: add C implementation for math/base/special/nanmin
b8db589 
PR-URL: stdlib-js#3004
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gunjjoshi @kgryte @stdlib-bot