Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3073

Description

This pull request:

  • Adds a test case to achieve 100% test coverage for 'blas/ext/base/dnanasumors`

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 12, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte added Needs Review A pull request which needs code review. Tests Pull requests specifically adding tests. labels Nov 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 18, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnanasumors $\color{red}370/372$
$\color{green}+99.46\%$
$\color{red}20/21$
$\color{green}+95.24\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}370/372$
$\color{green}+99.46\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 18, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

Also, it looks like we have yet to achieve 100% code coverage.

@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

/stdlib lint-autofix

@Neerajpathak07
Copy link
Member Author

@kgryte Apparently it only showed 100% test coverage for the test.ndarray.js file.
I understood what is supposed to be done.
Thank you for the review.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Neerajpathak07.

@kgryte kgryte merged commit 3bdf9dc into stdlib-js:develop Nov 19, 2024
9 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 19, 2024
@Neerajpathak07 Neerajpathak07 deleted the test-dnanasumors branch November 20, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Incomplete code coverage for blas/ext/base/dnanasumors

3 participants