Skip to content

Conversation

aayush0325
Copy link
Member

@aayush0325 aayush0325 commented Nov 19, 2024

Resolves #3135 .

Description

What is the purpose of this pull request?

This pull request:

  • adds at method to array/fixed-endian-factory
  • adds the respective benchmarks and tests
  • updates README

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

the at method in @stdlib/array/bool had its benchmarks written in a single file so i followed that convention. kindly let me know if we need any changes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 19, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}705/964$
$\color{green}+73.13\%$
$\color{red}23/32$
$\color{green}+71.88\%$
$\color{red}8/20$
$\color{green}+40.00\%$
$\color{red}705/964$
$\color{green}+73.13\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

kindly give this a review @kgryte !

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Nov 19, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @aayush0325. Two minor comments. Once resolved, this should be ready for merge.

@kgryte
Copy link
Member

kgryte commented Nov 19, 2024

benchmarks written in a single file so i followed that convention.

Yes, for at that makes sense, as element access should not be length-dependent.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 19, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Nov 20, 2024

I've moved the stuff in main.js to where you requested and I've placed it alphabetically among the non static methods in README.md. I hope that's okay

@aayush0325 aayush0325 requested a review from kgryte November 20, 2024 00:38
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aayush0325!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 20, 2024
@kgryte kgryte merged commit b34732c into stdlib-js:develop Nov 20, 2024
12 checks passed
@aayush0325 aayush0325 deleted the array-at branch November 20, 2024 03:40
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
PR-URL: stdlib-js#3184
Closes: stdlib-js#3135
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add at method to array/fixed-endian-factory

3 participants