Skip to content

feat: add array/base/mskbinary3d #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 21, 2024
Merged

feat: add array/base/mskbinary3d #3193

merged 6 commits into from
Nov 21, 2024

Conversation

rylany27
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • implements the mskbinary3d package for masked binary operations in the array/base namespace.
  • and provides a 3D equivalent of the mskbinary2d package for binary callbacks using a mask array.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@rylany27
feat(array/base): implement mskbinary3d package for masked binary ope…
c173515 
…rations

Add the `mskbinary3d` package for binary callbacks using a mask array.
stdlib-bot
stdlib-bot reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

kgryte
kgryte reviewed Nov 20, 2024
View reviewed changes
@kgryte
Copy link
Member

kgryte commented Nov 20, 2024

/stdlib update-copyright-years

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Nov 20, 2024
@kgryte kgryte changed the title feat(array/base): implement mskbinary3d package for masked binary operations feat: add array/base/mskbinary3d Nov 20, 2024
kgryte
kgryte reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, @rylany27. Overall, this PR is looking good. After the package.json file indentation issue is resolved (and it needs a trailing newline), I'll take a final closer look.

@rylany27
Copy link
Contributor Author

Thank you for the review, @kgryte! I appreciate your feedback. Should I go ahead and make another commit to resolve the package.json indentation issue and add the trailing newline?

@kgryte
Copy link
Member

kgryte commented Nov 20, 2024

The test coverage CI failure seems to be an issue with the GitHub workflow, not this PR.

@rylany27 Yes, please do.

@kgryte
Copy link
Member

kgryte commented Nov 20, 2024

@rylany27 I just realized that the package you've added is missing a README. Would you mind adding to this PR?

kgryte
kgryte reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the missing README is added, this PR is ready for merge.

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/base/mskbinary3d $\color{green}164/164$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}164/164$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@rylany27
Copy link
Contributor Author

Hi @kgryte , I've added the README. Let me know if there’s anything else needed. Thanks!

kgryte
kgryte reviewed Nov 21, 2024
View reviewed changes
kgryte
kgryte reviewed Nov 21, 2024
View reviewed changes
kgryte
kgryte reviewed Nov 21, 2024
View reviewed changes
kgryte
kgryte approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rylany27!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 21, 2024
@kgryte kgryte merged commit c328fc5 into stdlib-js:develop Nov 21, 2024
12 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@rylany27 @kgryte
@stdlib-bot @Neerajpathak07
feat: add array/base/mskbinary3d
a6bee3e 
PR-URL: stdlib-js#3193
Closes: stdlib-js#3178
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/mskbinary3d

3 participants

@rylany27 @kgryte @stdlib-bot