Skip to content

feat: add every method to array/fixed-endian-factory #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2024
Merged

feat: add every method to array/fixed-endian-factory #3200

merged 5 commits into from
Nov 22, 2024

Conversation

aayush0325
Copy link
Member

Resolves #3138

Description

What is the purpose of this pull request?

This pull request:

  • adds every method to array/fixed-endian-factory with required docs, tests and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}769/1026$
$\color{green}+74.95\%$ 		$\color{red}46/54$
$\color{green}+85.19\%$ 		$\color{red}11/22$
$\color{green}+50.00\%$ 		$\color{red}769/1026$
$\color{green}+74.95\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

kindly give this a review @kgryte!

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Nov 21, 2024
kgryte
kgryte reviewed Nov 21, 2024
View reviewed changes
kgryte
kgryte requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from reordering declared methods, this PR is looking good.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 21, 2024
@aayush0325
Copy link
Member Author

I've changed the position of every method to be before the forEach method.

@aayush0325 aayush0325 requested a review from kgryte November 22, 2024 01:30
kgryte
kgryte approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aayush0325!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 22, 2024
@kgryte kgryte merged commit e3a2173 into stdlib-js:develop Nov 22, 2024
12 checks passed
@aayush0325 aayush0325 deleted the array-every branch November 22, 2024 01:51
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
@aayush0325 @kgryte @pranav-1720
feat: add every method to array/fixed-endian-factory
9121db4 
PR-URL: stdlib-js#3200
Closes: stdlib-js#3138
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 27, 2024
@aayush0325 @kgryte @pranav-1720
feat: add every method to array/fixed-endian-factory
3e505ad 
PR-URL: stdlib-js#3200
Closes: stdlib-js#3138
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@aayush0325 @kgryte @Neerajpathak07
feat: add every method to array/fixed-endian-factory
015cb3a 
PR-URL: stdlib-js#3200
Closes: stdlib-js#3138
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add every method to array/fixed-endian-factory

3 participants

@aayush0325 @stdlib-bot @kgryte