Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3173

Description

What is the purpose of this pull request?

This pull request:

  • adds implementation for array/base/unary3d-by

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/unary3d-by $\color{green}162/162$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}162/162$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

@Neerajpathak07 CI failures need to be addressed before this PR can be reviewed.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 21, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 21, 2024
@Neerajpathak07 Neerajpathak07 changed the title feat: add implementation for array/base/unary3d-by feat: add array/base/unary3d-by Nov 22, 2024
@Neerajpathak07
Copy link
Member Author

@kgryte Regarding the run_affected_examples they are running perfectly on my system when I tested them locally:-
unary3d-by

@Neerajpathak07
Copy link
Member Author

I'll resolve the lint errors and commit again.

@Neerajpathak07
Copy link
Member Author

@kgryte all CI checks are passing!!

@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 11, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 11, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Neerajpathak07!

@kgryte kgryte merged commit 70aaa8c into stdlib-js:develop Dec 11, 2024
11 checks passed
@Neerajpathak07 Neerajpathak07 deleted the unary3d-by branch December 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/unary3d-by

4 participants