Skip to content

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • fix the data type of the scalar constant in blas/ext/base/dsapxsumpw

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 24, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsapxsumpw $\color{green}438/438$
$\color{green}+100.00\%$
$\color{green}24/24$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}438/438$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this, @headlessNode!

@kgryte kgryte changed the title refactor: fix the data type of the scalar constant in blas/ext/base/dsapxsumpw fix: extract the scalar constant as a float in blas/ext/base/dsapxsumpw Nov 25, 2024
@kgryte kgryte merged commit bff0533 into stdlib-js:develop Nov 25, 2024
9 checks passed
@headlessNode headlessNode deleted the refactor-dsapxsumpw branch November 25, 2024 10:22
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants