Skip to content

Conversation

DhruvArvindSingh
Copy link
Contributor

@DhruvArvindSingh DhruvArvindSingh commented Nov 26, 2024

Fixes: #3154

This PR adds 'slice' prototype method in array/fixed-endian-factory.

Updated files(array/fixed-endian-factory):

  • README.md
  • main.js

Added files(array/fixed-endian-factory):

  • benchmark.slice.length.js

  • benchmark.slice.js

  • test.slice.js

  • Read, understood, and followed the contributing guidelines
    @stdlib-js/reviewers

Added necessary changes in test ,benchmark and README.md files

Fixes: stdlib-js#3154
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@DhruvArvindSingh
Copy link
Contributor Author

Kindly review this PR, i have added the necessary changes as told in PR #3188

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 26, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1265/1520$
$\color{green}+83.22\%$
$\color{red}176/190$
$\color{green}+92.63\%$
$\color{red}24/34$
$\color{green}+70.59\%$
$\color{red}1265/1520$
$\color{green}+83.22\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 26, 2024

@DhruvArvindSingh I suggest making whatever changes you made in this PR to your existing PR #3188, instead of opening a new PR.

@kgryte kgryte changed the title feat: adding 'slice' prototype method in fixed-endian-factory feat: adding slice method to array/fixed-endian-factory Dec 4, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Dec 4, 2024
@kgryte kgryte changed the title feat: adding slice method to array/fixed-endian-factory feat: add slice method to array/fixed-endian-factory Dec 4, 2024
@DhruvArvindSingh DhruvArvindSingh deleted the 3154_adding_slice_in_fixed_endian_factory branch June 16, 2025 14:51
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed Needs Review A pull request which needs code review. labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add slice method to array/fixed-endian-factory

3 participants