Skip to content

Conversation

aayush0325
Copy link
Member

@aayush0325 aayush0325 commented Dec 10, 2024

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/special/nonfibonaccif with relevant tests, docs, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 10, 2024
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 10, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 10, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 10, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/nonfibonaccif $\color{green}210/210$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}210/210$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 24, 2024
@aayush0325
Copy link
Member Author

pushed the requested changes @gunjjoshi!

@aayush0325 aayush0325 requested a review from gunjjoshi December 24, 2024 20:03
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 24, 2024
@gunjjoshi gunjjoshi removed the Needs Changes Pull request which needs changes before being merged. label Dec 25, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 25, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM. Thanks, @gunjjoshi, for doing an initial review. @aayush0325 You'll want to review the various changes we needed to make and update your other math/base/special/* PRs accordingly and where applicable.

@kgryte kgryte merged commit 7245f3c into stdlib-js:develop Dec 25, 2024
13 checks passed
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 25, 2024
@aayush0325 aayush0325 deleted the nonfibonaccif branch February 16, 2025 08:38
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3391
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants