Skip to content

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Dec 11, 2024

Resolves #3414.

Description

  • adds C implementation for @stdlib/stats/base/dists/bernoulli/mean along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 11, 2024
@kgryte
Copy link
Member

kgryte commented Dec 11, 2024

Until CI passes, this PR cannot be reviewed.

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/mean $\color{green}165/165$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}165/165$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. C Issue involves or relates to C. labels Dec 13, 2024
@kgryte
Copy link
Member

kgryte commented Dec 13, 2024

You'll want to go through your other related PRs to make any similar requested changes.

@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 13, 2024
@vivekmaurya001
Copy link
Contributor Author

@kgryte , done changes please give a look

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @vivekmaurya001. This now LGTM.

@kgryte kgryte added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Dec 13, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `@stdlib/stats/base/dists/bernoulli/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3451
Closes: https://github.com/stdlib-js/stdlib/issues/3414

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Vivek Maurya <[email protected]>
Co-authored-by: Vivek maurya <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 5019fab into stdlib-js:develop Dec 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/bernoulli/mean

3 participants