Skip to content

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add top-level implementation for ndarray/for-each

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2024

Coverage Report

Package Statements Branches Functions Lines
ndarray/for-each $\color{green}123/123$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}123/123$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Dec 15, 2024
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode headlessNode marked this pull request as ready for review December 16, 2024 10:44
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 16, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 22, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @headlessNode!

@kgryte kgryte merged commit ac735b1 into stdlib-js:develop Dec 22, 2024
12 checks passed
@headlessNode headlessNode deleted the forEach-top-level branch December 22, 2024 17:03
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3926
Ref: stdlib-js#2656
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants