refactor: update stats/base/dmax native addon from C++ to C
#4051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Dec 19, 2024
kgryte
reviewed
Dec 19, 2024
kgryte
requested changes
Dec 19, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
This is looking good. Just two minor comments.
kgryte
added
the
Needs Changes
Member
|
/stdlib merge |
stdlib-bot
added
the
bot: In Progress
Member
|
Let's hold off on additional changes for future PRs. |
stdlib-bot
removed
the
bot: In Progress
Member
Author
|
Noted, pushing the requested changes soon! |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Member
Author
|
is this good to go @kgryte? |
kgryte
removed
Needs Changes
kgryte
changed the title
stats/base/dmax to follow latest project conventionsstats/base/dmax native addon from C++ to C
ShabiShett07
pushed a commit
to ShabiShett07/stdlib
that referenced
this pull request
Feb 26, 2025
PR-URL: stdlib-js#4051 Reviewed-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
stats/base/dmaxto follow latest conventions.blas/ext/base/dsumto follow current project conventions #1807 here ) to get an idea of what should be done here.blas/ext/base/dsumto follow current project conventions #1807 has some other changes related to tests, benchmarks and documentation as well. Please let me know if we need to do the same hereRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers