Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dnanrange #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

feat: add C ndarray interface and refactor implementation for stats/base/dnanrange #4234

wants to merge 11 commits into from

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanrange
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks in manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

gunjjoshi and others added 6 commits December 26, 2024 00:02
@gunjjoshi @Neerajpathak07
refactor: replace built-ins by stdlib packages, update benchmarks in …
97c64b1 
…`math/base/special/trunc`

PR-URL: stdlib-js#3941

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@gunjjoshi @Neerajpathak07
refactor: replace built-ins by stdlib packages, update benchmarks in …
dc4017e 
…`math/base/special/trunc`

PR-URL: stdlib-js#3941

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
@Neerajpathak07
Merge branch 'ndarray-dnanrange' of https://github.com/Neerajpathak07…
a9c3cee 
…/stdlib into ndarray-dnanrange
@Neerajpathak07
feat: ndarray-dnanrange
62251fa
@Neerajpathak07
feat: ndarray-dnanrange
aa8f3c7
@Neerajpathak07
fix: src error
b109a61
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 25, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 25, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanrange $\color{green}389/389$
$\color{green}+100.00\%$ 		$\color{green}33/33$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}389/389$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 25, 2024 19:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 25, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@kgryte
Copy link
Member

kgryte commented Dec 31, 2024

@Neerajpathak07 You should avoid force pushing to remote branches. By doing so, you invalidate the local branches of others who had previously pulled down your work (e.g., reviewers). Once you push changes to a remote repository, you should avoid rewriting Git history.

@Neerajpathak07
Copy link
Member Author

@kgryte sure I'll keep that in mind!

@Neerajpathak07 Neerajpathak07 deleted the ndarray-dnanrange branch January 1, 2025 16:57
@Neerajpathak07 Neerajpathak07 restored the ndarray-dnanrange branch January 1, 2025 16:57
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dnanrange branch January 3, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neerajpathak07 @stdlib-bot @kgryte @gunjjoshi