Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsmeanpw
  • refactors JavaScript implementation
  • refactors tests, docs, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 29, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 29, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsmeanpw $\color{green}351/351$
$\color{green}+100.00\%$
$\color{green}18/18$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}351/351$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 29, 2024 07:12
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 29, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot
Copy link
Contributor

@Neerajpathak07, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 18, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating to use dssumpw explicitly, this PR looks good.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jan 18, 2025
@Neerajpathak07 Neerajpathak07 requested a review from kgryte January 19, 2025 05:11
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 19, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jan 19, 2025
@kgryte kgryte merged commit deabf53 into stdlib-js:develop Jan 19, 2025
60 checks passed
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dsmeanpw branch January 19, 2025 08:18
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
…s/base/dsmeanpw`

PR-URL: stdlib-js#4338
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
…s/base/dsmeanpw`

PR-URL: stdlib-js#4338
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
…s/base/dsmeanpw`

PR-URL: stdlib-js#4338
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
…s/base/dsmeanpw`

PR-URL: stdlib-js#4338
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants