Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dmskmin #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 2, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dmskmin #4371

merged 13 commits into from
Jan 2, 2025

Conversation

aayush0325
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dmskmin
  • refactors JavaScript implementation
  • updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
feat: add C ndarray interface and refactor implementation
8f4e7a9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmskmin $\color{green}411/411$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}411/411$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 30, 2024 •
edited
Loading

same comment regarding max line length exceeding in lib/ndarray.native.js @ reviewer, have added a TODO for that too

@aayush0325 aayush0325 marked this pull request as draft December 31, 2024 08:50
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 31, 2024
@aayush0325
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@aayush0325
Copy link
Member Author

js benchmarks to be updated here

@aayush0325 aayush0325 marked this pull request as ready for review January 2, 2025 08:03
@aayush0325
Copy link
Member Author

this one's ready for review @Planeshifter!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2025
kgryte
kgryte reviewed Jan 2, 2025
View reviewed changes
kgryte
kgryte requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good apart from two minor nits.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 2, 2025
@aayush0325 aayush0325 requested a review from kgryte January 2, 2025 12:08
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2025
@aayush0325
Copy link
Member Author

pushed a fix, thanks @kgryte!

kgryte
kgryte approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jan 2, 2025
@kgryte kgryte merged commit 5394150 into stdlib-js:develop Jan 2, 2025
45 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 3, 2025
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
084f3a6 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 aayush0325 deleted the ndarray-dmskmin branch January 8, 2025 19:04
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@aayush0325 @stdlib-bot @0PrashantYadav0
feat: add C ndarray interface and refactor implementation for `stats/…
def9082 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
6aea855 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Feb 23, 2025
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
0959d55 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @stdlib-bot @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stats/…
fce0752 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aayush0325 @stdlib-bot @kgryte