Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmean #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 12, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmean #4395

merged 20 commits into from
Mar 12, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsnanmean
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Neerajpathak07 Neerajpathak07 marked this pull request as draft December 30, 2024 19:12
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Dec 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsnanmean $\color{green}345/345$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}345/345$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 30, 2024 19:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 30, 2024
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
@Neerajpathak07
Copy link
Member Author

@kgryte I have made the suggested changes throughout all my other PR's would really appreciate a review

Neerajpathak07
Neerajpathak07 commented Jan 8, 2025
View reviewed changes
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 12, 2025 15:15
@Neerajpathak07
chore: minor clean up
942fb6b
@Neerajpathak07
chore: update addon
7056bcd
@Neerajpathak07
Merge branch 'develop' into ndarray-dsnanmean
c143b3d 
Signed-off-by: Neeraj Pathak <[email protected]>
@Neerajpathak07
chore: clean up
1a258ab 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@Neerajpathak07
chore: max-len
a20dfba
@Neerajpathak07
chore: max-len
db0cfa9
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 10, 2025 15:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 10, 2025
aayush0325
aayush0325 requested changes Feb 13, 2025
View reviewed changes
aayush0325
aayush0325 previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be clear of any errors now

@Neerajpathak07
Copy link
Member Author

@kgryte pls take a look at this as well!!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 12, 2025
kgryte
kgryte reviewed Mar 12, 2025
View reviewed changes
@kgryte
docs: fix example
02e4170 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Mar 12, 2025
View reviewed changes
kgryte
kgryte approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Mar 12, 2025
@kgryte kgryte merged commit 9e91f81 into stdlib-js:develop Mar 12, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 aayush0325 left review comments

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neerajpathak07 @stdlib-bot @kgryte @aayush0325