Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanpn #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 9, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanpn #4405

merged 20 commits into from
Feb 9, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsnanmeanpn
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 31, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsnanmeanpn $\color{green}399/399$
$\color{green}+100.00\%$ 		$\color{green}26/26$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}399/399$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 2, 2025 21:30
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 1, 2025 13:10
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 1, 2025 13:49
aayush0325
aayush0325 requested changes Feb 2, 2025
View reviewed changes
aayush0325
aayush0325 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Feb 9, 2025
@kgryte kgryte added the C Issue involves or relates to C. label Feb 9, 2025
kgryte
kgryte reviewed Feb 9, 2025
View reviewed changes
kgryte
kgryte approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit f51730c into stdlib-js:develop Feb 9, 2025
12 checks passed
@Neerajpathak07 Neerajpathak07 mentioned this pull request Feb 10, 2025
Merged
1 task
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@Neerajpathak07 @kgryte @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stat…
e4d5335 
…s/base/dsnanmeanpn`

PR-URL: stdlib-js#4405
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Aayush Khanna <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @kgryte @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stat…
929f377 
…s/base/dsnanmeanpn`

PR-URL: stdlib-js#4405
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Aayush Khanna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 aayush0325 approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neerajpathak07 @stdlib-bot @kgryte @aayush0325