Skip to content

Conversation

rreusser
Copy link
Member

@rreusser rreusser commented Jan 12, 2025

Towards #2464.

Description

What is the purpose of this pull request?

This pull request:

This pull request adds JS implementation for blas/base/zdscal.

Related Issues

Does this pull request have any related issues?

N/A

Questions

Any questions for reviewers of this pull request?

  • I'm still failing to get linters passing. It complained my Fortran without trailing linefeeds had trailing linefeeds, and I didn't make it past that and just pushed with --no-verify. I need to develop some better patterns here and straighten these things out.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Verify correct building/functioning of native modules

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jan 12, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@rreusser
Copy link
Member Author

I don't know what happened, but every time I push/pull to sync up a branch, the hashes don't line up. My branches might be set up to track the wrong remote or something, but I've just deleted my cloned repo and started fresh. I'm sure there's a way to fix it if you know enough about git, but I'm not seeing it, so I'll just re-create the existing PRs and cross my fingers.

@rreusser rreusser closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants