Skip to content

feat: add C ndarray API and refactor for stats/base/sdsnanmeanors #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 27, 2025
Merged

feat: add C ndarray API and refactor for stats/base/sdsnanmeanors #4727

merged 22 commits into from
Jul 27, 2025

Conversation

@DhruvArvindSingh
Copy link
Contributor

@DhruvArvindSingh DhruvArvindSingh commented Jan 12, 2025

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray implementation for stats/base/sdsnanmeanors.
  • Refactors stats/base/sdsnanmeanors.
  • Adds C implementation section in README.md.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@DhruvArvindSingh
feat: add C ndarray and refactor for stats/base/sdsnanmeanors
10d1d28 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 12, 2025
@DhruvArvindSingh
Copy link
Contributor Author

DhruvArvindSingh commented Jan 12, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/sdsnanmeanors $\color{green}371/371$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}371/371$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@DhruvArvindSingh DhruvArvindSingh marked this pull request as draft January 13, 2025 10:26
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 13, 2025
DhruvArvindSingh and others added 2 commits January 14, 2025 01:39
@DhruvArvindSingh
Merge branch 'stdlib-js:develop' into feat/ndarray_sdsnanmeanors
5e74a4e
@DhruvArvindSingh
refactor: refactored benchmarks, tests and docs
05492cd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@DhruvArvindSingh DhruvArvindSingh marked this pull request as ready for review January 13, 2025 21:09
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 13, 2025
@DhruvArvindSingh DhruvArvindSingh changed the title feat: add C ndarray and refactor for stats/base/sdsnanmeanors feat: add C ndarray API and refactor for stats/base/sdsnanmeanors Jan 13, 2025
@DhruvArvindSingh DhruvArvindSingh mentioned this pull request Apr 7, 2025
Closed
7 tasks
@kgryte kgryte self-requested a review April 16, 2025 00:29
@kgryte
Copy link
Member

kgryte commented Apr 16, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
@kgryte kgryte requested a review from gururaj1512 June 8, 2025 08:55
@kgryte
Copy link
Member

kgryte commented Jun 8, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 8, 2025
@0PrashantYadav0 0PrashantYadav0 mentioned this pull request Jun 9, 2025
Open
1 task
gururaj1512
gururaj1512 requested changes Jun 9, 2025
View reviewed changes
@gururaj1512
chore: apply code suggestions
6aa2286 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
style: fix indentations
5c91864 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
Copy link
Member

gururaj1512 commented Jun 9, 2025

/stdlib update-copyright-years

@gururaj1512 gururaj1512 requested review from kgryte and removed request for kgryte July 22, 2025 12:35
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 27, 2025
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
@kgryte
style: move rule
0eda272 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 27, 2025
View reviewed changes
kgryte
kgryte approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte merged commit cc5caf6 into stdlib-js:develop Jul 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@gururaj1512 gururaj1512 gururaj1512 left review comments

Assignees

No one assigned

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DhruvArvindSingh @stdlib-bot @kgryte @gururaj1512