feat: add accessor arrays support to `blas/ext/base/gcusumkbn` #4959

headlessNode · 2025-01-30T08:12:58Z

Description

What is the purpose of this pull request?

This pull request:

add accessor arrays support to blas/ext/base/gcusumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js

Signed-off-by: Muhammad Haris <[email protected]>

stdlib-bot · 2025-02-01T08:42:45Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/gcusumkbn	$\color{green}330/330$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}330/330$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts

headlessNode · 2025-02-01T11:59:35Z

@kgryte Heads up! Will need to apply similar changes to other similar PRs as well .i.e. one involving output array.

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

kgryte

LGTM

PR-URL: stdlib-js#4959 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>

headlessNode added 2 commits January 30, 2025 08:11

headlessNode marked this pull request as ready for review January 30, 2025 20:54

headlessNode added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 30, 2025

headlessNode commented Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/ndarray.js Outdated Show resolved Hide resolved

refactor: apply review suggestion

e3f8c43

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode marked this pull request as draft February 1, 2025 09:07

headlessNode commented Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/lib/accessors.js Outdated Show resolved Hide resolved

docs: apply review suggestion

0d203c5

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode marked this pull request as ready for review February 1, 2025 10:09

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts Outdated Show resolved Hide resolved

docs: fix description

ef422da

Signed-off-by: Athan <[email protected]>

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/index.d.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts Outdated Show resolved Hide resolved

headlessNode and others added 4 commits February 1, 2025 17:00

refactor: apply review suggestion

e5da0c5

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

refactor: apply review suggestion

7fd06ef

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

refactor: apply review suggestion

194daaa

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

refactor: apply review suggestion

536c825

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts Outdated Show resolved Hide resolved

kgryte reviewed Feb 1, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/gcusumkbn/docs/types/test.ts Outdated Show resolved Hide resolved

headlessNode and others added 2 commits February 1, 2025 17:03

refactor: apply review suggestion

0dbbab6

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

refactor: apply review suggestion

959518d

Co-authored-by: Athan <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

kgryte approved these changes Feb 1, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Feb 1, 2025

kgryte merged commit 4bbd4bd into stdlib-js:develop Feb 1, 2025
12 checks passed

headlessNode deleted the accessor-gcusumkbn branch February 1, 2025 12:10

Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025

feat: add accessor arrays support to blas/ext/base/gcusumkbn

79935a4

PR-URL: stdlib-js#4959 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>

ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025

feat: add accessor arrays support to blas/ext/base/gcusumkbn

8353961

PR-URL: stdlib-js#4959 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add accessor arrays support to `blas/ext/base/gcusumkbn` #4959

feat: add accessor arrays support to `blas/ext/base/gcusumkbn` #4959

Uh oh!

headlessNode commented Jan 30, 2025

Uh oh!

Uh oh!

stdlib-bot commented Feb 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Feb 1, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: add accessor arrays support to blas/ext/base/gcusumkbn #4959

feat: add accessor arrays support to blas/ext/base/gcusumkbn #4959

Uh oh!

Conversation

headlessNode commented Jan 30, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

Uh oh!

stdlib-bot commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Feb 1, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add accessor arrays support to `blas/ext/base/gcusumkbn` #4959

feat: add accessor arrays support to `blas/ext/base/gcusumkbn` #4959

stdlib-bot commented Feb 1, 2025 •

edited

Loading