feat: add `string/base/slice-code-points` #5414

headlessNode · 2025-02-24T13:53:20Z

Description

What is the purpose of this pull request?

This pull request:

add string/base/slice-code-points and relevant tests, benchmarks and documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add string/base/slice-code-points metr-issue-tracker#34

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-02-24T13:55:04Z

Coverage Report

Package	Statements	Branches	Functions	Lines
string/base/slice-code-points	$\color{green}107/107$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}107/107$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/string/base/slice-code-points/package.json

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/string/base/slice-code-points/test/test.js

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

headlessNode · 2025-04-01T04:51:51Z

@kgryte changes applied.

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

headlessNode · 2025-04-06T07:53:23Z

@kgryte Changes applied. Please check.

kgryte

LGTM. Thanks, @headlessNode!

headlessNode mentioned this pull request Feb 24, 2025

[RFC]: add string/base/slice-code-points stdlib-js/metr-issue-tracker#34

Closed

headlessNode added the Feature Issue or pull request for adding a new feature. label Feb 24, 2025

headlessNode commented Feb 24, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

docs: apply suggestions from code review

1aa4cbd

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode marked this pull request as ready for review February 24, 2025 14:44

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 24, 2025

headlessNode closed this Feb 24, 2025

headlessNode reopened this Feb 24, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 24, 2025

headlessNode commented Feb 24, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/package.json Show resolved Hide resolved

fix: add missing key

e0cfaca

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode added the Needs Review A pull request which needs code review. label Feb 24, 2025

kgryte reviewed Feb 25, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Feb 25, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Show resolved Hide resolved

headlessNode mentioned this pull request Feb 25, 2025

feat: refactor truncate string package #1097

Open

6 tasks

headlessNode added 3 commits February 26, 2025 07:43

kgryte reviewed Mar 15, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 15, 2025

headlessNode added 2 commits March 15, 2025 15:59

Merge branch 'stdlib-js:develop' into string-slice-cp

98b19f1

headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 15, 2025

headlessNode requested a review from kgryte March 15, 2025 11:10

kgryte reviewed Apr 1, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/test/test.js Outdated Show resolved Hide resolved

kgryte reviewed Apr 1, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Apr 1, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed Apr 1, 2025

View reviewed changes

lib/node_modules/@stdlib/string/base/slice-code-points/lib/main.js Outdated Show resolved Hide resolved

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 1, 2025

headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Apr 6, 2025

kgryte approved these changes Apr 9, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Apr 9, 2025

kgryte merged commit c30bb89 into stdlib-js:develop Apr 9, 2025
31 checks passed

headlessNode deleted the string-slice-cp branch April 9, 2025 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `string/base/slice-code-points` #5414

feat: add `string/base/slice-code-points` #5414

Uh oh!

headlessNode commented Feb 24, 2025

Uh oh!

stdlib-bot commented Feb 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Apr 1, 2025

Uh oh!

Uh oh!

headlessNode commented Apr 6, 2025

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: add string/base/slice-code-points #5414

feat: add string/base/slice-code-points #5414

Uh oh!

Conversation

headlessNode commented Feb 24, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Apr 1, 2025

Uh oh!

Uh oh!

headlessNode commented Apr 6, 2025

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `string/base/slice-code-points` #5414

feat: add `string/base/slice-code-points` #5414

stdlib-bot commented Feb 24, 2025 •

edited

Loading