-
-
Notifications
You must be signed in to change notification settings - Fork 910
Description
This commit has 4 comment(s) from core contributors that require attention.
Commit: 00b23b3cb5b4e72bf977a9ac170062f8e8614ef1
Comments:
-
Line 126: @stdlib-bot Missing spaces. Should be
var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0, NaN, NaN ] );
stdlib/lib/node_modules/@stdlib/stats/base/dnanvariancech/README.md
Lines 123 to 129 in 00b23b3
```javascript var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array([1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0, NaN, NaN]); var v = dnanvariancech( 5, 1, x, 2 ); // returns 6.25 -
Line 139: @stdlib-bot ESLint rules should not be disabled in example code but in a comment above the code block.
<!-- eslint-disable max-len -->
stdlib/lib/node_modules/@stdlib/stats/base/dnanvariancech/README.md
Lines 136 to 142 in 00b23b3
```javascript var Float64Array = require( '@stdlib/array/float64' ); var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ] ); // eslint-disable-line max-len var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element var v = dnanvariancech( 5, 1, x1, 2 ); -
Line 153: @stdlib-bot This change should be reverted.
stdlib/lib/node_modules/@stdlib/stats/base/dnanvariancech/README.md
Lines 150 to 156 in 00b23b3
```javascript var Float64Array = require( '@stdlib/array/float64' ); var x = new Float64Array( [ 1.0, -2.0, 2.0 ] ); var v = dnanvariancech.ndarray( x.length, 1, x, 1, 0 ); // returns ~4.33333 -
Line 33: @stdlib-bot
console.log( x );
should be inserted after this line in order to allow users to view the contents of the generated array.stdlib/lib/node_modules/@stdlib/stats/base/dnanvariancech/examples/index.js
Lines 30 to 36 in 00b23b3
return uniform( -50.0, 50.0 ); } var x = filledarrayBy( 10, 'float64', rand ); var v = dnanvariancech( x.length, 1, x, 1 ); console.log( v );
Interested in helping improve the project? If you are, the comment linked to above has 4 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.