Skip to content

refactor: update blas/base/gscal to follow current project conventions #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 27, 2025
Merged

refactor: update blas/base/gscal to follow current project conventions #5447

merged 14 commits into from
Feb 27, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #5440.

Description

What is the purpose of this pull request?

This pull request:

  • refactor the package to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Feb 25, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 25, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/gscal $\color{green}314/314$
$\color{green}+100.00\%$ 		$\color{green}34/34$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}314/314$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte requested a review from headlessNode February 25, 2025 21:59
@kgryte kgryte changed the title refactor: update blas/base/gscal to follow current project convetions refactor: update blas/base/gscal to follow current project conventions Feb 25, 2025
headlessNode
headlessNode requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@headlessNode headlessNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @saurabhraghuvanshii .

@headlessNode headlessNode added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 26, 2025
@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into refactor-gscal
bd050b9
@saurabhraghuvanshii
chore: address changes
bc213a0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
headlessNode
headlessNode reviewed Feb 26, 2025
View reviewed changes
headlessNode
headlessNode reviewed Feb 26, 2025
View reviewed changes
@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into refactor-gscal
05e2b26
@saurabhraghuvanshii
chore: addresses comments
e6fd570 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
headlessNode
headlessNode reviewed Feb 27, 2025
View reviewed changes
@headlessNode headlessNode self-requested a review February 27, 2025 03:19
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 27, 2025
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Feb 27, 2025
headlessNode
headlessNode reviewed Feb 27, 2025
View reviewed changes
@headlessNode headlessNode added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Feb 27, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: update `blas/base/gscal` to follow current project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/5447
Closes: https://github.com/stdlib-js/stdlib/issues/5440

Co-authored-by: Muhammad Haris <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

Please review the above commit message and make any necessary adjustments.

@kgryte
Copy link
Member

kgryte commented Feb 27, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 27, 2025
kgryte
kgryte reviewed Feb 27, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 27, 2025
View reviewed changes
@kgryte
style: wrap text
cbb3cbc 
Signed-off-by: Athan <[email protected]>
@kgryte
docs: clean-up
44e5989 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Feb 27, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 27, 2025
View reviewed changes
@kgryte kgryte merged commit 8dc22d7 into stdlib-js:develop Feb 27, 2025
11 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the refactor-gscal branch February 27, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headlessNode headlessNode headlessNode requested changes

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: update blas/base/gscal according to current project conventions

4 participants

@saurabhraghuvanshii @stdlib-bot @kgryte @headlessNode