Skip to content

Conversation

anandkaranubc
Copy link
Contributor

@anandkaranubc anandkaranubc commented Feb 27, 2025

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Updates the remark-img-equations plugin to ensure that % is properly escaped as \% to prevent formatting issues.
  • Fixes the incorrect equation rendering in fmod

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. labels Feb 27, 2025
@anandkaranubc anandkaranubc changed the title fix: escape '%' symbol when processing LaTeX equations in remark-img-equations plugin fix: escape % symbol when processing LaTeX equations in remark-img-equations plugin Feb 27, 2025
@anandkaranubc
Copy link
Contributor Author

This might also be a good time to add escaping functionality for other special symbols, if it's needed.

All the symbols (that need escaping) can be found here

@anandkaranubc anandkaranubc marked this pull request as draft February 27, 2025 02:39
@anandkaranubc anandkaranubc marked this pull request as ready for review February 27, 2025 02:39
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 27, 2025
@kgryte
Copy link
Member

kgryte commented Feb 27, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@kgryte kgryte changed the title fix: escape % symbol when processing LaTeX equations in remark-img-equations plugin fix: escape % symbol when processing LaTeX equations in remark-img-equations plugin Feb 27, 2025
@kgryte
Copy link
Member

kgryte commented Feb 27, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@kgryte
Copy link
Member

kgryte commented Feb 27, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 27, 2025
@kgryte
Copy link
Member

kgryte commented Feb 27, 2025

We can escape other symbols on an as-needed basis. For now, let's see how this pans out and actually solves the issue.

@kgryte kgryte merged commit 9b6fb3a into stdlib-js:develop Feb 27, 2025
9 checks passed
@anandkaranubc anandkaranubc deleted the fix/remark-plugin branch February 28, 2025 06:02
abhishekblue pushed a commit to abhishekblue/stdlib that referenced this pull request Mar 5, 2025
…quations` plugin

PR-URL: stdlib-js#5488
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants