Skip to content

bench: suppress uninitialized variable warning #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

bench: suppress uninitialized variable warning #5523

merged 1 commit into from
Mar 1, 2025

Conversation

yugalkaushik
Copy link
Contributor

Resolves #5503.

Description

This pull request fixes uninitialized variable warnings in the benchmark.length.c file for stdlib_strided_smskceil.

  • Ensures x and m arrays are properly initialized before use.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 28, 2025
stdlib-bot
stdlib-bot reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 28, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/strided/special/smskceil $\color{green}402/402$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}402/402$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 1, 2025
@kgryte kgryte changed the title Fix uninitialized variable warnings in smskceil benchmark bench: suppress uninitialized variable warning Mar 1, 2025
@kgryte kgryte merged commit b0b646a into stdlib-js:develop Mar 1, 2025
15 of 16 checks passed
@yugalkaushik yugalkaushik deleted the fix-linting-smskceil branch March 1, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

+1 more reviewer

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

4 participants

@yugalkaushik @stdlib-bot @kgryte @Neerajpathak07