Address commit comments (commit `d8cd158`)

[stdlib-bot]

This commit has 9 comment(s) from core contributors that require attention.

Commit: d8cd158e02fea1c4dbaf2f75a7000ac32c52479c

Comments:

• d8cd158#r153167581

  Line 145: @stdlib-bot Line L145-148 need to move to L241.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/README.md

  Lines 142 to 148 in d8cd158

  	<!-- /.examples -->
  	<!-- Section to include cited references. If references are included, add a horizontal rule *before* the section. Make sure to keep an empty line after the `section` element and another before the `/section` close. -->
  	<section class="references">

• d8cd158#r153167584

  Line 240: @stdlib-bot We are missing a closing </section> and trailing comment to pair with the <section class="c"> above. See other similar packages for what we are looking for.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/README.md

  Lines 237 to 243 in d8cd158

  	}
  	}
  	```
  	</section>
  	<!-- /.references -->

• d8cd158#r153167597

  Line 217: @stdlib-bot This header is not used and can be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/README.md

  Lines 214 to 220 in d8cd158

  	#include "stdlib/constants/float64/eps.h"
  	#include <stdlib.h>
  	#include <stdio.h>
  	#include <time.h>
  	static double random_uniform( const double min, const double max ) {
  	double v = (double)rand() / ( (double)RAND_MAX + 1.0 );

• d8cd158#r153167603

  Line 63: @stdlib-bot Missing space between ] and ).

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/benchmark.native.js

  Lines 60 to 66 in d8cd158

  	b.tic();
  	for ( i = 0; i < b.iterations; i++ ) {
  	y = pdf( x[ i % len ], mu[ i % len ], sigma[ i % len ]);
  	if ( isnan( y ) ) {
  	b.fail( 'should not return NaN' );
  	}

• d8cd158#r153167617

  Line 43: @stdlib-bot This should be pkg+'::native'

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/benchmark.native.js

  Lines 40 to 46 in d8cd158

  	// MAIN //
  	bench( pkg, opts, function benchmark( b ) {
  	var sigma;
  	var len;
  	var mu;

• d8cd158#r153167622

  Line 30: @stdlib-bot This line should be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/c/benchmark.c

  Lines 27 to 33 in d8cd158

  	#define NAME "normal-pdf"
  	#define ITERATIONS 1000000
  	#define REPEATS 3
  	#define LEN 100
  	/**
  	* Prints the TAP version.

• d8cd158#r153167625

  Line 98: @stdlib-bot All instances of LEN should be replaced with 100.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/c/benchmark.c

  Lines 95 to 101 in d8cd158

  	*/
  	static double benchmark( void ) {
  	double elapsed;
  	double x[ LEN ];
  	double mu[ LEN ];
  	double sigma[ LEN ];
  	double y;

• d8cd158#r153167628

  Line 100: @stdlib-bot Variable declarations should be ordered by length.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/c/benchmark.c

  Lines 97 to 103 in d8cd158

  	double elapsed;
  	double x[ LEN ];
  	double mu[ LEN ];
  	double sigma[ LEN ];
  	double y;
  	double t;
  	int i;

• d8cd158#r153167632

  Line 23: @stdlib-bot This header is not used and can be removed.

  stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/pdf/examples/c/example.c

  Lines 20 to 26 in d8cd158

  	#include "stdlib/constants/float64/eps.h"
  	#include <stdlib.h>
  	#include <stdio.h>
  	#include <time.h>
  	static double random_uniform( const double min, const double max ) {
  	double v = (double)rand() / ( (double)RAND_MAX + 1.0 );

Interested in helping improve the project? If you are, the comment linked to above has 9 comment(s) from core contributors that could use your attention.

What do you need to do?

1. Open the above linked comments mentioning @stdlib-bot.
2. Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
3. If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
4. Make all the desired changes and commit those changes to a local branch.
5. Push the changes to GitHub and open a new pull request against the develop branch of the main stdlib development repository.

Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.

And that's it!

Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌

---

Notes

• For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!

---

This issue was created automatically to address commit comments tagging @stdlib-bot.

[stdlib-bot]

👋 Important: PLEASE READ 👋

This issue has been labeled as a good first issue and is available for anyone to work on.

If this is your first time contributing to an open source project, some aspects of the development process may seem unusual, arcane, or some combination of both.

1. You cannot "claim" issues. People new to open source often want to "claim" or be assigned an issue before beginning work. The typical rationale is that people want to avoid wasted work in the event that someone else ends up working the issue. However, this practice is not effective in open source, as it often leads to "issue squatting", in which an individual asks to be assigned, is granted their request, and then never ends up working on the issue. Accordingly, you are encouraged to communicate your intent to address this issue, ideally by providing a rough outline as to how you plan to address the issue or asking clarifying questions, but, at the end of the day, we will take running code and rough consensus in order to move forward quickly.
2. We have a very high bar for contributions. We have very high standards for contributions and expect all contributions—whether new features, tests, or documentation—to be rigorous, thorough, and complete. Once a pull request is merged into stdlib, that contribution immediately becomes the collective responsibility of all maintainers of stdlib. When we merge code into stdlib, we are saying that we, the maintainers, commit to reviewing subsequent changes and making bugfixes to the code. Hence, in order to ensure future maintainability, this naturally leads to a higher standard of contribution.

Before working on this issue and opening a pull request, please read the project's contributing guidelines. These guidelines and the associated development guide provide important information, including links to stdlib's Code of Conduct, license policy, and steps for setting up your local development environment.

To reiterate, we strongly encourage you to refer to our contributing guides before beginning work on this issue. Failure to follow our guidelines significantly decreases the likelihood that you'll successfully contribute to stdlib and may result in automatic closure of a pull request without review.

Setting up your local development environment is a critical first step, as doing so ensures that automated development processes for linting, license verification, and unit testing can run prior to authoring commits and pushing changes. If you would prefer to avoid manual setup, we provide pre-configured development containers for use locally or in GitHub Codespaces.

We place a high value on consistency throughout the stdlib codebase. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

• If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
• If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
• If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before beginning work on this issue.

✨ Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. ✨