-
-
Notifications
You must be signed in to change notification settings - Fork 914
Description
This commit has 5 comment(s) from core contributors that require attention.
Commit: e63c0b409b6ce579268ac14d8f1ca4c3ff0b4390
Comments:
-
Line 146: @stdlib-bot Lines 146-149 need to move to L239.
stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/README.md
Lines 143 to 149 in e63c0b4
<!-- /.examples --> <!-- Section to include cited references. If references are included, add a horizontal rule *before* the section. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> <section class="references"> -
Line 238: @stdlib-bot We are missing a closing
</section>
and trailing comment to pair with the<section class="c">
above. See other similar packages for what we are looking for.stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/README.md
Lines 235 to 241 in e63c0b4
} } ``` </section> <!-- /.references --> -
Line 217: @stdlib-bot This header is not used and can be removed.
stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/README.md
Lines 214 to 220 in e63c0b4
#include "stdlib/math/base/special/round.h" #include <stdlib.h> #include <stdio.h> #include <math.h> static double random_uniform( const double min, const double max ) { double v = (double)rand() / ( (double)RAND_MAX + 1.0 ); -
Line 23: @stdlib-bot This header is not used and can be removed.
stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/examples/c/example.c
Lines 20 to 26 in e63c0b4
#include "stdlib/math/base/special/round.h" #include <stdlib.h> #include <stdio.h> #include <math.h> static double random_uniform( const double min, const double max ) { double v = (double)rand() / ( (double)RAND_MAX + 1.0 ); -
Line 24: @stdlib-bot This header is not used and can be removed.
stdlib/lib/node_modules/@stdlib/stats/base/dists/geometric/logpmf/src/main.c
Lines 21 to 27 in e63c0b4
#include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/ln.h" #include "stdlib/constants/float64/ninf.h" #include <math.h> /** * Evaluates the logarithm of the probability mass function (PMF) for a geometric distribution with success probability `p` at a value `x`.
Interested in helping improve the project? If you are, the comment linked to above has 5 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.