Skip to content

chore: remove obsolete accuracy scripts in acosh #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 1 commit into from
Mar 28, 2025
Merged

chore: remove obsolete accuracy scripts in acosh #6409

kgryte merged 1 commit into from
Mar 28, 2025

Conversation

@anandkaranubc
Copy link
Contributor

@anandkaranubc anandkaranubc commented Mar 27, 2025

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • Completes the TODO on cleaning up the deprecated functionality in math/base/special/acosh

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
chore: clean up
28d3310 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 27, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 27, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/acosh $\color{green}217/217$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}217/217$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

anandkaranubc commented Mar 27, 2025

I just want to be doubly sure if this is what 'clean up' means here, because those functions are not being used according to the current code conventions.

kgryte
kgryte approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is fine to remove these files. They originate from an era in which the built-in V8 math implementation was not particularly good (ref: https://github.com/stdlib-js/stdlib/blob/develop/docs/misc/built_in_math_bugs.md). "clean-up" here just meant using stdlib conventions and replacing the use of compute- packages with stdlib equivalents (i.e., this script just needed to be refactored). But it has been 7 years since this was added (maybe earlier if originating from the compute-io days) and JS runtimes have improved their implementations, making this script less relevant.

@kgryte kgryte changed the title chore: clean up chore: remove obsolete accuracy scripts in acosh Mar 28, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 28, 2025
@kgryte kgryte merged commit d6e3fd4 into stdlib-js:develop Mar 28, 2025
52 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 28, 2025
@anandkaranubc @sahil20021008
chore: remove obsolete accuracy scripts in acosh
5e3f643 
PR-URL: stdlib-js#6409
Reviewed-by: Athan Reines <[email protected]>
@anandkaranubc
Copy link
Contributor Author

anandkaranubc commented Mar 29, 2025

But it has been 7 years since this was added (maybe earlier if originating from the compute-io days) and JS runtimes have improved their implementations, making this script less relevant.

Ah, that clicks now 💡. I’ll remove the other ones too then. Thanks for the context!

Bye-bye old days...

@anandkaranubc anandkaranubc deleted the rm/acosh branch May 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anandkaranubc @stdlib-bot @kgryte