-
-
Notifications
You must be signed in to change notification settings - Fork 917
Description
This commit has 5 comment(s) from core contributors that require attention.
Commit: 340a147293f2fb18db097491154b83671c44bdd3
Comments:
-
@stdlib-bot This declaration should be on a single line. No need for a line break.
-
@stdlib-bot This empty line can be removed.
-
@stdlib-bot This function should be removed.
-
@stdlib-bot This should be
x = random_uniform( 0.0, 40.0 );. There is no need to generate a discrete uniform here. -
@stdlib-bot The next two lines should be
x[ i ] = ... lambda[ i ] = ...Meaning, the indices should have spaces around them to be consistent with L60 below.
Interested in helping improve the project? If you are, the comment linked to above has 5 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
developbranch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
-
When creating your pull request, please use the following format for the PR title:
chore: address commit comments for commit `340a147` (issue #NNNN)where
NNNNis the issue number assigned to this issue. -
For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.