-
-
Notifications
You must be signed in to change notification settings - Fork 975
feat: add ndarray/base/binary-reduce-strided1d-dispatch
#7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ndarray/base/binary-reduce-strided1d-dispatch
#7908
Conversation
|
/stdlib merge |
…ary-reduce-strided1d-dispatch
|
This PR is dependent on #7904. |
|
/stdlib merge |
…ary-reduce-strided1d-dispatch
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@gururaj1512 Now that #7904 is merged, is there anything else you want to do to this PR before review? Note that I changed some of the logic in #7904. In particular, for each input ndarray, to determine the casting data type, one would do Here, the first argument corresponds to the array dtype that you want to figure out the casting data type and the second argument corresponds to the "additional"/other input ndarray data type. |
|
The lint failure seems to be due to a recently added lint rule which is buggy. |
|
/stdlib merge |
…ary-reduce-strided1d-dispatch
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: skipped
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after clean-up.
|
As the CI lint failure is expected, I'll go ahead and merge. |
Resolves None
Description
This pull request:
ndarray/base/binary-reduce-strided1d-dispatchRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers