-
-
Notifications
You must be signed in to change notification settings - Fork 993
chore: address commit comments for commit 8b0b780 #8072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address commit comments for commit 8b0b780 #8072
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@rajanarahul93 You didn't actually address the commit comments. Please review the comments in 8b0b780. |
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajanarahul93 Please pay attention to the changes that I made which actually resolve the commit comments. Simply adding random blank lines is not what we want.
|
@kgryte Thank you for merging the PR. I’ll make sure not to repeat this mistake next time. |
Resolves #8027.
Description
This pull request:
Related Issues
This pull request:
8b0b780) #8027Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers