Skip to content

Conversation

Payal-Goswami
Copy link
Contributor

@Payal-Goswami Payal-Goswami commented Sep 17, 2025

Resolves #8087.

Description

This pull request fixes several linting errors reported in publish_packages.js for issue #8087.

Changes made:

  • Shortened variable and function names

  • Broke long lines to respect max length

  • Removed trailing spaces

  • Adjusted formatting

    Additionally, a //TODO: comment was changed to //Note: for clarity. No functional changes were made.

Note: This PR only fixes lint errors in publish_packages.js. No exported APIs or functionality were modified, so the behavior of the code remains unchanged. Existing tests were not run locally due to Windows Make limitations, but these changes do not affect test outcomes.

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 17, 2025
@Payal-Goswami
Copy link
Contributor Author

Update: I realized that the original //TODO: is still relevant. In this PR, it was temporarily changed to //NOTE: purely for style/lint cleanup. The underlying task has not been addressed and will remain for future implementation. This PR does not remove or modify any functional code.

@kgryte
Copy link
Member

kgryte commented Sep 17, 2025

This PR doesn't actually address the upstream issue. As such, I will close.

If you want to address #8087, please focus on only updating the relevant files. Thanks.

@kgryte kgryte closed this Sep 17, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

3 participants