From a09a36357f4b1be069341d0fc7ce2caba3fc50eb Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Fri, 6 Sep 2024 09:51:09 +0530 Subject: [PATCH 1/6] refactor: use discrete-uniform to generate random integers, style fixes --- .../@stdlib/math/base/special/logf/README.md | 9 ++++----- .../@stdlib/math/base/special/logf/examples/index.js | 7 +++---- .../@stdlib/math/base/special/logf/src/main.c | 2 +- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/README.md b/lib/node_modules/@stdlib/math/base/special/logf/README.md index 8a159148b33d..407bd151c837 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/logf/README.md @@ -20,7 +20,7 @@ limitations under the License. # Logarithm -> Compute the base `b` [logarithm][logarithm] of a single-precision floating-point number.. +> Compute the base `b` [logarithm][logarithm] of a single-precision floating-point number.
@@ -66,8 +66,7 @@ v = logf( 2.0, -4.0 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var roundf = require( '@stdlib/math/base/special/roundf' ); +var randu = require( '@stdlib/random/base/discrete-uniform' ); var logf = require( '@stdlib/math/base/special/logf' ); var b; @@ -75,8 +74,8 @@ var x; var i; for ( i = 0; i < 100; i++ ) { - x = roundf( randu() * 100.0 ); - b = roundf( randu() * 5.0 ); + x = randu() * 100.0; + b = randu() * 5.0; console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); } ``` diff --git a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js index e04f893cb217..6c9313cf6f77 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js @@ -18,8 +18,7 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var roundf = require( '@stdlib/math/base/special/roundf' ); +var randu = require( '@stdlib/random/base/discrete-uniform' ); var logf = require( './../lib' ); var b; @@ -27,7 +26,7 @@ var x; var i; for ( i = 0; i < 100; i++ ) { - x = roundf( randu() * 100.0 ); - b = roundf( randu() * 5.0 ); + x = randu() * 100.0; + b = randu() * 5.0; console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); } diff --git a/lib/node_modules/@stdlib/math/base/special/logf/src/main.c b/lib/node_modules/@stdlib/math/base/special/logf/src/main.c index 11fcbe53f1a9..e316a525ec05 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/logf/src/main.c @@ -24,7 +24,7 @@ * * @param x input value * @param b input value -* @return output value +* @return output value * * @example * float out = stdlib_base_logf( 100.0f, 10.0f ); From 525dc04f16c65e39ae4e2463f2b97168ebff1694 Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Fri, 6 Sep 2024 09:56:58 +0530 Subject: [PATCH 2/6] refactor: use discrete-uniform to generate random integers, style fixes --- lib/node_modules/@stdlib/math/base/special/logf/README.md | 6 +++--- .../@stdlib/math/base/special/logf/examples/index.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/README.md b/lib/node_modules/@stdlib/math/base/special/logf/README.md index 407bd151c837..70ef7001a3fc 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/logf/README.md @@ -66,7 +66,7 @@ v = logf( 2.0, -4.0 ); ```javascript -var randu = require( '@stdlib/random/base/discrete-uniform' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var logf = require( '@stdlib/math/base/special/logf' ); var b; @@ -74,8 +74,8 @@ var x; var i; for ( i = 0; i < 100; i++ ) { - x = randu() * 100.0; - b = randu() * 5.0; + x = discreteUniform( 0, 100 ); + b = discreteUniform( 0, 5 ); console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); } ``` diff --git a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js index 6c9313cf6f77..566e2e8fb2c1 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js @@ -18,7 +18,7 @@ 'use strict'; -var randu = require( '@stdlib/random/base/discrete-uniform' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var logf = require( './../lib' ); var b; @@ -26,7 +26,7 @@ var x; var i; for ( i = 0; i < 100; i++ ) { - x = randu() * 100.0; - b = randu() * 5.0; + x = discreteUniform( 0, 100 ); + b = discreteUniform( 0, 5 ); console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); } From 22dfd0863e0690f9403cc7ed94ef5a18aed030f3 Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Fri, 6 Sep 2024 10:03:30 +0530 Subject: [PATCH 3/6] refactor: use discrete-uniform to generate random integers, style fixes --- lib/node_modules/@stdlib/math/base/special/logf/README.md | 2 +- .../@stdlib/math/base/special/logf/examples/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/README.md b/lib/node_modules/@stdlib/math/base/special/logf/README.md index 70ef7001a3fc..a97a51a6e3e5 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/logf/README.md @@ -66,7 +66,7 @@ v = logf( 2.0, -4.0 ); ```javascript -var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); var logf = require( '@stdlib/math/base/special/logf' ); var b; diff --git a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js index 566e2e8fb2c1..cd31f9381589 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js @@ -18,7 +18,7 @@ 'use strict'; -var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); +var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); var logf = require( './../lib' ); var b; From 3b72beb39f80df30321a26f7d4c37757c494863e Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Sat, 7 Sep 2024 08:30:22 +0530 Subject: [PATCH 4/6] docs: use random/array/discrete-uniform in JS examples --- .../@stdlib/math/base/special/logf/README.md | 15 +++++++++------ .../math/base/special/logf/examples/index.js | 15 +++++++++------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/README.md b/lib/node_modules/@stdlib/math/base/special/logf/README.md index a97a51a6e3e5..b857519fadb1 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/logf/README.md @@ -66,17 +66,20 @@ v = logf( 2.0, -4.0 ); ```javascript -var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); +var randu = require( '@stdlib/random/array/discrete-uniform' ); var logf = require( '@stdlib/math/base/special/logf' ); -var b; -var x; +var opts = { + 'dtype': 'float32' +}; + +var x = randu( 100, 0, 100, opts ); +var b = randu( 100, 0, 5, opts ); + var i; for ( i = 0; i < 100; i++ ) { - x = discreteUniform( 0, 100 ); - b = discreteUniform( 0, 5 ); - console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); + console.log( 'logf( %d, %d ) = %d', x[ i ], b[ i ], logf( x[ i ], b[ i ] ) ); } ``` diff --git a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js index cd31f9381589..d000a742f66d 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js @@ -18,15 +18,18 @@ 'use strict'; -var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); +var randu = require( '@stdlib/random/array/discrete-uniform' ); var logf = require( './../lib' ); -var b; -var x; +var opts = { + 'dtype': 'float32' +}; + +var x = randu( 100, 0, 100, opts ); +var b = randu( 100, 0, 5, opts ); + var i; for ( i = 0; i < 100; i++ ) { - x = discreteUniform( 0, 100 ); - b = discreteUniform( 0, 5 ); - console.log( 'logf( %d, %d ) = %d', x, b, logf( x, b ) ); + console.log( 'logf( %d, %d ) = %d', x[ i ], b[ i ], logf( x[ i ], b[ i ] ) ); } From 585abba89bc687c815c42fb892ddc757e0584b45 Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 6 Sep 2024 20:44:49 -0700 Subject: [PATCH 5/6] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/math/base/special/logf/examples/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js index d000a742f66d..609da6ad28a5 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/logf/examples/index.js @@ -29,7 +29,6 @@ var x = randu( 100, 0, 100, opts ); var b = randu( 100, 0, 5, opts ); var i; - for ( i = 0; i < 100; i++ ) { console.log( 'logf( %d, %d ) = %d', x[ i ], b[ i ], logf( x[ i ], b[ i ] ) ); } From 4e260958a68d5178cc4ee3f6f6aecc3775351ddc Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 6 Sep 2024 20:44:56 -0700 Subject: [PATCH 6/6] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/math/base/special/logf/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/logf/README.md b/lib/node_modules/@stdlib/math/base/special/logf/README.md index b857519fadb1..f9dbab88d00d 100644 --- a/lib/node_modules/@stdlib/math/base/special/logf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/logf/README.md @@ -77,7 +77,6 @@ var x = randu( 100, 0, 100, opts ); var b = randu( 100, 0, 5, opts ); var i; - for ( i = 0; i < 100; i++ ) { console.log( 'logf( %d, %d ) = %d', x[ i ], b[ i ], logf( x[ i ], b[ i ] ) ); }