From f5b30600b0e47895d7351157fdc1a475c8a21b9f Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Sat, 7 Sep 2024 00:47:44 +0530 Subject: [PATCH 1/2] refactor: use random/array/uniform in examples, style fixes in math/base/special/minabsf --- .../math/base/special/minabsf/README.md | 21 ++++++++++++------- .../math/base/special/minabsf/docs/repl.txt | 8 +++---- .../special/minabsf/docs/types/index.d.ts | 4 ++-- .../base/special/minabsf/examples/index.js | 15 ++++++++----- .../math/base/special/minabsf/lib/index.js | 4 ++-- .../math/base/special/minabsf/lib/main.js | 4 ++-- .../math/base/special/minabsf/lib/native.js | 4 ++-- .../math/base/special/minabsf/src/main.c | 2 +- 8 files changed, 36 insertions(+), 26 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/README.md b/lib/node_modules/@stdlib/math/base/special/minabsf/README.md index 7298c31b1795..a8c557de9a9c 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/README.md @@ -45,8 +45,8 @@ var minabsf = require( '@stdlib/math/base/special/minabsf' ); Returns the minimum absolute single-precision floating-point number. ```javascript -var v = minabsf( -4.2, 3.14 ); -// returns ~3.14 +var v = minabsf( -4.0, 3.0 ); +// returns 3.0 v = minabsf( +0.0, -0.0 ); // returns +0.0 @@ -83,19 +83,24 @@ v = minabsf( NaN, 3.14 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); +var randu = require( '@stdlib/random/array/uniform' ); var minabsf = require( '@stdlib/math/base/special/minabsf' ); +var opts = { + 'dtype': 'float32' +}; + var x; var y; var v; var i; +x = randu( 100, -500.0, 500.0, opts ); +y = randu( 100, -500.0, 500.0, opts ); + for ( i = 0; i < 100; i++ ) { - x = ( randu() * 1000.0 ) - 500.0; - y = ( randu() * 1000.0 ) - 500.0; - v = minabsf( x, y ); - console.log( 'minabsf(%d,%d) = %d', x, y, v ); + v = minabsf( x[ i ], y[ i ] ); + console.log( 'minabsf(%d,%d) = %d', x[ i ], y[ i ], v ); } ``` @@ -178,7 +183,7 @@ int main( void ) { float y; float v; int i; - + for ( i = 0; i < 100; i++ ) { x = ( ( (float)rand() / (float)RAND_MAX ) * 1000.0f ) - 500.0f; y = ( ( (float)rand() / (float)RAND_MAX ) * 1000.0f ) - 500.0f; diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/docs/repl.txt b/lib/node_modules/@stdlib/math/base/special/minabsf/docs/repl.txt index c77a7b8df1a3..11cd5bdf248d 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/docs/repl.txt +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/docs/repl.txt @@ -1,7 +1,7 @@ {{alias}}( x, y ) - Returns the minimum absolute absolute single-precision - floating-point number. + Returns the minimum absolute single-precision floating-point + number. If any argument is `NaN`, the function returns `NaN`. @@ -20,8 +20,8 @@ Examples -------- - > var v = {{alias}}( 3.14, -4.2 ) - ~3.14 + > var v = {{alias}}( -4.0, 3.0 ) + 3.0 > v = {{alias}}( 3.14, NaN ) NaN > v = {{alias}}( +0.0, -0.0 ) diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/docs/types/index.d.ts b/lib/node_modules/@stdlib/math/base/special/minabsf/docs/types/index.d.ts index 11c8a3a336c2..c86826eb3a1a 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/docs/types/index.d.ts @@ -26,8 +26,8 @@ * @returns minimum absolute value * * @example -* var v = minabsf( -3.14, 4.2 ); -* // returns ~3.14 +* var v = minabsf( -4.0, 3.0 ); +* // returns 3.0 * * @example * var v = minabsf( 3.14, NaN ); diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js index 0ed0a319ed5d..9091d01e329d 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js @@ -18,17 +18,22 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); +var randu = require( '@stdlib/random/array/uniform' ); var minabsf = require( './../lib' ); +var opts = { + 'dtype': 'float32' +}; + var x; var y; var v; var i; +x = randu( 100, -500.0, 500.0, opts ); +y = randu( 100, -500.0, 500.0, opts ); + for ( i = 0; i < 100; i++ ) { - x = ( randu() * 1000.0 ) - 500.0; - y = ( randu() * 1000.0 ) - 500.0; - v = minabsf( x, y ); - console.log( 'minabsf(%d,%d) = %d', x, y, v ); + v = minabsf( x[ i ], y[ i ] ); + console.log( 'minabsf(%d,%d) = %d', x[ i ], y[ i ], v ); } diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/index.js b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/index.js index c260f6e9a682..7c38d4b7e2ea 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/index.js +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/index.js @@ -26,8 +26,8 @@ * @example * var minabsf = require( '@stdlib/math/base/special/minabsf' ); * -* var v = minabsf( -3.14, 4.2 ); -* // returns ~3.14 +* var v = minabsf( -4.0, 3.0 ); +* // returns 3.0 * * v = min( 3.14, NaN ); * // returns NaN diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/main.js b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/main.js index dcdf5ffa578a..7cb15c813284 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/main.js +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/main.js @@ -35,8 +35,8 @@ var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); * @returns {number} minimum absolute value * * @example -* var v = minabsf( -3.14, 4.2 ); -* // returns ~3.14 +* var v = minabsf( -4.0, 3.0 ); +* // returns 3.0 * * @example * var v = minabsf( 3.14, NaN ); diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/native.js b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/native.js index e7bcde4b1ab3..baf8ca0809bc 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/lib/native.js +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/lib/native.js @@ -34,8 +34,8 @@ var addon = require( './../src/addon.node' ); * @returns {number} minimum absolute value * * @example -* var v = minabsf( -4.2, 3.14 ); -* // returns ~3.14 +* var v = minabsf( -4.0, 3.0 ); +* // returns 3.0 * * @example * var v = minabsf( 0.0, -0.0 ); diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/src/main.c b/lib/node_modules/@stdlib/math/base/special/minabsf/src/main.c index 382b8b8be63b..07499b1c8479 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/src/main.c @@ -29,7 +29,7 @@ * * @example * float v = stdlib_base_minabsf( 3.14f, -4.2f ); -* // returns ~3.14f +* // returns 3.14f * * @example * float v = stdlib_base_minabsf( 0.0f, -0.0f ); From 3c71a0218cc9a1397a3817b3162fdd449e85522c Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 6 Sep 2024 16:15:03 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/math/base/special/minabsf/README.md | 9 +++------ .../@stdlib/math/base/special/minabsf/examples/index.js | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/README.md b/lib/node_modules/@stdlib/math/base/special/minabsf/README.md index a8c557de9a9c..296ad0d7571a 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/README.md @@ -90,14 +90,11 @@ var opts = { 'dtype': 'float32' }; -var x; -var y; +var x = randu( 100, -500.0, 500.0, opts ); +var y = randu( 100, -500.0, 500.0, opts ); + var v; var i; - -x = randu( 100, -500.0, 500.0, opts ); -y = randu( 100, -500.0, 500.0, opts ); - for ( i = 0; i < 100; i++ ) { v = minabsf( x[ i ], y[ i ] ); console.log( 'minabsf(%d,%d) = %d', x[ i ], y[ i ], v ); diff --git a/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js index 9091d01e329d..6672757eee7c 100644 --- a/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/minabsf/examples/index.js @@ -25,14 +25,11 @@ var opts = { 'dtype': 'float32' }; -var x; -var y; +var x = randu( 100, -500.0, 500.0, opts ); +var y = randu( 100, -500.0, 500.0, opts ); + var v; var i; - -x = randu( 100, -500.0, 500.0, opts ); -y = randu( 100, -500.0, 500.0, opts ); - for ( i = 0; i < 100; i++ ) { v = minabsf( x[ i ], y[ i ] ); console.log( 'minabsf(%d,%d) = %d', x[ i ], y[ i ], v );