From f0c5b789cb51293ece31d5e017a6ceae1e1d49cc Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 11:55:01 +0530 Subject: [PATCH 01/11] refactor: updated README.md according to latest project conventions --- .../@stdlib/blas/ext/base/ssort2sh/README.md | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md index 989241e23775..dc1eb8879b5a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md @@ -58,17 +58,15 @@ The function has the following parameters: - **y**: second input [`Float32Array`][@stdlib/array/float32]. - **strideY**: `y` index increment. -The `N` and `stride` parameters determine which elements in `x` and `y` are accessed at runtime. For example, to sort every other element +The `N` and stride parameters determine which elements in the strided arrays are accessed at runtime. For example, to sort every other element ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x = new Float32Array( [ 1.0, -2.0, 3.0, -4.0 ] ); var y = new Float32Array( [ 0.0, 1.0, 2.0, 3.0 ] ); -var N = floor( x.length / 2 ); -ssort2sh( N, -1.0, x, 2, y, 2 ); +ssort2sh( 2, -1.0, x, 2, y, 2 ); console.log( x ); // => [ 3.0, -2.0, 1.0, -4.0 ] @@ -81,7 +79,6 @@ Note that indexing is relative to the first index. To introduce an offset, use [ ```javascript var Float32Array = require( '@stdlib/array/float32' ); -var floor = require( '@stdlib/math/base/special/floor' ); // Initial arrays... var x0 = new Float32Array( [ 1.0, 2.0, 3.0, 4.0 ] ); @@ -90,10 +87,9 @@ var y0 = new Float32Array( [ 0.0, 1.0, 2.0, 3.0 ] ); // Create offset views... var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element var y1 = new Float32Array( y0.buffer, y0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var N = floor( x0.length/2 ); // Sort every other element... -ssort2sh( N, -1.0, x1, 2, y1, 2 ); +ssort2sh( 2, -1.0, x1, 2, y1, 2 ); console.log( x0 ); // => [ 1.0, 4.0, 3.0, 2.0 ] @@ -126,7 +122,7 @@ The function has the following additional parameters: - **offsetX**: `x` starting index. - **offsetY**: `y` starting index. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to access only the last three elements of `x` +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the offset parameter supports indexing semantics based on a starting index. For example, to access only the last three elements of `x` ```javascript var Float32Array = require( '@stdlib/array/float32' ); From e5bb8fcf137396957f387a013917fdfb3a787ef4 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:01:07 +0530 Subject: [PATCH 02/11] refactor: updated docs to follow latest project conventions --- .../blas/ext/base/ssort2sh/docs/repl.txt | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt index 37f778a10017..2cb78c10b3fc 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt @@ -1,10 +1,10 @@ {{alias}}( N, order, x, strideX, y, strideY ) - Simultaneously sorts two single-precision floating-point strided arrays - based on the sort order of the first array using Shellsort. + Simultaneously sorts two single-precision floating-point + strided arrays based on the sort order of the first array using Shellsort. - The `N` and `stride` parameters determine which elements in `x` and `y` are - accessed at runtime. + The `N` and stride parameters determine which elements in the + strided arrays are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use typed array views. @@ -67,11 +67,10 @@ > y [ 3.0, 1.0, 0.0, 2.0 ] - // Using `N` and `stride` parameters: + // Using `N` and stride parameters: > x = new {{alias:@stdlib/array/float32}}( [ 1.0, -2.0, 3.0, -4.0 ] ); > y = new {{alias:@stdlib/array/float32}}( [ 0.0, 1.0, 2.0, 3.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > {{alias}}( N, -1, x, 2, y, 2 ) + > {{alias}}( 2, -1, x, 2, y, 2 ) [ 3.0, -2.0, 1.0, -4.0 ] > y [ 2.0, 1.0, 0.0, 3.0 ] @@ -81,21 +80,21 @@ > var x1 = new {{alias:@stdlib/array/float32}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); > var y0 = new {{alias:@stdlib/array/float32}}( [ 0.0, 1.0, 2.0, 3.0 ] ); > var y1 = new {{alias:@stdlib/array/float32}}( y0.buffer, y0.BYTES_PER_ELEMENT*1 ); - > N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 ); - > {{alias}}( N, 1, x1, 2, y1, 2 ) + > {{alias}}( 2, 1, x1, 2, y1, 2 ) [ -4.0, 3.0, -2.0 ] > x0 [ 1.0, -4.0, 3.0, -2.0 ] > y0 [ 0.0, 3.0, 2.0, 1.0 ] + {{alias}}.ndarray( N, order, x, strideX, offsetX, y, strideY, offsetY ) Simultaneously sorts two single-precision floating-point strided arrays based on the sort order of the first array using Shellsort and alternative indexing semantics. While typed array views mandate a view offset based on the underlying - buffer, the `offset` parameter supports indexing semantics based on a + buffer, the offset parameter supports indexing semantics based on a starting index. Parameters @@ -143,8 +142,7 @@ // Using an index offset: > x = new {{alias:@stdlib/array/float32}}( [ 1.0, -2.0, 3.0, -4.0 ] ); > y = new {{alias:@stdlib/array/float32}}( [ 0.0, 1.0, 2.0, 3.0 ] ); - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > {{alias}}.ndarray( N, 1, x, 2, 1, y, 2, 1 ) + > {{alias}}.ndarray( 2, 1, x, 2, 1, y, 2, 1 ) [ 1.0, -4.0, 3.0, -2.0 ] > y [ 0.0, 3.0, 2.0, 1.0 ] From 55b9d029261678e5012ec41e593741aab3a6df33 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:03:29 +0530 Subject: [PATCH 03/11] refactor: updated examples to follow latest project conventions --- .../@stdlib/blas/ext/base/ssort2sh/examples/index.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/examples/index.js index 3d5077d08ebb..3328847d22a2 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/examples/index.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/examples/index.js @@ -25,12 +25,10 @@ var ssort2sh = require( './../lib' ); var rand; var sign; -var x; -var y; var i; -x = new Float32Array( 10 ); -y = new Float32Array( 10 ); // index array +var x = new Float32Array( 10 ); +var y = new Float32Array( 10 ); // index array for ( i = 0; i < x.length; i++ ) { if ( randu() < 0.2 ) { x[ i ] = NaN; From f0b4ae2c8cec9cffd584afa8b62b266f6c1e27c2 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:19:51 +0530 Subject: [PATCH 04/11] feat: added addon in C and removed the C++ addon --- .../blas/ext/base/ssort2sh/src/addon.c | 46 +++++ .../blas/ext/base/ssort2sh/src/addon.cpp | 164 ------------------ 2 files changed, 46 insertions(+), 164 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c delete mode 100644 lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.cpp diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c new file mode 100644 index 000000000000..2f4859448924 --- /dev/null +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c @@ -0,0 +1,46 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2018 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/blas/ext/base/ssort2sh.h" +#include "stdlib/napi/export.h" +#include "stdlib/napi/argv.h" +#include "stdlib/napi/argv_int64.h" +#include "stdlib/napi/argv_float.h" +#include "stdlib/napi/argv_strided_float32array.h" +#include + +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV_FLOAT( env, order, argv, 1 ); + STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 ); + STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 ); + STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 4 ); + c_ssort2sh( N, order, X, strideX, Y, strideY ); + return NULL; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.cpp b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.cpp deleted file mode 100644 index 199d8e6ec62e..000000000000 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.cpp +++ /dev/null @@ -1,164 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/blas/ext/base/ssort2sh.h" -#include -#include -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_blas_ext_base_ssort2sh { - - /** - * Simultaneously sorts two single-precision floating-point strided arrays based on the sort order of the first array using Shellsort. - * - * ## Notes - * - * - When called from JavaScript, the function expects six arguments: - * - * - `N`: number of indexed elements - * - `order`: sort order - * - `X`: first input array - * - `strideX`: `X` stride length - * - `Y`: second input array - * - `strideY`: `Y` stride length - */ - napi_value node_ssort2sh( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 6; - napi_value argv[ 6 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 6 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide 6 arguments." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - if ( vtype0 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. First argument must be a number." ); - return nullptr; - } - - napi_valuetype vtype1; - status = napi_typeof( env, argv[ 1 ], &vtype1 ); - assert( status == napi_ok ); - if ( vtype1 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Second argument must be a number." ); - return nullptr; - } - - bool res2; - status = napi_is_typedarray( env, argv[ 2 ], &res2 ); - assert( status == napi_ok ); - if ( res2 == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float32Array." ); - return nullptr; - } - - napi_valuetype vtype3; - status = napi_typeof( env, argv[ 3 ], &vtype3 ); - assert( status == napi_ok ); - if ( vtype3 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Fourth argument must be a number." ); - return nullptr; - } - - bool res4; - status = napi_is_typedarray( env, argv[ 4 ], &res4 ); - assert( status == napi_ok ); - if ( res4 == false ) { - napi_throw_type_error( env, nullptr, "invalid argument. Fifth argument must be a Float32Array." ); - return nullptr; - } - - napi_valuetype vtype5; - status = napi_typeof( env, argv[ 5 ], &vtype5 ); - assert( status == napi_ok ); - if ( vtype5 != napi_number ) { - napi_throw_type_error( env, nullptr, "invalid argument. Sixth argument must be a number." ); - return nullptr; - } - - int64_t N; - status = napi_get_value_int64( env, argv[ 0 ], &N ); - assert( status == napi_ok ); - - double order; - status = napi_get_value_double( env, argv[ 1 ], &order ); - assert( status == napi_ok ); - - int64_t strideX; - status = napi_get_value_int64( env, argv[ 3 ], &strideX ); - assert( status == napi_ok ); - - int64_t strideY; - status = napi_get_value_int64( env, argv[ 5 ], &strideY ); - assert( status == napi_ok ); - - napi_typedarray_type vtype2; - size_t xlen; - void *X; - status = napi_get_typedarray_info( env, argv[ 2 ], &vtype2, &xlen, &X, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype2 != napi_float32_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Third argument must be a Float32Array." ); - return nullptr; - } - if ( (N-1)*llabs(strideX) >= (int64_t)xlen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Third argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - napi_typedarray_type vtype4; - size_t ylen; - void *Y; - status = napi_get_typedarray_info( env, argv[ 4 ], &vtype4, &ylen, &Y, nullptr, nullptr ); - assert( status == napi_ok ); - if ( vtype4 != napi_float32_array ) { - napi_throw_type_error( env, nullptr, "invalid argument. Fifth argument must be a Float32Array." ); - return nullptr; - } - if ( (N-1)*llabs(strideY) >= (int64_t)ylen ) { - napi_throw_range_error( env, nullptr, "invalid argument. Fifth argument has insufficient elements based on the associated stride and the number of indexed elements." ); - return nullptr; - } - - c_ssort2sh( N, (float)order, (float *)X, strideX, (float *)Y, strideY ); - - return nullptr; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_ssort2sh, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_blas_ext_base_ssort2sh From 79fce31794f702125e4a2ca0f5339fc01d3d0948 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:28:56 +0530 Subject: [PATCH 05/11] refactor: updated dependencies --- .../blas/ext/base/ssort2sh/include.gypi | 2 +- .../blas/ext/base/ssort2sh/manifest.json | 76 ++++++++++++++----- .../blas/ext/base/ssort2sh/package.json | 4 +- 3 files changed, 63 insertions(+), 19 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/include.gypi b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/include.gypi index 868c5c12e852..26476a8c2655 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/include.gypi +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' Date: Sat, 28 Sep 2024 12:37:24 +0530 Subject: [PATCH 06/11] refactor: simplified code in lib --- .../ext/base/ssort2sh/lib/ndarray.native.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js index edef90289cae..f2a33d992b49 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js @@ -20,7 +20,8 @@ // MODULES // -var Float32Array = require( '@stdlib/array/float32' ); +var reinterpret = require( '@stdlib/strided/base/reinterpret-complex64' ); +var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' ); var addon = require( './ssort2sh.native.js' ); @@ -59,17 +60,11 @@ function ssort2sh( N, order, x, strideX, offsetX, y, strideY, offsetY ) { var flg; flg = 1.0; - if ( strideX < 0 ) { - flg *= -1.0; // reversing order - order *= -1.0; - strideX *= -1; - offsetX -= (N-1) * strideX; - } - if ( strideY < 0 ) { - offsetY += (N-1) * strideY; - } - viewX = new Float32Array( x.buffer, x.byteOffset+(x.BYTES_PER_ELEMENT*offsetX), x.length-offsetX ); // eslint-disable-line max-len - viewY = new Float32Array( y.buffer, y.byteOffset+(y.BYTES_PER_ELEMENT*offsetY), y.length-offsetY ); // eslint-disable-line max-len + offsetX = minViewBufferIndex( N, strideX, offsetX ); + offsetY = minViewBufferIndex( N, strideY, offsetY ); + viewX = reinterpret( x, offsetX ); + viewY = reinterpret( y, offsetY ); + addon( N, order, viewX, strideX, viewY, flg*strideY ); return x; } From 6e415531bb41e48e280dfe8286f3f5e7092badec Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:39:47 +0530 Subject: [PATCH 07/11] refactor: updated docs --- .../@stdlib/blas/ext/base/ssort2sh/docs/types/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/types/index.d.ts index c644f153c820..0b525486a5a7 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/types/index.d.ts @@ -85,9 +85,9 @@ interface Routine { * @param N - number of indexed elements * @param order - sort order * @param x - first input array -* @param strideX - `x` stride length +* @param strideX - first stride length * @param y - second input array -* @param strideY - `y` stride length +* @param strideY - second stride length * @returns `x` * * @example From 6031ed901896aebf44fbf4e65a3e5990bb565fb4 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 12:55:03 +0530 Subject: [PATCH 08/11] fix: restored changes in lib --- .../ext/base/ssort2sh/lib/ndarray.native.js | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js index f2a33d992b49..edef90289cae 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/lib/ndarray.native.js @@ -20,8 +20,7 @@ // MODULES // -var reinterpret = require( '@stdlib/strided/base/reinterpret-complex64' ); -var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' ); +var Float32Array = require( '@stdlib/array/float32' ); var addon = require( './ssort2sh.native.js' ); @@ -60,11 +59,17 @@ function ssort2sh( N, order, x, strideX, offsetX, y, strideY, offsetY ) { var flg; flg = 1.0; - offsetX = minViewBufferIndex( N, strideX, offsetX ); - offsetY = minViewBufferIndex( N, strideY, offsetY ); - viewX = reinterpret( x, offsetX ); - viewY = reinterpret( y, offsetY ); - + if ( strideX < 0 ) { + flg *= -1.0; // reversing order + order *= -1.0; + strideX *= -1; + offsetX -= (N-1) * strideX; + } + if ( strideY < 0 ) { + offsetY += (N-1) * strideY; + } + viewX = new Float32Array( x.buffer, x.byteOffset+(x.BYTES_PER_ELEMENT*offsetX), x.length-offsetX ); // eslint-disable-line max-len + viewY = new Float32Array( y.buffer, y.byteOffset+(y.BYTES_PER_ELEMENT*offsetY), y.length-offsetY ); // eslint-disable-line max-len addon( N, order, viewX, strideX, viewY, flg*strideY ); return x; } From ced83fdd73e62f57706a80cad34ad9ed04d9ea7e Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 13:01:31 +0530 Subject: [PATCH 09/11] fix: fixed addon.c --- lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c index 2f4859448924..96ca62292b7e 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c @@ -32,7 +32,7 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - STDLIB_NAPI_ARGV( env, info, argv, argc, 4 ); + STDLIB_NAPI_ARGV( env, info, argv, argc, 6 ); STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); STDLIB_NAPI_ARGV_FLOAT( env, order, argv, 1 ); STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 ); From f5a25e46f85946800f344aab67ea971503876ff7 Mon Sep 17 00:00:00 2001 From: aayush0325 <96649223+aayush0325@users.noreply.github.com> Date: Sat, 28 Sep 2024 17:41:54 +0530 Subject: [PATCH 10/11] refactor: updated readme --- lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md index dc1eb8879b5a..0cd09a49dd48 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/README.md @@ -173,12 +173,10 @@ var ssort2sh = require( '@stdlib/blas/ext/base/ssort2sh' ); var rand; var sign; -var x; -var y; var i; -x = new Float32Array( 10 ); -y = new Float32Array( 10 ); // index array +var x = new Float32Array( 10 ); +var y = new Float32Array( 10 ); // index array for ( i = 0; i < x.length; i++ ) { rand = round( randu()*100.0 ); sign = randu(); From 05d09566aa1432c1bca587e5fe81e7c78c9947e5 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Sun, 29 Sep 2024 15:19:16 -0400 Subject: [PATCH 11/11] chore: update indentation and line wrapping --- .../blas/ext/base/ssort2sh/docs/repl.txt | 12 ++--- .../blas/ext/base/ssort2sh/manifest.json | 50 +++++++++---------- .../blas/ext/base/ssort2sh/src/addon.c | 8 +-- 3 files changed, 35 insertions(+), 35 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt index 2cb78c10b3fc..c9ac32d03f0c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/docs/repl.txt @@ -1,10 +1,10 @@ {{alias}}( N, order, x, strideX, y, strideY ) - Simultaneously sorts two single-precision floating-point - strided arrays based on the sort order of the first array using Shellsort. + Simultaneously sorts two single-precision floating-point strided arrays + based on the sort order of the first array using Shellsort. - The `N` and stride parameters determine which elements in the - strided arrays are accessed at runtime. + The `N` and stride parameters determine which elements in the strided arrays + are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use typed array views. @@ -94,8 +94,8 @@ indexing semantics. While typed array views mandate a view offset based on the underlying - buffer, the offset parameter supports indexing semantics based on a - starting index. + buffer, the offset parameter supports indexing semantics based on a starting + index. Parameters ---------- diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/manifest.json index f54417391b96..d9e7dc0bcc24 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/manifest.json +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/manifest.json @@ -1,30 +1,30 @@ { - "options": { + "options": { "task": "build" }, - "fields": [ - { - "field": "src", - "resolve": true, - "relative": true - }, - { - "field": "include", - "resolve": true, - "relative": true - }, - { - "field": "libraries", - "resolve": false, - "relative": false - }, - { - "field": "libpath", - "resolve": true, - "relative": false - } - ], - "confs": [ + "fields": [ + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } + ], + "confs": [ { "task": "build", "src": [ @@ -81,5 +81,5 @@ "@stdlib/math/base/assert/is-negative-zerof" ] } - ] + ] } diff --git a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c index 96ca62292b7e..32a9cca3f3dd 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c +++ b/lib/node_modules/@stdlib/blas/ext/base/ssort2sh/src/addon.c @@ -32,15 +32,15 @@ * @return Node-API value */ static napi_value addon( napi_env env, napi_callback_info info ) { - STDLIB_NAPI_ARGV( env, info, argv, argc, 6 ); - STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); + STDLIB_NAPI_ARGV( env, info, argv, argc, 6 ); + STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 ); STDLIB_NAPI_ARGV_FLOAT( env, order, argv, 1 ); STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 ); STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 ); STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 ); STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 4 ); - c_ssort2sh( N, order, X, strideX, Y, strideY ); - return NULL; + c_ssort2sh( N, order, X, strideX, Y, strideY ); + return NULL; } STDLIB_NAPI_MODULE_EXPORT_FCN( addon )