From 3b1e99476c19d0e563439c7914b0799b31fc15d3 Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Tue, 3 Dec 2024 22:50:00 +0530 Subject: [PATCH 1/3] docs: update js examples --- .../@stdlib/math/base/special/lcmf/README.md | 12 +++++------- .../@stdlib/math/base/special/lcmf/examples/index.js | 12 +++++------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md index 9215e3bac914..8783a4a21577 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md @@ -101,20 +101,18 @@ v = lcmf( 48, NaN ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var roundf = require( '@stdlib/math/base/special/roundf' ); +var randu = require( '@stdlib/random/array/discrete-uniform' ); var lcmf = require( '@stdlib/math/base/special/lcmf' ); var a; var b; -var v; var i; +a = randu( 100, 0, 50 ); +b = randu( 100, 0, 50 ); + for ( i = 0; i < 100; i++ ) { - a = roundf( randu() * 50 ); - b = roundf( randu() * 50 ); - v = lcmf( a, b ); - console.log( 'lcmf(%d,%d) = %d', a, b, v ); + console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); } ``` diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js index 762dd5382e7d..d092fc3b15ae 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js @@ -18,18 +18,16 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var roundf = require( '@stdlib/math/base/special/roundf' ); +var randu = require( '@stdlib/random/array/discrete-uniform' ); var lcmf = require( './../lib' ); var a; var b; -var v; var i; +a = randu( 100, 0, 50 ); +b = randu( 100, 0, 50 ); + for ( i = 0; i < 100; i++ ) { - a = roundf( randu() * 50 ); - b = roundf( randu() * 50 ); - v = lcmf( a, b ); - console.log( 'lcmf(%d,%d) = %d', a, b, v ); + console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); } From d75defcc18aad49b5273489446635e0f8e3809b8 Mon Sep 17 00:00:00 2001 From: GUNJ JOSHI Date: Tue, 3 Dec 2024 23:20:48 +0530 Subject: [PATCH 2/3] docs: simplify example --- lib/node_modules/@stdlib/math/base/special/lcmf/README.md | 7 ++----- .../@stdlib/math/base/special/lcmf/examples/index.js | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md index 8783a4a21577..452ea60a209f 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md @@ -104,13 +104,10 @@ v = lcmf( 48, NaN ); var randu = require( '@stdlib/random/array/discrete-uniform' ); var lcmf = require( '@stdlib/math/base/special/lcmf' ); -var a; -var b; +var a = randu( 100, 0, 50 ); +var b = randu( 100, 0, 50 ); var i; -a = randu( 100, 0, 50 ); -b = randu( 100, 0, 50 ); - for ( i = 0; i < 100; i++ ) { console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); } diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js index d092fc3b15ae..d078d781a7d3 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js @@ -21,13 +21,10 @@ var randu = require( '@stdlib/random/array/discrete-uniform' ); var lcmf = require( './../lib' ); -var a; -var b; +var a = randu( 100, 0, 50 ); +var b = randu( 100, 0, 50 ); var i; -a = randu( 100, 0, 50 ); -b = randu( 100, 0, 50 ); - for ( i = 0; i < 100; i++ ) { console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); } From b75aa798e8520d8b9a82013278b85b5409720265 Mon Sep 17 00:00:00 2001 From: Athan Date: Tue, 3 Dec 2024 14:04:55 -0800 Subject: [PATCH 3/3] Apply suggestions from code review Signed-off-by: Athan --- lib/node_modules/@stdlib/math/base/special/lcmf/README.md | 2 +- .../@stdlib/math/base/special/lcmf/examples/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md index 452ea60a209f..516e540bb345 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/README.md +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/README.md @@ -106,8 +106,8 @@ var lcmf = require( '@stdlib/math/base/special/lcmf' ); var a = randu( 100, 0, 50 ); var b = randu( 100, 0, 50 ); -var i; +var i; for ( i = 0; i < 100; i++ ) { console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); } diff --git a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js index d078d781a7d3..42f023a6008b 100644 --- a/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/lcmf/examples/index.js @@ -23,8 +23,8 @@ var lcmf = require( './../lib' ); var a = randu( 100, 0, 50 ); var b = randu( 100, 0, 50 ); -var i; +var i; for ( i = 0; i < 100; i++ ) { console.log( 'lcmf(%d,%d) = %d', a[ i ], b[ i ], lcmf( a[ i ], b[ i ] ) ); }