From 50fe193e61cc951c3e3a46cec3c5fd3a9445cd8e Mon Sep 17 00:00:00 2001
From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Date: Tue, 10 Dec 2024 15:40:33 +0000
Subject: [PATCH 1/6] feat: add C ndarray API and refactor
---
.../@stdlib/blas/ext/base/dssumors/README.md | 141 ++++++++++++++++--
.../ext/base/dssumors/benchmark/benchmark.js | 9 +-
.../dssumors/benchmark/benchmark.native.js | 9 +-
.../dssumors/benchmark/benchmark.ndarray.js | 9 +-
.../benchmark/benchmark.ndarray.native.js | 9 +-
.../dssumors/benchmark/c/benchmark.length.c | 50 ++++++-
.../blas/ext/base/dssumors/docs/repl.txt | 22 +--
.../ext/base/dssumors/docs/types/index.d.ts | 8 +-
.../ext/base/dssumors/examples/c/example.c | 9 +-
.../blas/ext/base/dssumors/examples/index.js | 7 +-
.../include/stdlib/blas/ext/base/dssumors.h | 9 +-
.../blas/ext/base/dssumors/lib/dssumors.js | 52 +------
.../ext/base/dssumors/lib/dssumors.native.js | 8 +-
.../blas/ext/base/dssumors/lib/index.js | 2 +-
.../blas/ext/base/dssumors/lib/ndarray.js | 18 +--
.../ext/base/dssumors/lib/ndarray.native.js | 18 +--
.../blas/ext/base/dssumors/manifest.json | 33 ++--
.../blas/ext/base/dssumors/src/addon.c | 29 +++-
.../base/dssumors/src/{dssumors.c => main.c} | 39 ++---
.../ext/base/dssumors/test/test.dssumors.js | 4 +-
.../dssumors/test/test.dssumors.native.js | 4 +-
.../ext/base/dssumors/test/test.ndarray.js | 4 +-
.../base/dssumors/test/test.ndarray.native.js | 4 +-
23 files changed, 322 insertions(+), 175 deletions(-)
rename lib/node_modules/@stdlib/blas/ext/base/dssumors/src/{dssumors.c => main.c} (65%)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
index c3e6c3eaa174..91ae46ec8d3e 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
@@ -36,7 +36,7 @@ limitations under the License.
var dssumors = require( '@stdlib/blas/ext/base/dssumors' );
```
-#### dssumors( N, x, stride )
+#### dssumors( N, x, strideX )
Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
@@ -45,7 +45,7 @@ var Float32Array = require( '@stdlib/array/float32' );
var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
-var v = dssumors( 3, x, 1 );
+var v = dssumors( x.length, x, 1 );
// returns 1.0
```
@@ -53,9 +53,9 @@ The function has the following parameters:
- **N**: number of indexed elements.
- **x**: input [`Float32Array`][@stdlib/array/float32].
-- **stride**: index increment for `x`.
+- **strideX**: stride length for `x`.
-The `N` and `stride` parameters determine which elements in the strided arrays are accessed at runtime. For example, to compute the sum of every other element in `x`,
+The `N` and stride parameters determine which elements in the strided arrays are accessed at runtime. For example, to compute the sum of every other element:
```javascript
var Float32Array = require( '@stdlib/array/float32' );
@@ -80,7 +80,7 @@ var v = dssumors( 4, x1, 2 );
// returns 5.0
```
-#### dssumors.ndarray( N, x, stride, offset )
+#### dssumors.ndarray( N, x, strideX, offsetX )
Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
@@ -89,15 +89,15 @@ var Float32Array = require( '@stdlib/array/float32' );
var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
-var v = dssumors.ndarray( 3, x, 1, 0 );
+var v = dssumors.ndarray( x.length, x, 1, 0 );
// returns 1.0
```
The function has the following additional parameters:
-- **offset**: starting index for `x`.
+- **offsetX**: starting index for `x`.
-While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other value in `x` starting from the second value
+While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other element starting from the second element:
```javascript
var Float32Array = require( '@stdlib/array/float32' );
@@ -130,12 +130,12 @@ var v = dssumors.ndarray( 4, x, 2, 1 );
```javascript
-var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
-var Float32Array = require( '@stdlib/array/float32' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
var dssumors = require( '@stdlib/blas/ext/base/dssumors' );
-var x = filledarrayBy( 10, 'float64', discreteUniform( 0, 100 ) );
+var x = discreteUniform( 10.0, -100, 100, {
+ 'dtype': 'float32'
+});
console.log( x );
var v = dssumors( x.length, x, 1 );
@@ -146,6 +146,123 @@ console.log( v );
+
+
+* * *
+
+
+
+## C APIs
+
+
+
+
+
+
+
+
+
+
+
+### Usage
+
+```c
+#include "stdlib/blas/ext/base/dssumors.h"
+```
+
+#### stdlib_strided_dssumors( N, \*X, strideX )
+
+Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
+
+```c
+const float x[] = { 1.0f, -2.0f, 0.0f/0.0f, 2.0f };
+
+double v = stdlib_strided_dssumors( 4, x, 1 );
+// returns 1.0
+```
+
+The function accepts the following arguments:
+
+- **N**: `[in] CBLAS_INT` number of indexed elements.
+- **X**: `[in] float*` input array.
+- **strideX**: `[in] CBLAS_INT` stride length for `X`.
+
+```c
+double stdlib_strided_dssumors( const CBLAS_INT N, const float *X, const CBLAS_INT strideX );
+```
+
+#### stdlib_strided_dssumors_ndarray( N, \*X, strideX, offsetX )
+
+Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
+
+```c
+const float x[] = { 1.0f, -2.0f, 0.0f/0.0f, 2.0f };
+
+double v = stdlib_strided_dssumors_ndarray( 4, x, 1, 0 );
+// returns 1.0
+```
+
+The function accepts the following arguments:
+
+- **N**: `[in] CBLAS_INT` number of indexed elements.
+- **X**: `[in] float*` input array.
+- **strideX**: `[in] CBLAS_INT` stride length for `X`.
+- **offsetX**: `[in] CBLAS_INT` starting index for `X`.
+
+```c
+double stdlib_strided_dssumors_ndarray( const CBLAS_INT N, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX );
+```
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+### Examples
+
+```c
+#include "stdlib/blas/ext/base/dssumors.h"
+#include
+
+int main( void ) {
+ // Create a strided array:
+ const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f };
+
+ // Specify the number of elements:
+ const int N = 5;
+
+ // Specify the stride length:
+ const int strideX = 2;
+
+ // Compute the sum:
+ double v = stdlib_strided_dsnansumors( N, x, strideX );
+
+ // Print the result:
+ printf( "sum: %lf\n", v );
+}
+```
+
+
+
+
+
+
+
+
+
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.js
index 520fa8bf31c1..8e975af60614 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.js
@@ -21,8 +21,7 @@
// MODULES //
var bench = require( '@stdlib/bench' );
-var uniform = require( '@stdlib/random/base/uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
+var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
@@ -31,7 +30,9 @@ var dssumors = require( './../lib/dssumors.js' );
// VARIABLES //
-var rand = uniform( -10.0, 10.0 );
+var options = {
+ 'dtype': 'float32'
+};
// FUNCTIONS //
@@ -44,7 +45,7 @@ var rand = uniform( -10.0, 10.0 );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
- var x = filledarrayBy( len, 'float32', rand );
+ var x = uniform( len, -100, 100, options );
return benchmark;
function benchmark( b ) {
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.native.js
index 6daf33620753..6692931e774b 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.native.js
@@ -22,8 +22,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
-var uniform = require( '@stdlib/random/base/uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
+var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -36,7 +35,9 @@ var dssumors = tryRequire( resolve( __dirname, './../lib/dssumors.native.js' ) )
var opts = {
'skip': ( dssumors instanceof Error )
};
-var rand = uniform( -10.0, 10.0 );
+var options = {
+ 'dtype': 'float32'
+};
// FUNCTIONS //
@@ -49,7 +50,7 @@ var rand = uniform( -10.0, 10.0 );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
- var x = filledarrayBy( len, 'float32', rand );
+ var x = uniform( len, -100, 100, options );
return benchmark;
function benchmark( b ) {
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.js
index 464360b22c80..20e5396cb1e3 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.js
@@ -21,8 +21,7 @@
// MODULES //
var bench = require( '@stdlib/bench' );
-var uniform = require( '@stdlib/random/base/uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
+var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
@@ -31,7 +30,9 @@ var dssumors = require( './../lib/ndarray.js' );
// VARIABLES //
-var rand = uniform( -10.0, 10.0 );
+var options = {
+ 'dtype': 'float32'
+};
// FUNCTIONS //
@@ -44,7 +45,7 @@ var rand = uniform( -10.0, 10.0 );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
- var x = filledarrayBy( len, 'float32', rand );
+ var x = uniform( len, -100, 100, options );
return benchmark;
function benchmark( b ) {
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.native.js
index b1207c8f2589..ca3f70799174 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/benchmark.ndarray.native.js
@@ -22,8 +22,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
-var uniform = require( '@stdlib/random/base/uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
+var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -36,7 +35,9 @@ var dssumors = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) );
var opts = {
'skip': ( dssumors instanceof Error )
};
-var rand = uniform( -10.0, 10.0 );
+var options = {
+ 'dtype': 'float32'
+};
// FUNCTIONS //
@@ -49,7 +50,7 @@ var rand = uniform( -10.0, 10.0 );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
- var x = filledarrayBy( len, 'float32', rand );
+ var x = uniform( len, -100, 100, options );
return benchmark;
function benchmark( b ) {
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/c/benchmark.length.c
index e0a7213cb89b..e291ffe96e6d 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/c/benchmark.length.c
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/benchmark/c/benchmark.length.c
@@ -94,7 +94,7 @@ static float rand_float( void ) {
* @param len array length
* @return elapsed time in seconds
*/
-static double benchmark( int iterations, int len ) {
+static double benchmark1( int iterations, int len ) {
double elapsed;
float x[ len ];
double v;
@@ -107,6 +107,7 @@ static double benchmark( int iterations, int len ) {
v = 0.0;
t = tic();
for ( i = 0; i < iterations; i++ ) {
+ // cppcheck-suppress uninitvar
v = stdlib_strided_dssumors( len, x, 1 );
if ( v != v ) {
printf( "should not return NaN\n" );
@@ -120,6 +121,40 @@ static double benchmark( int iterations, int len ) {
return elapsed;
}
+/**
+* Runs a benchmark.
+*
+* @param iterations number of iterations
+* @param len array length
+* @return elapsed time in seconds
+*/
+static double benchmark2( int iterations, int len ) {
+ double elapsed;
+ float x[ len ];
+ double v;
+ double t;
+ int i;
+
+ for ( i = 0; i < len; i++ ) {
+ x[ i ] = ( rand_float()*20000.0f ) - 10000.0f;
+ }
+ v = 0.0;
+ t = tic();
+ for ( i = 0; i < iterations; i++ ) {
+ // cppcheck-suppress uninitvar
+ v = stdlib_strided_dssumors_ndarray( len, x, 1, 0 );
+ if ( v != v ) {
+ printf( "should not return NaN\n" );
+ break;
+ }
+ }
+ elapsed = tic() - t;
+ if ( v != v ) {
+ printf( "should not return NaN\n" );
+ }
+ return elapsed;
+}
+
/**
* Main execution sequence.
*/
@@ -142,7 +177,18 @@ int main( void ) {
for ( j = 0; j < REPEATS; j++ ) {
count += 1;
printf( "# c::%s:len=%d\n", NAME, len );
- elapsed = benchmark( iter, len );
+ elapsed = benchmark1( iter, len );
+ print_results( iter, elapsed );
+ printf( "ok %d benchmark finished\n", count );
+ }
+ }
+ for ( i = MIN; i <= MAX; i++ ) {
+ len = pow( 10, i );
+ iter = ITERATIONS / pow( 10, i-1 );
+ for ( j = 0; j < REPEATS; j++ ) {
+ count += 1;
+ printf( "# c::%s:ndarray:len=%d\n", NAME, len );
+ elapsed = benchmark2( iter, len );
print_results( iter, elapsed );
printf( "ok %d benchmark finished\n", count );
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/repl.txt b/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/repl.txt
index 24e95edf572b..3b9eb9a8f1ef 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/repl.txt
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/repl.txt
@@ -1,11 +1,11 @@
-{{alias}}( N, x, stride )
+{{alias}}( N, x, strideX )
Computes the sum of single-precision floating-point strided array elements
using ordinary recursive summation with extended accumulation and returning
an extended precision result.
- The `N` and `stride` parameters determine which elements in the strided
- array are accessed at runtime.
+ The `N` and stride parameters determine which elements in the strided array
+ are accessed at runtime.
Indexing is relative to the first index. To introduce an offset, use a typed
array view.
@@ -20,8 +20,8 @@
x: Float32Array
Input array.
- stride: integer
- Index increment.
+ strideX: integer
+ Stride length.
Returns
-------
@@ -35,7 +35,7 @@
> {{alias}}( x.length, x, 1 )
1.0
- // Using `N` and `stride` parameters:
+ // Using `N` and stride parameters:
> x = new {{alias:@stdlib/array/float32}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] );
> {{alias}}( 3, x, 2 )
1.0
@@ -47,13 +47,13 @@
-1.0
-{{alias}}.ndarray( N, x, stride, offset )
+{{alias}}.ndarray( N, x, strideX, offsetX )
Computes the sum of single-precision floating-point strided array elements
using ordinary recursive summation with extended accumulation and
alternative indexing semantics and returning an extended precision result.
While typed array views mandate a view offset based on the underlying
- buffer, the `offset` parameter supports indexing semantics based on a
+ buffer, the offset parameter supports indexing semantics based on a
starting index.
Parameters
@@ -64,10 +64,10 @@
x: Float32Array
Input array.
- stride: integer
- Index increment.
+ strideX: integer
+ Stride length.
- offset: integer
+ offsetX: integer
Starting index.
Returns
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/types/index.d.ts
index dbc88cc0ba5e..cd5c2ea3579e 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/types/index.d.ts
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/docs/types/index.d.ts
@@ -27,7 +27,7 @@ interface Routine {
*
* @param N - number of indexed elements
* @param x - input array
- * @param stride - stride length
+ * @param strideX - stride length
* @returns sum
*
* @example
@@ -45,8 +45,8 @@ interface Routine {
*
* @param N - number of indexed elements
* @param x - input array
- * @param stride - stride length
- * @param offset - starting index
+ * @param strideX - stride length
+ * @param offsetX - starting index
* @returns sum
*
* @example
@@ -65,7 +65,7 @@ interface Routine {
*
* @param N - number of indexed elements
* @param x - input array
-* @param stride - stride length
+* @param strideX - stride length
* @returns sum
*
* @example
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/c/example.c b/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/c/example.c
index 0ed0e0edaecc..e22d3e75895b 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/c/example.c
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/c/example.c
@@ -17,21 +17,20 @@
*/
#include "stdlib/blas/ext/base/dssumors.h"
-#include
#include
int main( void ) {
// Create a strided array:
- const float x[] = { 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0 };
+ const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f };
// Specify the number of elements:
- const int64_t N = 4;
+ const int N = 5;
// Specify the stride length:
- const int64_t stride = 2;
+ const int strideX = 2;
// Compute the sum:
- double v = stdlib_strided_dssumors( N, x, stride );
+ double v = stdlib_strided_dssumors( N, x, strideX );
// Print the result:
printf( "sum: %lf\n", v );
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/index.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/index.js
index bb2d8563ac6f..0fc3617838f1 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/index.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/examples/index.js
@@ -18,11 +18,12 @@
'use strict';
-var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
-var filledarrayBy = require( '@stdlib/array/filled-by' );
+var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
var dssumors = require( './../lib' );
-var x = filledarrayBy( 10, 'float32', discreteUniform( 0, 100 ) );
+var x = discreteUniform( 10.0, -100, 100, {
+ 'dtype': 'float32'
+});
console.log( x );
var v = dssumors( x.length, x, 1 );
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h b/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
index 8d2d74adb315..15d45b7e423d 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
@@ -19,7 +19,7 @@
#ifndef STDLIB_BLAS_EXT_BASE_DSSUMORS_H
#define STDLIB_BLAS_EXT_BASE_DSSUMORS_H
-#include
+#include "stdlib/blas/base/shared.h"
/*
* If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler.
@@ -31,7 +31,12 @@ extern "C" {
/**
* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
*/
-double stdlib_strided_dssumors( const int64_t N, const float *X, const int64_t stride );
+double API_SUFFIX(stdlib_strided_dssumors)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX );
+
+/**
+* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
+*/
+double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX );
#ifdef __cplusplus
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.js
index 799706da6a7d..4f53d0bd40e2 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.js
@@ -18,9 +18,10 @@
'use strict';
-// VARIABLES //
+// MODULES //
-var M = 6;
+var stride2offset = require( '@stdlib/strided/base/stride2offset' );
+var ndarray = require( './ndarray.js' );
// MAIN //
@@ -30,7 +31,7 @@ var M = 6;
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float32Array} x - input array
-* @param {integer} stride - stride length
+* @param {integer} strideX - stride length
* @returns {number} sum
*
* @example
@@ -38,50 +39,11 @@ var M = 6;
*
* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
*
-* var v = dssumors( 3, x, 1 );
+* var v = dssumors( x.length, x, 1 );
* // returns 1.0
*/
-function dssumors( N, x, stride ) {
- var sum;
- var ix;
- var m;
- var i;
-
- sum = 0.0;
- if ( N <= 0 ) {
- return sum;
- }
- if ( N === 1 || stride === 0 ) {
- return x[ 0 ];
- }
- // If the stride is equal to `1`, use unrolled loops...
- if ( stride === 1 ) {
- m = N % M;
-
- // If we have a remainder, run a clean-up loop...
- if ( m > 0 ) {
- for ( i = 0; i < m; i++ ) {
- sum += x[ i ];
- }
- }
- if ( N < M ) {
- return sum;
- }
- for ( i = m; i < N; i += M ) {
- sum += x[i] + x[i+1] + x[i+2] + x[i+3] + x[i+4] + x[i+5];
- }
- return sum;
- }
- if ( stride < 0 ) {
- ix = (1-N) * stride;
- } else {
- ix = 0;
- }
- for ( i = 0; i < N; i++ ) {
- sum += x[ ix ];
- ix += stride;
- }
- return sum;
+function dssumors( N, x, strideX ) {
+ return ndarray( N, x, strideX, stride2offset( N, strideX ) );
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.native.js
index 1c6bbd5d94ed..a79bfebb7a19 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/dssumors.native.js
@@ -30,7 +30,7 @@ var addon = require( './../src/addon.node' );
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float32Array} x - input array
-* @param {integer} stride - stride length
+* @param {integer} strideX - stride length
* @returns {number} sum
*
* @example
@@ -38,11 +38,11 @@ var addon = require( './../src/addon.node' );
*
* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
*
-* var v = dssumors( 3, x, 1 );
+* var v = dssumors( x.length, x, 1 );
* // returns 1.0
*/
-function dssumors( N, x, stride ) {
- return addon( N, x, stride );
+function dssumors( N, x, strideX ) {
+ return addon( N, x, strideX );
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/index.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/index.js
index dfdf5a26f05b..326a00d611ec 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/index.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/index.js
@@ -29,7 +29,7 @@
*
* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
*
-* var v = dssumors( 3, x, 1 );
+* var v = dssumors( x.length, x, 1 );
* // returns 1.0
*
* @example
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.js
index d62365d380ff..483ce882ddca 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.js
@@ -30,8 +30,8 @@ var M = 6;
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float32Array} x - input array
-* @param {integer} stride - stride length
-* @param {NonNegativeInteger} offset - starting index
+* @param {integer} strideX - stride length
+* @param {NonNegativeInteger} offsetX - starting index
* @returns {number} sum
*
* @example
@@ -42,7 +42,7 @@ var M = 6;
* var v = dssumors( 4, x, 2, 1 );
* // returns 5.0
*/
-function dssumors( N, x, stride, offset ) {
+function dssumors( N, x, strideX, offsetX ) {
var sum;
var ix;
var m;
@@ -52,20 +52,20 @@ function dssumors( N, x, stride, offset ) {
if ( N <= 0 ) {
return sum;
}
- if ( N === 1 || stride === 0 ) {
- return x[ offset ];
+ ix = offsetX;
+ if ( strideX === 0 ) {
+ return N * x[ ix ];
}
- ix = offset;
// If the stride is equal to `1`, use unrolled loops...
- if ( stride === 1 ) {
+ if ( strideX === 1 ) {
m = N % M;
// If we have a remainder, run a clean-up loop...
if ( m > 0 ) {
for ( i = 0; i < m; i++ ) {
sum += x[ ix ];
- ix += stride;
+ ix += strideX;
}
}
if ( N < M ) {
@@ -79,7 +79,7 @@ function dssumors( N, x, stride, offset ) {
}
for ( i = 0; i < N; i++ ) {
sum += x[ ix ];
- ix += stride;
+ ix += strideX;
}
return sum;
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.native.js
index 0afcebf98aca..dc452d00e4d7 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/lib/ndarray.native.js
@@ -20,9 +20,7 @@
// MODULES //
-var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' );
-var offsetView = require( '@stdlib/strided/base/offset-view' );
-var addon = require( './dssumors.native.js' );
+var addon = require( './../src/addon.node' );
// MAIN //
@@ -32,8 +30,8 @@ var addon = require( './dssumors.native.js' );
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float32Array} x - input array
-* @param {integer} stride - stride length
-* @param {NonNegativeInteger} offset - starting index
+* @param {integer} strideX - stride length
+* @param {NonNegativeInteger} offsetX - starting index
* @returns {number} sum
*
* @example
@@ -44,14 +42,8 @@ var addon = require( './dssumors.native.js' );
* var v = dssumors( 4, x, 2, 1 );
* // returns 5.0
*/
-function dssumors( N, x, stride, offset ) {
- var view;
-
- offset = minViewBufferIndex( N, stride, offset );
-
- view = offsetView( x, offset );
-
- return addon( N, view, stride );
+function dssumors( N, x, strideX, offsetX ) {
+ return addon.ndarray( N, x, strideX, offsetX );
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/manifest.json b/lib/node_modules/@stdlib/blas/ext/base/dssumors/manifest.json
index c30a64af9ec8..ef341b959c42 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/manifest.json
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/manifest.json
@@ -28,49 +28,52 @@
{
"task": "build",
"src": [
- "./src/dssumors.c"
+ "./src/main.c"
],
"include": [
"./include"
],
- "libraries": [
- "-lm"
- ],
+ "libraries": [],
"libpath": [],
"dependencies": [
"@stdlib/napi/export",
"@stdlib/napi/argv",
"@stdlib/napi/argv-int64",
- "@stdlib/napi/argv-strided-float32array"
+ "@stdlib/napi/argv-strided-float32array",
+ "@stdlib/strided/base/stride2offset",
+ "@stdlib/blas/base/shared",
+ "@stdlib/napi/create-double"
]
},
{
"task": "benchmark",
"src": [
- "./src/dssumors.c"
+ "./src/main.c"
],
"include": [
"./include"
],
- "libraries": [
- "-lm"
- ],
+ "libraries": [],
"libpath": [],
- "dependencies": []
+ "dependencies": [
+ "@stdlib/strided/base/stride2offset",
+ "@stdlib/blas/base/shared"
+ ]
},
{
"task": "examples",
"src": [
- "./src/dssumors.c"
+ "./src/main.c"
],
"include": [
"./include"
],
- "libraries": [
- "-lm"
- ],
+ "libraries": [],
"libpath": [],
- "dependencies": []
+ "dependencies": [
+ "@stdlib/strided/base/stride2offset",
+ "@stdlib/blas/base/shared"
+ ]
}
]
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/addon.c
index 8d09785caa3b..64162e8e38f6 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/addon.c
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/addon.c
@@ -17,12 +17,13 @@
*/
#include "stdlib/blas/ext/base/dssumors.h"
+#include "stdlib/blas/base/shared.h"
#include "stdlib/napi/export.h"
#include "stdlib/napi/argv.h"
#include "stdlib/napi/argv_int64.h"
#include "stdlib/napi/argv_strided_float32array.h"
+#include "stdlib/napi/create_double.h"
#include
-#include
/**
* Receives JavaScript callback invocation data.
@@ -34,13 +35,27 @@
static napi_value addon( napi_env env, napi_callback_info info ) {
STDLIB_NAPI_ARGV( env, info, argv, argc, 3 );
STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
- STDLIB_NAPI_ARGV_INT64( env, stride, argv, 2 );
- STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, stride, argv, 1 );
+ STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
+ STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 );
+ STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_dssumors)( N, X, strideX ), v );
+ return v;
+}
- napi_value v;
- napi_status status = napi_create_double( env, stdlib_strided_dssumors( N, X, stride ), &v );
- assert( status == napi_ok );
+/**
+* Receives JavaScript callback invocation data.
+*
+* @param env environment under which the function is invoked
+* @param info callback data
+* @return Node-API value
+*/
+static napi_value addon_method( napi_env env, napi_callback_info info ) {
+ STDLIB_NAPI_ARGV( env, info, argv, argc, 4 );
+ STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
+ STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
+ STDLIB_NAPI_ARGV_INT64( env, offsetX, argv, 3 );
+ STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 );
+ STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_dssumors_ndarray)( N, X, strideX, offsetX ), v );
return v;
}
-STDLIB_NAPI_MODULE_EXPORT_FCN( addon )
+STDLIB_NAPI_MODULE_EXPORT_FCN_WITH_METHOD( addon, "ndarray", addon_method )
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/dssumors.c b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
similarity index 65%
rename from lib/node_modules/@stdlib/blas/ext/base/dssumors/src/dssumors.c
rename to lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
index f2d75d6cfe9d..fe5077fd6e38 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/dssumors.c
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
@@ -17,31 +17,38 @@
*/
#include "stdlib/blas/ext/base/dssumors.h"
-#include
+#include "stdlib/blas/base/shared.h"
+#include "stdlib/strided/base/stride2offset.h"
/**
* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
*
-* @param N number of indexed elements
-* @param X input array
-* @param stride stride length
-* @return output value
+* @param N number of indexed elements
+* @param X input array
+* @param strideX stride length
+* @return output value
*/
-double stdlib_strided_dssumors( const int64_t N, const float *X, const int64_t stride ) {
+double API_SUFFIX(stdlib_strided_dssumors)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX ) {
+ CBLAS_INT ox = stdlib_strided_stride2offset( N, strideX );
+ return API_SUFFIX(stdlib_strided_dssumors_ndarray)( N, X, strideX, ox );
+}
+
+double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) {
+ CBLAS_INT ix;
+ CBLAS_INT m;
+ CBLAS_INT i;
double sum;
- int64_t ix;
- int64_t m;
- int64_t i;
sum = 0.0;
if ( N <= 0 ) {
return sum;
}
- if ( N == 1 || stride == 0 ) {
- return X[ 0 ];
+ ix = offsetX;
+ if ( strideX == 0 ) {
+ return N * X[ ix ];
}
// If the stride is equal to `1`, use unrolled loops...
- if ( stride == 1 ) {
+ if ( strideX == 1 ) {
m = N % 6;
// If we have a remainder, run a clean-up loop...
@@ -58,14 +65,10 @@ double stdlib_strided_dssumors( const int64_t N, const float *X, const int64_t s
}
return sum;
}
- if ( stride < 0 ) {
- ix = (1-N) * stride;
- } else {
- ix = 0;
- }
+
for ( i = 0; i < N; i++ ) {
sum += (double)X[ ix ];
- ix += stride;
+ ix += strideX;
}
return sum;
}
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.js
index 27074224af8e..a7bb577e8ac8 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.js
@@ -143,14 +143,14 @@ tape( 'the function supports a negative `stride` parameter', function test( t )
t.end();
});
-tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element', function test( t ) {
+tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of first element repeated N times', function test( t ) {
var x;
var v;
x = new Float32Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] );
v = dssumors( x.length, x, 0 );
- t.strictEqual( v, 1.0, 'returns expected value' );
+ t.strictEqual( v, 5.0, 'returns expected value' );
t.end();
});
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.native.js
index 7cc6cea70b15..426b6425812f 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.dssumors.native.js
@@ -234,14 +234,14 @@ tape( 'the function supports a negative `stride` parameter', opts, function test
t.end();
});
-tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element', opts, function test( t ) {
+tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of first element repeated N times', opts, function test( t ) {
var x;
var v;
x = new Float32Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] );
v = dssumors( x.length, x, 0 );
- t.strictEqual( v, 1.0, 'returns expected value' );
+ t.strictEqual( v, 5.0, 'returns expected value' );
t.end();
});
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.js
index 86918efe5045..83391f073a26 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.js
@@ -143,14 +143,14 @@ tape( 'the function supports a negative `stride` parameter', function test( t )
t.end();
});
-tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element', function test( t ) {
+tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of first element repeated N times', function test( t ) {
var x;
var v;
x = new Float32Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] );
v = dssumors( x.length, x, 0, 0 );
- t.strictEqual( v, 1.0, 'returns expected value' );
+ t.strictEqual( v, 5.0, 'returns expected value' );
t.end();
});
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.native.js b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.native.js
index cd8a1d5d9a3a..26f738c9c234 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.native.js
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/test/test.ndarray.native.js
@@ -152,14 +152,14 @@ tape( 'the function supports a negative `stride` parameter', opts, function test
t.end();
});
-tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element', opts, function test( t ) {
+tape( 'if provided a `stride` parameter equal to `0`, the function returns the sum of first element repeated N times', opts, function test( t ) {
var x;
var v;
x = new Float32Array( [ 1.0, -2.0, -4.0, 5.0, 3.0 ] );
v = dssumors( x.length, x, 0, 0 );
- t.strictEqual( v, 1.0, 'returns expected value' );
+ t.strictEqual( v, 5.0, 'returns expected value' );
t.end();
});
From d72cefd9c266f22582d323beb5fbae8e06a95def Mon Sep 17 00:00:00 2001
From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Date: Tue, 10 Dec 2024 21:14:24 +0500
Subject: [PATCH 2/6] docs: apply review suggestion
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
---
lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
index 91ae46ec8d3e..d0dabd20e8cf 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
@@ -177,7 +177,7 @@ console.log( v );
Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
```c
-const float x[] = { 1.0f, -2.0f, 0.0f/0.0f, 2.0f };
+const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f };
double v = stdlib_strided_dssumors( 4, x, 1 );
// returns 1.0
From 05bdd2b77b0a75222e9a9bfb006ed2a830162dc8 Mon Sep 17 00:00:00 2001
From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Date: Tue, 10 Dec 2024 21:14:35 +0500
Subject: [PATCH 3/6] docs: apply review suggestion
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
---
lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
index d0dabd20e8cf..4f0493a22a3c 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
@@ -198,7 +198,7 @@ double stdlib_strided_dssumors( const CBLAS_INT N, const float *X, const CBLAS_I
Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
```c
-const float x[] = { 1.0f, -2.0f, 0.0f/0.0f, 2.0f };
+const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f };
double v = stdlib_strided_dssumors_ndarray( 4, x, 1, 0 );
// returns 1.0
From b6474a04783d3a91d537f59db477f5a6b488fe42 Mon Sep 17 00:00:00 2001
From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Date: Tue, 10 Dec 2024 16:18:09 +0000
Subject: [PATCH 4/6] docs: apply review suggestion
---
.../@stdlib/blas/ext/base/dssumors/src/main.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
index fe5077fd6e38..b6d8957ad635 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/src/main.c
@@ -33,6 +33,15 @@ double API_SUFFIX(stdlib_strided_dssumors)( const CBLAS_INT N, const float *X, c
return API_SUFFIX(stdlib_strided_dssumors_ndarray)( N, X, strideX, ox );
}
+/**
+* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
+*
+* @param N number of indexed elements
+* @param X input array
+* @param strideX stride length
+* @param offsetX starting index
+* @return output value
+*/
double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) {
CBLAS_INT ix;
CBLAS_INT m;
From eebb2ef2ef357e798483b6d8b092c6970a850da3 Mon Sep 17 00:00:00 2001
From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Date: Thu, 12 Dec 2024 12:42:17 +0500
Subject: [PATCH 5/6] docs: apply review suggestion
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
---
lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
index 4f0493a22a3c..78ff1c8822d0 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
@@ -248,7 +248,7 @@ int main( void ) {
const int strideX = 2;
// Compute the sum:
- double v = stdlib_strided_dsnansumors( N, x, strideX );
+ double v = stdlib_strided_dssumors( N, x, strideX );
// Print the result:
printf( "sum: %lf\n", v );
From d56a12b464bf8c30a06785125e705b2e4a0a22ec Mon Sep 17 00:00:00 2001
From: Athan
Date: Thu, 12 Dec 2024 19:01:36 -0800
Subject: [PATCH 6/6] Apply suggestions from code review
Signed-off-by: Athan
---
lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md | 4 ++--
.../ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
index 78ff1c8822d0..8f458633deba 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/README.md
@@ -180,7 +180,7 @@ Computes the sum of single-precision floating-point strided array elements using
const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f };
double v = stdlib_strided_dssumors( 4, x, 1 );
-// returns 1.0
+// returns 10.0
```
The function accepts the following arguments:
@@ -201,7 +201,7 @@ Computes the sum of single-precision floating-point strided array elements using
const float x[] = { 1.0f, 2.0f, 3.0f, 4.0f };
double v = stdlib_strided_dssumors_ndarray( 4, x, 1, 0 );
-// returns 1.0
+// returns 10.0
```
The function accepts the following arguments:
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h b/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
index 15d45b7e423d..5e25ca59cd64 100644
--- a/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
+++ b/lib/node_modules/@stdlib/blas/ext/base/dssumors/include/stdlib/blas/ext/base/dssumors.h
@@ -29,12 +29,12 @@ extern "C" {
#endif
/**
-* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
+* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and returning an extended precision result.
*/
double API_SUFFIX(stdlib_strided_dssumors)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX );
/**
-* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
+* Computes the sum of single-precision floating-point strided array elements using ordinary recursive summation with extended accumulation and alternative indexing semantics and returning an extended precision result.
*/
double API_SUFFIX(stdlib_strided_dssumors_ndarray)( const CBLAS_INT N, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX );