From 0fcfeab42b2c354acfd6dc68b7d6146c4ddae5da Mon Sep 17 00:00:00 2001 From: DhruvArvindSingh Date: Thu, 2 Jan 2025 09:28:33 +0000 Subject: [PATCH 1/4] feat: add C implementation for math/base/special/rising-factorial --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../base/special/rising-factorial/README.md | 90 +++++++++- .../rising-factorial/benchmark/benchmark.js | 11 +- .../benchmark/benchmark.native.js | 64 +++++++ .../benchmark/c/native/Makefile | 146 +++++++++++++++ .../benchmark/c/native/benchmark.c | 138 ++++++++++++++ .../base/special/rising-factorial/binding.gyp | 170 ++++++++++++++++++ .../rising-factorial/examples/c/Makefile | 146 +++++++++++++++ .../rising-factorial/examples/c/example.c | 33 ++++ .../rising-factorial/examples/index.js | 11 +- .../special/rising-factorial/include.gypi | 53 ++++++ .../math/base/special/rising_factorial.h | 40 +++++ .../special/rising-factorial/lib/native.js | 85 +++++++++ .../special/rising-factorial/manifest.json | 81 +++++++++ .../special/rising-factorial/package.json | 3 + .../special/rising-factorial/src/Makefile | 70 ++++++++ .../base/special/rising-factorial/src/addon.c | 23 +++ .../base/special/rising-factorial/src/main.c | 114 ++++++++++++ .../special/rising-factorial/test/test.js | 24 +-- .../rising-factorial/test/test.native.js | 105 +++++++++++ 19 files changed, 1375 insertions(+), 32 deletions(-) create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/binding.gyp create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/include.gypi create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/include/stdlib/math/base/special/rising_factorial.h create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/src/Makefile create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c create mode 100644 lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md index e81e183c5f93..c3af32d4cd60 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md @@ -20,7 +20,7 @@ limitations under the License. # Rising Factorial -> Compute the [rising factorial][falling-and-rising-factorials]. +> Compute the [rising factorial][rising-and-rising-factorials].
@@ -38,7 +38,7 @@ var risingFactorial = require( '@stdlib/math/base/special/rising-factorial' ); #### risingFactorial( x, n ) -Evaluates the [rising factorial][falling-and-rising-factorials] of `x` and `n`. +Evaluates the [rising factorial][rising-and-rising-factorials] of `x` and `n`. ```javascript var v = risingFactorial( 0.9, 5 ); @@ -100,6 +100,86 @@ for ( i = 0; i < 100; i++ ) { + + +* * * + +
+ +## C APIs + + + +
+ +
+ + + + + +
+ +### Usage + +```c +#include "stdlib/math/base/special/rising_factorial.h" +``` + +#### stdlib_base_rising_factorial( x, n ) + +Evaluates the rising factorial of `x` and `n`. + +```c +double out = stdlib_base_rising_factorial( 0.9, 5 ); +// returns ~94.766 + +out = stdlib_base_rising_factorial( -9.0, 3 ); +// returns -504.0 +``` + +The function accepts the following arguments: + +- **x**: `[in] double` first function parameter. +- **n**: `[in] int32_t` second function parameter. + +```c +double stdlib_base_rising_factorial( const double x, const int32_t n ); +``` + +
+ + +
+
+ + +
+### Examples +```c +#include "stdlib/math/base/special/rising_factorial.h" +#include +#include +int main( void ) { + const double x[] = { -10.0, -7.78, -5.56, -3.33, -1.11, 1.11, 3.33, 5.56, 7.78, 10.0 }; + const int32_t n[] = { 5, 4, 3, 2, 1, 0, -1, -2, -3, -4 }; + double v; + int i; + for ( i = 0; i < 10; i++ ) { + v = stdlib_base_rising_factorial( x[ i ], n[ i ] ); + printf( "x: %lf, n: %d, rising_factorial(x,n): %lf\n", x[ i ], n[ i ], v ); + } +} +``` + +
+ + + +
+ + +
@@ -108,7 +188,7 @@ for ( i = 0; i < 100; i++ ) { ## See Also -- [`@stdlib/math/base/special/falling-factorial`][@stdlib/math/base/special/falling-factorial]: compute the falling factorial. +- [`@stdlib/math/base/special/rising-factorial`][@stdlib/math/base/special/rising-factorial]: compute the rising factorial.
@@ -118,11 +198,11 @@ for ( i = 0; i < 100; i++ ) {
-[falling-and-rising-factorials]: https://en.wikipedia.org/wiki/Falling_and_rising_factorials +[rising-and-rising-factorials]: https://en.wikipedia.org/wiki/rising_and_rising_factorials -[@stdlib/math/base/special/falling-factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/falling-factorial +[@stdlib/math/base/special/rising-factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/rising-factorial diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.js index 099e2d38b2cb..237f504041ea 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.js @@ -21,8 +21,8 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); +var randu = require( '@stdlib/random/array/uniform' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pkg = require( './../package.json' ).name; var risingFactorial = require( './../lib' ); @@ -36,11 +36,12 @@ bench( pkg, function benchmark( b ) { var y; var i; + x = randu( 100, 1.0, 41.0 ); + n = discreteUniform( 100, 0, 40 ); + b.tic(); for ( i = 0; i < b.iterations; i++ ) { - x = ( randu()*100.0 ) - 50.0; - n = round( ( randu()*100.0 ) - 50.0 ); - y = risingFactorial( x, n ); + y = risingFactorial( x[ i % x.length ], n[ i % n.length ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js new file mode 100644 index 000000000000..e7e26bec2fb2 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js @@ -0,0 +1,64 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var resolve = require( 'path' ).resolve; +var bench = require( '@stdlib/bench' ); +var randu = require( '@stdlib/random/array/uniform' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var tryRequire = require( '@stdlib/utils/try-require' ); +var pkg = require( './../package.json' ).name; + + +// VARIABLES // + +var risingFactorial = tryRequire( resolve( __dirname, './../lib/native.js' ) ); +var opts = { + 'skip': ( risingFactorial instanceof Error ) +}; + + +// MAIN // + +bench( pkg, opts, function benchmark( b ) { + var x; + var n; + var y; + var i; + + x = randu( 100, 1.0, 41.0 ); + n = discreteUniform( 100, 0, 40 ); + + b.tic(); + for ( i = 0; i < b.iterations; i++ ) { + y = risingFactorial( x[ i % x.length ], n[ i % n.length ] ); + if ( isnan( y ) ) { + b.fail( 'should not return NaN' ); + } + } + b.toc(); + if ( isnan( y ) ) { + b.fail( 'should not return NaN' ); + } + b.pass( 'benchmark finished' ); + b.end(); +}); diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/Makefile b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/Makefile new file mode 100644 index 000000000000..a4bd7b38fd74 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/Makefile @@ -0,0 +1,146 @@ +#/ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#/ + +# VARIABLES # + +ifndef VERBOSE + QUIET := @ +else + QUIET := +endif + +# Determine the OS ([1][1], [2][2]). +# +# [1]: https://en.wikipedia.org/wiki/Uname#Examples +# [2]: http://stackoverflow.com/a/27776822/2225624 +OS ?= $(shell uname) +ifneq (, $(findstring MINGW,$(OS))) + OS := WINNT +else +ifneq (, $(findstring MSYS,$(OS))) + OS := WINNT +else +ifneq (, $(findstring CYGWIN,$(OS))) + OS := WINNT +else +ifneq (, $(findstring Windows_NT,$(OS))) + OS := WINNT +endif +endif +endif +endif + +# Define the program used for compiling C source files: +ifdef C_COMPILER + CC := $(C_COMPILER) +else + CC := gcc +endif + +# Define the command-line options when compiling C files: +CFLAGS ?= \ + -std=c99 \ + -O3 \ + -Wall \ + -pedantic + +# Determine whether to generate position independent code ([1][1], [2][2]). +# +# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options +# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option +ifeq ($(OS), WINNT) + fPIC ?= +else + fPIC ?= -fPIC +endif + +# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): +INCLUDE ?= + +# List of source files: +SOURCE_FILES ?= + +# List of libraries (e.g., `-lopenblas -lpthread`): +LIBRARIES ?= + +# List of library paths (e.g., `-L /foo/bar -L /beep/boop`): +LIBPATH ?= + +# List of C targets: +c_targets := benchmark.out + + +# RULES # + +#/ +# Compiles source files. +# +# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) +# @param {string} [CFLAGS] - C compiler options +# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) +# @param {string} [SOURCE_FILES] - list of source files +# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) +# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) +# +# @example +# make +# +# @example +# make all +#/ +all: $(c_targets) + +.PHONY: all + +#/ +# Compiles C source files. +# +# @private +# @param {string} CC - C compiler (e.g., `gcc`) +# @param {string} CFLAGS - C compiler options +# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) +# @param {string} SOURCE_FILES - list of source files +# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) +# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) +#/ +$(c_targets): %.out: %.c + $(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) + +#/ +# Runs compiled benchmarks. +# +# @example +# make run +#/ +run: $(c_targets) + $(QUIET) ./$< + +.PHONY: run + +#/ +# Removes generated files. +# +# @example +# make clean +#/ +clean: + $(QUIET) -rm -f *.o *.out + +.PHONY: clean diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c new file mode 100644 index 000000000000..d7f8c3b617e8 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c @@ -0,0 +1,138 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/rising_factorial.h" +#include +#include +#include +#include +#include + +#define NAME "rising-factorial" +#define ITERATIONS 100 +#define REPEATS 3 + +/** +* Prints the TAP version. +*/ +static void print_version( void ) { + printf( "TAP version 13\n" ); +} + +/** +* Prints the TAP summary. +* +* @param total total number of tests +* @param passing total number of passing tests +*/ +static void print_summary( int total, int passing ) { + printf( "#\n" ); + printf( "1..%d\n", total ); // TAP plan + printf( "# total %d\n", total ); + printf( "# pass %d\n", passing ); + printf( "#\n" ); + printf( "# ok\n" ); +} + +/** +* Prints benchmarks results. +* +* @param elapsed elapsed time in seconds +*/ +static void print_results( double elapsed ) { + double rate = (double)ITERATIONS / elapsed; + printf( " ---\n" ); + printf( " iterations: %d\n", ITERATIONS ); + printf( " elapsed: %0.9f\n", elapsed ); + printf( " rate: %0.9f\n", rate ); + printf( " ...\n" ); +} + +/** +* Returns a clock time. +* +* @return clock time +*/ +static double tic( void ) { + struct timeval now; + gettimeofday( &now, NULL ); + return (double)now.tv_sec + (double)now.tv_usec/1.0e6; +} + +/** +* Generates a random number on the interval [0,1). +* +* @return random number +*/ +static double rand_double( void ) { + int r = rand(); + return (double)r / ( (double)RAND_MAX + 1.0 ); +} + +/** +* Runs a benchmark. +* +* @return elapsed time in seconds +*/ +static double benchmark( void ) { + int32_t n[ 100 ]; + double x[ 100 ]; + double elapsed; + double t; + double y; + int i; + + for ( i = 0; i < 100; i++ ) { + x[ i ] = ( 40.0 * rand_double() ) + 1.0; + n[ i ] = (int32_t)( 41.0 * rand_double() ); + } + + t = tic(); + for ( i = 0; i < ITERATIONS; i++ ) { + y = stdlib_base_rising_factorial( x[ i % 100 ], n[ i % 100 ] ); + if ( y != y ) { + printf( "should return a nonnegative integer\n" ); + break; + } + } + elapsed = tic() - t; + if ( y != y ) { + printf( "should return a nonnegative integer\n" ); + } + return elapsed; +} + +/** +* Main execution sequence. +*/ +int main( void ) { + double elapsed; + int i; + + // Use the current time to seed the random number generator: + srand( time( NULL ) ); + + print_version(); + for ( i = 0; i < REPEATS; i++ ) { + printf( "# c::native::%s\n", NAME ); + elapsed = benchmark(); + print_results( elapsed ); + printf( "ok %d benchmark finished\n", i+1 ); + } + print_summary( REPEATS, REPEATS ); +} diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/binding.gyp b/lib/node_modules/@stdlib/math/base/special/rising-factorial/binding.gyp new file mode 100644 index 000000000000..68a1ca11d160 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/binding.gyp @@ -0,0 +1,170 @@ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# A `.gyp` file for building a Node.js native add-on. +# +# [1]: https://gyp.gsrc.io/docs/InputFormatReference.md +# [2]: https://gyp.gsrc.io/docs/UserDocumentation.md +{ + # List of files to include in this file: + 'includes': [ + './include.gypi', + ], + + # Define variables to be used throughout the configuration for all targets: + 'variables': { + # Target name should match the add-on export name: + 'addon_target_name%': 'addon', + + # Set variables based on the host OS: + 'conditions': [ + [ + 'OS=="win"', + { + # Define the object file suffix: + 'obj': 'obj', + }, + { + # Define the object file suffix: + 'obj': 'o', + } + ], # end condition (OS=="win") + ], # end conditions + }, # end variables + + # Define compile targets: + 'targets': [ + + # Target to generate an add-on: + { + # The target name should match the add-on export name: + 'target_name': '<(addon_target_name)', + + # Define dependencies: + 'dependencies': [], + + # Define directories which contain relevant include headers: + 'include_dirs': [ + # Local include directory: + '<@(include_dirs)', + ], + + # List of source files: + 'sources': [ + '<@(src_files)', + ], + + # Settings which should be applied when a target's object files are used as linker input: + 'link_settings': { + # Define libraries: + 'libraries': [ + '<@(libraries)', + ], + + # Define library directories: + 'library_dirs': [ + '<@(library_dirs)', + ], + }, + + # C/C++ compiler flags: + 'cflags': [ + # Enable commonly used warning options: + '-Wall', + + # Aggressive optimization: + '-O3', + ], + + # C specific compiler flags: + 'cflags_c': [ + # Specify the C standard to which a program is expected to conform: + '-std=c99', + ], + + # C++ specific compiler flags: + 'cflags_cpp': [ + # Specify the C++ standard to which a program is expected to conform: + '-std=c++11', + ], + + # Linker flags: + 'ldflags': [], + + # Apply conditions based on the host OS: + 'conditions': [ + [ + 'OS=="mac"', + { + # Linker flags: + 'ldflags': [ + '-undefined dynamic_lookup', + '-Wl,-no-pie', + '-Wl,-search_paths_first', + ], + }, + ], # end condition (OS=="mac") + [ + 'OS!="win"', + { + # C/C++ flags: + 'cflags': [ + # Generate platform-independent code: + '-fPIC', + ], + }, + ], # end condition (OS!="win") + ], # end conditions + }, # end target <(addon_target_name) + + # Target to copy a generated add-on to a standard location: + { + 'target_name': 'copy_addon', + + # Declare that the output of this target is not linked: + 'type': 'none', + + # Define dependencies: + 'dependencies': [ + # Require that the add-on be generated before building this target: + '<(addon_target_name)', + ], + + # Define a list of actions: + 'actions': [ + { + 'action_name': 'copy_addon', + 'message': 'Copying addon...', + + # Explicitly list the inputs in the command-line invocation below: + 'inputs': [], + + # Declare the expected outputs: + 'outputs': [ + '<(addon_output_dir)/<(addon_target_name).node', + ], + + # Define the command-line invocation: + 'action': [ + 'cp', + '<(PRODUCT_DIR)/<(addon_target_name).node', + '<(addon_output_dir)/<(addon_target_name).node', + ], + }, + ], # end actions + }, # end target copy_addon + ], # end targets +} diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/Makefile b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/Makefile new file mode 100644 index 000000000000..25ced822f96a --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/Makefile @@ -0,0 +1,146 @@ +#/ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#/ + +# VARIABLES # + +ifndef VERBOSE + QUIET := @ +else + QUIET := +endif + +# Determine the OS ([1][1], [2][2]). +# +# [1]: https://en.wikipedia.org/wiki/Uname#Examples +# [2]: http://stackoverflow.com/a/27776822/2225624 +OS ?= $(shell uname) +ifneq (, $(findstring MINGW,$(OS))) + OS := WINNT +else +ifneq (, $(findstring MSYS,$(OS))) + OS := WINNT +else +ifneq (, $(findstring CYGWIN,$(OS))) + OS := WINNT +else +ifneq (, $(findstring Windows_NT,$(OS))) + OS := WINNT +endif +endif +endif +endif + +# Define the program used for compiling C source files: +ifdef C_COMPILER + CC := $(C_COMPILER) +else + CC := gcc +endif + +# Define the command-line options when compiling C files: +CFLAGS ?= \ + -std=c99 \ + -O3 \ + -Wall \ + -pedantic + +# Determine whether to generate position independent code ([1][1], [2][2]). +# +# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options +# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option +ifeq ($(OS), WINNT) + fPIC ?= +else + fPIC ?= -fPIC +endif + +# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): +INCLUDE ?= + +# List of source files: +SOURCE_FILES ?= + +# List of libraries (e.g., `-lopenblas -lpthread`): +LIBRARIES ?= + +# List of library paths (e.g., `-L /foo/bar -L /beep/boop`): +LIBPATH ?= + +# List of C targets: +c_targets := example.out + + +# RULES # + +#/ +# Compiles source files. +# +# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) +# @param {string} [CFLAGS] - C compiler options +# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) +# @param {string} [SOURCE_FILES] - list of source files +# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) +# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) +# +# @example +# make +# +# @example +# make all +#/ +all: $(c_targets) + +.PHONY: all + +#/ +# Compiles C source files. +# +# @private +# @param {string} CC - C compiler (e.g., `gcc`) +# @param {string} CFLAGS - C compiler options +# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) +# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) +# @param {string} SOURCE_FILES - list of source files +# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) +# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) +#/ +$(c_targets): %.out: %.c + $(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) + +#/ +# Runs compiled examples. +# +# @example +# make run +#/ +run: $(c_targets) + $(QUIET) ./$< + +.PHONY: run + +#/ +# Removes generated files. +# +# @example +# make clean +#/ +clean: + $(QUIET) -rm -f *.o *.out + +.PHONY: clean diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c new file mode 100644 index 000000000000..f17d12a61ac1 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c @@ -0,0 +1,33 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/rising_factorial.h" +#include +#include + +int main( void ) { + const double x[] = { -10.0, -7.78, -5.56, -3.33, -1.11, 1.11, 3.33, 5.56, 7.78, 10.0 }; + const int32_t n[] = { 5, 4, 3, 2, 1, 0, -1, -2, -3, -4 }; + + double v; + int i; + for ( i = 0; i < 10; i++ ) { + v = stdlib_base_rising_factorial( x[ i ], n[ i ] ); + printf( "x: %lf, n: %d, rising_factorial(x,n): %lf\n", x[ i ], n[ i ], v ); + } +} diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js index 7dc4d05bc0d0..c8102a86510d 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js @@ -18,16 +18,17 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var ceil = require( '@stdlib/math/base/special/ceil' ); +var randu = require( '@stdlib/random/array/uniform' ); +var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var risingFactorial = require( './../lib' ); var n; var x; var i; +x = randu( 100, -20.0, 20.0 ); +n = discreteUniform( 100, 0, 20 ); + for ( i = 0; i < 100; i++ ) { - x = ( randu()*40.0 ) - 20.0; - n = ceil( ( randu()*40.0 ) - 20.0 ); - console.log( 'risingFactorial(%d,%d) = %d', x, n, risingFactorial( x, n ) ); + console.log( 'risingFactorial(%d,%d) = %d', x[ i ], n[ i ], risingFactorial( x[ i ], n[ i ] ) ); } diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/include.gypi b/lib/node_modules/@stdlib/math/base/special/rising-factorial/include.gypi new file mode 100644 index 000000000000..ecfaf82a3279 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/include.gypi @@ -0,0 +1,53 @@ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# A GYP include file for building a Node.js native add-on. +# +# Main documentation: +# +# [1]: https://gyp.gsrc.io/docs/InputFormatReference.md +# [2]: https://gyp.gsrc.io/docs/UserDocumentation.md +{ + # Define variables to be used throughout the configuration for all targets: + 'variables': { + # Source directory: + 'src_dir': './src', + + # Include directories: + 'include_dirs': [ + ' + +/* +* If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler. +*/ +#ifdef __cplusplus +extern "C" { +#endif + +/** +* Computes the rising factorial of `x` and `n`. +*/ +double stdlib_base_rising_factorial( const double x, const int32_t n ); + +#ifdef __cplusplus +} +#endif + +#endif // !STDLIB_MATH_BASE_SPECIAL_RISING_FACTORIAL_H diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js new file mode 100644 index 000000000000..3bf6b4c12ec0 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js @@ -0,0 +1,85 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +* +* +* ## Notice +* +* The original C++ code and copyright notice are from the [Boost library]{@link http://www.boost.org/doc/libs/1_64_0/boost/math/special_functions/factorials.hpp}. The implementation has been modified for JavaScript. +* +* ```text +* (C) Copyright John Maddock 2006, 2010. +* +* Use, modification and distribution are subject to the +* Boost Software License, Version 1.0. (See accompanying file +* LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt) +* ``` +*/ + +'use strict'; + +// MODULES // + +var addon = require( './../src/addon.node' ); + + +// MAIN // + +/** +* Computes the rising factorial of `x` and `n`. +* +* ## Notes +* +* - The rising factorial is defined as +* +* ```tex +* \operatorname{risingFactorial}(x, n) = x (x-1) (x-2) (x-3) \ldots (x-n+1) +* ``` +* +* or equivalently +* +* ```tex +* \operatorname{risingFactorial}(x, n) = \frac{ \Gamma(x + n) }{ \Gamma(x) }; +* ``` +* +* @param {number} x - first function parameter +* @param {integer} n - second function parameter +* @returns {number} function value +* +* @example +* var v = risingFactorial( 0.9, 5 ); +* // returns ~94.766 +* +* @example +* var v = risingFactorial( -9.0, 3 ); +* // returns -504.0 +* +* @example +* var v = risingFactorial( 0.0, 2 ); +* // returns 0.0 +* +* @example +* var v = risingFactorial( 3.0, -2 ); +* // returns 0.5 +*/ +function risingFactorial( x, n ) { + return addon( x, n ); +} + + +// EXPORTS // + +module.exports = risingFactorial; diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json b/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json new file mode 100644 index 000000000000..d555b2824ed2 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json @@ -0,0 +1,81 @@ +{ + "options": { + "task": "build" + }, + "fields": [ + { + "field": "src", + "resolve": true, + "relative": true + }, + { + "field": "include", + "resolve": true, + "relative": true + }, + { + "field": "libraries", + "resolve": false, + "relative": false + }, + { + "field": "libpath", + "resolve": true, + "relative": false + } + ], + "confs": [ + { + "task": "build", + "src": [ + "./src/main.c" + ], + "include": [ + "./include" + ], + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/math/base/napi/binary", + "@stdlib/math/base/assert/is-integer", + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/gamma-delta-ratio", + "@stdlib/math/base/special/falling-factorial" + ] + }, + { + "task": "benchmark", + "src": [ + "./src/main.c" + ], + "include": [ + "./include" + ], + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/math/base/assert/is-integer", + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/gamma-delta-ratio", + "@stdlib/math/base/special/falling-factorial" + ] + }, + { + "task": "examples", + "src": [ + "./src/main.c" + ], + "include": [ + "./include" + ], + "libraries": [], + "libpath": [], + "dependencies": [ + "@stdlib/math/base/assert/is-integer", + "@stdlib/math/base/assert/is-nan", + "@stdlib/math/base/special/gamma-delta-ratio", + "@stdlib/math/base/special/falling-factorial" + ] + } + ] +} diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/package.json b/lib/node_modules/@stdlib/math/base/special/rising-factorial/package.json index 2ca3c43c2d36..e5adfd177831 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/package.json +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/package.json @@ -14,11 +14,14 @@ } ], "main": "./lib", + "gypfile": true, "directories": { "benchmark": "./benchmark", "doc": "./docs", "example": "./examples", + "include": "./include", "lib": "./lib", + "src": "./src", "test": "./test" }, "types": "./docs/types", diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/Makefile b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/Makefile new file mode 100644 index 000000000000..7733b6180cb4 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/Makefile @@ -0,0 +1,70 @@ +#/ +# @license Apache-2.0 +# +# Copyright (c) 2025 The Stdlib Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#/ + +# VARIABLES # + +ifndef VERBOSE + QUIET := @ +else + QUIET := +endif + +# Determine the OS ([1][1], [2][2]). +# +# [1]: https://en.wikipedia.org/wiki/Uname#Examples +# [2]: http://stackoverflow.com/a/27776822/2225624 +OS ?= $(shell uname) +ifneq (, $(findstring MINGW,$(OS))) + OS := WINNT +else +ifneq (, $(findstring MSYS,$(OS))) + OS := WINNT +else +ifneq (, $(findstring CYGWIN,$(OS))) + OS := WINNT +else +ifneq (, $(findstring Windows_NT,$(OS))) + OS := WINNT +endif +endif +endif +endif + + +# RULES # + +#/ +# Removes generated files for building an add-on. +# +# @example +# make clean-addon +#/ +clean-addon: + $(QUIET) -rm -f *.o *.node + +.PHONY: clean-addon + +#/ +# Removes generated files. +# +# @example +# make clean +#/ +clean: clean-addon + +.PHONY: clean diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c new file mode 100644 index 000000000000..b4571a643353 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c @@ -0,0 +1,23 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +#include "stdlib/math/base/special/rising_factorial.h" +#include "stdlib/math/base/napi/binary.h" + +// cppcheck-suppress shadowFunction +STDLIB_MATH_BASE_NAPI_MODULE_DI_D( stdlib_base_rising_factorial ) diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c new file mode 100644 index 000000000000..fcbf4465b82a --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c @@ -0,0 +1,114 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +* +* +* ## Notice +* +* The original C++ code and copyright notice are from the [Boost library]{@link http://www.boost.org/doc/libs/1_64_0/boost/math/special_functions/factorials.hpp}. The implementation has been modified according to project conventions. +* +* ```text +* (C) Copyright John Maddock 2006, 2010. +* +* Use, modification and distribution are subject to the +* Boost Software License, Version 1.0. (See accompanying file +* LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt) +* ``` +*/ + +#include "stdlib/math/base/assert/is_integer.h" +#include "stdlib/math/base/assert/is_nan.h" +#include "stdlib/math/base/special/gamma_delta_ratio.h" +#include "stdlib/math/base/special/falling_factorial.h" + +/** +* Computes the rising factorial of `x` and `n`. +* +* ## Notes +* +* - The rising factorial is defined as +* +* ```tex +* \operatorname{stdlib_base_rising_factorial}(x, n) = x (x-1) (x-2) (x-3) \ldots (x-n+1) +* ``` +* +* or equivalently +* +* ```tex +* \operatorname{stdlib_base_rising_factorial}(x, n) = \frac{ \Gamma(x + n) }{ \Gamma(x) }; +* ``` +* +* @param {number} x - first function parameter +* @param {integer} n - second function parameter +* @returns {number} function value +* +* @example +* double v = stdlib_base_rising_factorial( 0.9, 5 ); +* // returns ~94.766 +* +* @example +* double v = stdlib_base_rising_factorial( -9.0, 3 ); +* // returns -504.0 +* +* @example +* double v = stdlib_base_rising_factorial( 0.0, 2 ); +* // returns 0.0 +* +* @example +* double v = stdlib_base_rising_factorial( 3.0, -2 ); +* // returns 0.5 +*/ +double stdlib_base_rising_factorial( const double x, const int32_t n ) { + double result; + int32_t nc; + double xc; + bool inv; + + if ( stdlib_base_is_nan( x ) || !stdlib_base_is_integer( n ) ) { + return 0.0 / 0.0; // NaN + } + nc = n; + xc = x; + inv = false; + if ( xc < 0.0 ) { + if ( nc < 0.0 ) { + xc += nc; + nc = -nc; + inv = true; + } + result = ( ( nc & 1 ) ? -1.0 : 1.0 ) * stdlib_base_falling_factorial( -xc, nc ); + if ( inv ) { + result = 1.0 / result; + } + return result; + } + if ( nc == 0 ) { + return 1.0; + } + if ( xc == 0.0 ) { + if ( nc < 0 ) { + return -stdlib_base_gamma_delta_ratio( xc + 1.0, -nc ); + } + return 0.0; + } + if ( ( xc < 1.0 ) && ( xc + nc < 0.0 ) ) { + result = stdlib_base_gamma_delta_ratio( 1.0 - xc, -nc ); + return ( nc & 1 ) ? -result : result; + } + + // We don't optimize this for small `nc`, because `stdlib_base_gamma_delta_ratio` is already optimized for that use case: + return 1.0 / stdlib_base_gamma_delta_ratio( xc, nc ); +} diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js index 52489fbecf80..66fd00ce0b60 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js @@ -21,7 +21,6 @@ // MODULES // var tape = require( 'tape' ); -var isnan = require( '@stdlib/math/base/assert/is-nan' ); var abs = require( '@stdlib/math/base/special/abs' ); var EPS = require( '@stdlib/constants/float64/eps' ); var risingFactorial = require( './../lib' ); @@ -40,43 +39,34 @@ tape( 'main export is a function', function test( t ) { t.end(); }); -tape( 'the function returns `NaN` if provided `NaN` as any argument', function test( t ) { - var val = risingFactorial( 0.5, NaN ); - t.equal( isnan( val ), true, 'returns NaN' ); - - val = risingFactorial( NaN, -1.0 ); - t.equal( isnan( val ), true, 'returns NaN' ); - t.end(); -}); - tape( 'the function returns `1` if provided `n = 0` and a nonnegative `x`', function test( t ) { var val = risingFactorial( 2.0, 0 ); - t.equal( val, 1.0, 'returns 1' ); + t.equal( val, 1.0, 'returns expected value' ); val = risingFactorial( 0.2, 0 ); - t.equal( val, 1.0, 'returns 1' ); + t.equal( val, 1.0, 'returns expected value' ); val = risingFactorial( -2.0, 0 ); - t.equal( val, 1.0, 'returns 1' ); + t.equal( val, 1.0, 'returns expected value' ); val = risingFactorial( -0.2, 0 ); - t.equal( val, 1.0, 'returns 1' ); + t.equal( val, 1.0, 'returns expected value' ); t.end(); }); tape( 'the function returns `0` if provided `x = 0` and a positive `n`', function test( t ) { var val = risingFactorial( 0.0, 4 ); - t.equal( val, 0.0, 'returns 0' ); + t.equal( val, 0.0, 'returns expected value' ); val = risingFactorial( 0.0, 1 ); - t.equal( val, 0.0, 'returns 0' ); + t.equal( val, 0.0, 'returns expected value' ); t.end(); }); tape( 'the function returns evaluates the rising factorial if provided `x = 0` and a negative `n`', function test( t ) { var val = risingFactorial( 0.0, -1 ); - t.equal( val, -1.0, 'returns -1' ); + t.equal( val, -1.0, 'returns expected value' ); t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js new file mode 100644 index 000000000000..88ace8258fc1 --- /dev/null +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js @@ -0,0 +1,105 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var resolve = require( 'path' ).resolve; +var tape = require( 'tape' ); +var tryRequire = require( '@stdlib/utils/try-require' ); +var abs = require( '@stdlib/math/base/special/abs' ); +var EPS = require( '@stdlib/constants/float64/eps' ); + + +// FIXTURES // + +var data = require( './fixtures/cpp/output.json' ); + + +// VARIABLES // + +var risingFactorial = tryRequire( resolve( __dirname, './../lib/native.js' ) ); +var opts = { + 'skip': ( risingFactorial instanceof Error ) +}; + + +// TESTS // + +tape( 'main export is a function', opts, function test( t ) { + t.ok( true, __filename ); + t.strictEqual( typeof risingFactorial, 'function', 'main export is a function' ); + t.end(); +}); + +tape( 'the function returns `1` if provided `n = 0` and a nonnegative `x`', opts, function test( t ) { + var val = risingFactorial( 2.0, 0 ); + t.equal( val, 1.0, 'returns expected value' ); + + val = risingFactorial( 0.2, 0 ); + t.equal( val, 1.0, 'returns expected value' ); + + val = risingFactorial( -2.0, 0 ); + t.equal( val, 1.0, 'returns expected value' ); + + val = risingFactorial( -0.2, 0 ); + t.equal( val, 1.0, 'returns expected value' ); + + t.end(); +}); + +tape( 'the function returns `0` if provided `x = 0` and a positive `n`', opts, function test( t ) { + var val = risingFactorial( 0.0, 4 ); + t.equal( val, 0.0, 'returns expected value' ); + + val = risingFactorial( 0.0, 1 ); + t.equal( val, 0.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function returns evaluates the rising factorial if provided `x = 0` and a negative `n`', opts, function test( t ) { + var val = risingFactorial( 0.0, -1 ); + t.equal( val, -1.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function evaluates the rising factorial', function test( t ) { + var expected; + var delta; + var tol; + var i; + var n; + var x; + var y; + + expected = data.expected; + x = data.x; + n = data.n; + for ( i = 0; i < x.length; i++ ) { + y = risingFactorial( x[i], n[i] ); + if ( y === expected[i] ) { + t.equal( y, expected[i], 'x: '+x[i]+'. n: '+n[i]+', y: '+y+'. expected: '+expected[i] ); + } else { + delta = abs( y - expected[ i ] ); + tol = 70.0 * EPS * abs( expected[ i ] ); + t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[i]+'. Δ: '+delta+'. tol: '+tol ); + } + } + t.end(); +}); From 55392fd097188a34d9b7390b585207fcda9c2a97 Mon Sep 17 00:00:00 2001 From: DhruvArvindSingh Date: Thu, 2 Jan 2025 09:42:22 +0000 Subject: [PATCH 2/4] fix(readme): fixed readme --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../@stdlib/math/base/special/rising-factorial/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md index c3af32d4cd60..c13dea32a869 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md @@ -20,7 +20,7 @@ limitations under the License. # Rising Factorial -> Compute the [rising factorial][rising-and-rising-factorials]. +Compute the [rising factorial][rising-and-rising-factorials].
From d92269da943bf6934a6d7c225aeb2a04d7e37e50 Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sun, 11 May 2025 01:49:20 -0700 Subject: [PATCH 3/4] chore: apply suggestions from review --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/special/rising-factorial/README.md | 25 ++++++++++++----- .../benchmark/benchmark.native.js | 10 +++---- .../benchmark/c/native/benchmark.c | 7 +++-- .../rising-factorial/examples/c/example.c | 2 +- .../rising-factorial/examples/index.js | 18 ++++++------ .../special/rising-factorial/lib/native.js | 28 +------------------ .../special/rising-factorial/manifest.json | 3 -- .../base/special/rising-factorial/src/addon.c | 1 - .../base/special/rising-factorial/src/main.c | 22 ++++++++------- .../special/rising-factorial/test/test.js | 1 + .../rising-factorial/test/test.native.js | 27 +++++++++++------- 11 files changed, 67 insertions(+), 77 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md index c13dea32a869..9d17dde0e452 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/README.md @@ -20,7 +20,7 @@ limitations under the License. # Rising Factorial -Compute the [rising factorial][rising-and-rising-factorials]. +> Compute the [rising factorial][falling-and-rising-factorials].
@@ -38,7 +38,7 @@ var risingFactorial = require( '@stdlib/math/base/special/rising-factorial' ); #### risingFactorial( x, n ) -Evaluates the [rising factorial][rising-and-rising-factorials] of `x` and `n`. +Evaluates the [rising factorial][falling-and-rising-factorials] of `x` and `n`. ```javascript var v = risingFactorial( 0.9, 5 ); @@ -128,7 +128,7 @@ for ( i = 0; i < 100; i++ ) { #### stdlib_base_rising_factorial( x, n ) -Evaluates the rising factorial of `x` and `n`. +Evaluates the [rising factorial][falling-and-rising-factorials] of `x` and `n`. ```c double out = stdlib_base_rising_factorial( 0.9, 5 ); @@ -148,26 +148,37 @@ double stdlib_base_rising_factorial( const double x, const int32_t n ); ```
+ + +
+
+ + +
+ ### Examples + ```c #include "stdlib/math/base/special/rising_factorial.h" #include #include + int main( void ) { const double x[] = { -10.0, -7.78, -5.56, -3.33, -1.11, 1.11, 3.33, 5.56, 7.78, 10.0 }; const int32_t n[] = { 5, 4, 3, 2, 1, 0, -1, -2, -3, -4 }; + double v; int i; for ( i = 0; i < 10; i++ ) { v = stdlib_base_rising_factorial( x[ i ], n[ i ] ); - printf( "x: %lf, n: %d, rising_factorial(x,n): %lf\n", x[ i ], n[ i ], v ); + printf( "risingFactorial(%lf, %d) = %lf\n", x[ i ], n[ i ], v ); } } ``` @@ -188,7 +199,7 @@ int main( void ) { ## See Also -- [`@stdlib/math/base/special/rising-factorial`][@stdlib/math/base/special/rising-factorial]: compute the rising factorial. +- [`@stdlib/math/base/special/falling-factorial`][@stdlib/math/base/special/falling-factorial]: compute the falling factorial.
@@ -198,11 +209,11 @@ int main( void ) {
-[rising-and-rising-factorials]: https://en.wikipedia.org/wiki/rising_and_rising_factorials +[falling-and-rising-factorials]: https://en.wikipedia.org/wiki/Falling_and_rising_factorials -[@stdlib/math/base/special/rising-factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/rising-factorial +[@stdlib/math/base/special/falling-factorial]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/falling-factorial diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js index e7e26bec2fb2..a451e376bc03 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.native.js @@ -22,7 +22,7 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/array/uniform' ); +var uniform = require( '@stdlib/random/array/uniform' ); var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -39,18 +39,18 @@ var opts = { // MAIN // -bench( pkg, opts, function benchmark( b ) { +bench( pkg+'::native', opts, function benchmark( b ) { var x; var n; var y; var i; - x = randu( 100, 1.0, 41.0 ); - n = discreteUniform( 100, 0, 40 ); + x = uniform( 100, -50.0, 50.0 ); + n = discreteUniform( 100, -50, 50 ); b.tic(); for ( i = 0; i < b.iterations; i++ ) { - y = risingFactorial( x[ i % x.length ], n[ i % n.length ] ); + y = risingFactorial( x[ i%x.length ], n[ i%n.length ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c index d7f8c3b617e8..9d8b555b5ca4 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/c/native/benchmark.c @@ -18,6 +18,7 @@ #include "stdlib/math/base/special/rising_factorial.h" #include +#include #include #include #include @@ -98,13 +99,13 @@ static double benchmark( void ) { int i; for ( i = 0; i < 100; i++ ) { - x[ i ] = ( 40.0 * rand_double() ) + 1.0; - n[ i ] = (int32_t)( 41.0 * rand_double() ); + x[ i ] = ( 100.0*rand_double() ) - 50.0; + n[ i ] = (int32_t)( 50.0*rand_double() ); } t = tic(); for ( i = 0; i < ITERATIONS; i++ ) { - y = stdlib_base_rising_factorial( x[ i % 100 ], n[ i % 100 ] ); + y = stdlib_base_rising_factorial( x[ i%100 ], n[ i%100 ] ); if ( y != y ) { printf( "should return a nonnegative integer\n" ); break; diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c index f17d12a61ac1..3c3138bb4afd 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/c/example.c @@ -28,6 +28,6 @@ int main( void ) { int i; for ( i = 0; i < 10; i++ ) { v = stdlib_base_rising_factorial( x[ i ], n[ i ] ); - printf( "x: %lf, n: %d, rising_factorial(x,n): %lf\n", x[ i ], n[ i ], v ); + printf( "risingFactorial(%lf, %d) = %lf\n", x[ i ], n[ i ], v ); } } diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js index c8102a86510d..eb91b343c459 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/examples/index.js @@ -18,17 +18,15 @@ 'use strict'; -var randu = require( '@stdlib/random/array/uniform' ); +var uniform = require( '@stdlib/random/array/uniform' ); var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); +var logEachMap = require( '@stdlib/console/log-each-map' ); var risingFactorial = require( './../lib' ); -var n; -var x; -var i; +var opts = { + 'dtype': 'float64' +}; +var x = uniform( 100, -20.0, 20.0, opts ); +var n = discreteUniform( 100, -20, 20, opts ); -x = randu( 100, -20.0, 20.0 ); -n = discreteUniform( 100, 0, 20 ); - -for ( i = 0; i < 100; i++ ) { - console.log( 'risingFactorial(%d,%d) = %d', x[ i ], n[ i ], risingFactorial( x[ i ], n[ i ] ) ); -} +logEachMap( 'risingFactorial(%0.4f, %d) = %0.4f', x, n, risingFactorial ); diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js index 3bf6b4c12ec0..bbee8f57a410 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/lib/native.js @@ -14,19 +14,6 @@ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. -* -* -* ## Notice -* -* The original C++ code and copyright notice are from the [Boost library]{@link http://www.boost.org/doc/libs/1_64_0/boost/math/special_functions/factorials.hpp}. The implementation has been modified for JavaScript. -* -* ```text -* (C) Copyright John Maddock 2006, 2010. -* -* Use, modification and distribution are subject to the -* Boost Software License, Version 1.0. (See accompanying file -* LICENSE or copy at http://www.boost.org/LICENSE_1_0.txt) -* ``` */ 'use strict'; @@ -41,20 +28,7 @@ var addon = require( './../src/addon.node' ); /** * Computes the rising factorial of `x` and `n`. * -* ## Notes -* -* - The rising factorial is defined as -* -* ```tex -* \operatorname{risingFactorial}(x, n) = x (x-1) (x-2) (x-3) \ldots (x-n+1) -* ``` -* -* or equivalently -* -* ```tex -* \operatorname{risingFactorial}(x, n) = \frac{ \Gamma(x + n) }{ \Gamma(x) }; -* ``` -* +* @private * @param {number} x - first function parameter * @param {integer} n - second function parameter * @returns {number} function value diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json b/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json index d555b2824ed2..4565d1b7156a 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/manifest.json @@ -37,7 +37,6 @@ "libpath": [], "dependencies": [ "@stdlib/math/base/napi/binary", - "@stdlib/math/base/assert/is-integer", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/gamma-delta-ratio", "@stdlib/math/base/special/falling-factorial" @@ -54,7 +53,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/math/base/assert/is-integer", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/gamma-delta-ratio", "@stdlib/math/base/special/falling-factorial" @@ -71,7 +69,6 @@ "libraries": [], "libpath": [], "dependencies": [ - "@stdlib/math/base/assert/is-integer", "@stdlib/math/base/assert/is-nan", "@stdlib/math/base/special/gamma-delta-ratio", "@stdlib/math/base/special/falling-factorial" diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c index b4571a643353..cfcaf5e6e135 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/addon.c @@ -19,5 +19,4 @@ #include "stdlib/math/base/special/rising_factorial.h" #include "stdlib/math/base/napi/binary.h" -// cppcheck-suppress shadowFunction STDLIB_MATH_BASE_NAPI_MODULE_DI_D( stdlib_base_rising_factorial ) diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c index fcbf4465b82a..0d2cce165bcd 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c @@ -18,7 +18,7 @@ * * ## Notice * -* The original C++ code and copyright notice are from the [Boost library]{@link http://www.boost.org/doc/libs/1_64_0/boost/math/special_functions/factorials.hpp}. The implementation has been modified according to project conventions. +* The original C++ code and copyright notice are from the [Boost library]{@link http://www.boost.org/doc/libs/1_64_0/boost/math/special_functions/factorials.hpp}. The implementation has been modified according to stdlib conventions. * * ```text * (C) Copyright John Maddock 2006, 2010. @@ -33,6 +33,8 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/gamma_delta_ratio.h" #include "stdlib/math/base/special/falling_factorial.h" +#include +#include /** * Computes the rising factorial of `x` and `n`. @@ -51,9 +53,9 @@ * \operatorname{stdlib_base_rising_factorial}(x, n) = \frac{ \Gamma(x + n) }{ \Gamma(x) }; * ``` * -* @param {number} x - first function parameter -* @param {integer} n - second function parameter -* @returns {number} function value +* @param x first function parameter +* @param n second function parameter +* @return function value * * @example * double v = stdlib_base_rising_factorial( 0.9, 5 ); @@ -77,19 +79,20 @@ double stdlib_base_rising_factorial( const double x, const int32_t n ) { double xc; bool inv; - if ( stdlib_base_is_nan( x ) || !stdlib_base_is_integer( n ) ) { + if ( stdlib_base_is_nan( x ) ) { return 0.0 / 0.0; // NaN } nc = n; xc = x; inv = false; if ( xc < 0.0 ) { - if ( nc < 0.0 ) { + // For `x < 0`, we really have a falling factorial, modulo a possible change of sign. Note that the falling factorial isn't defined for negative `n`, so we'll get rid of that case first: + if ( nc < 0 ) { xc += nc; nc = -nc; inv = true; } - result = ( ( nc & 1 ) ? -1.0 : 1.0 ) * stdlib_base_falling_factorial( -xc, nc ); + result = ( (nc&1) ? -1.0 : 1.0 ) * stdlib_base_falling_factorial( -xc, nc ); if ( inv ) { result = 1.0 / result; } @@ -104,11 +107,10 @@ double stdlib_base_rising_factorial( const double x, const int32_t n ) { } return 0.0; } - if ( ( xc < 1.0 ) && ( xc + nc < 0.0 ) ) { + if ( ( xc < 1.0 ) && ( xc+nc < 0.0 ) ) { result = stdlib_base_gamma_delta_ratio( 1.0 - xc, -nc ); - return ( nc & 1 ) ? -result : result; + return ( nc&1 ) ? -result : result; } - // We don't optimize this for small `nc`, because `stdlib_base_gamma_delta_ratio` is already optimized for that use case: return 1.0 / stdlib_base_gamma_delta_ratio( xc, nc ); } diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js index 4527f993a3c8..24c7dae84ee0 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.js @@ -21,6 +21,7 @@ // MODULES // var tape = require( 'tape' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); var abs = require( '@stdlib/math/base/special/abs' ); var EPS = require( '@stdlib/constants/float64/eps' ); var risingFactorial = require( './../lib' ); diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js index 88ace8258fc1..e0fb18673b83 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/test/test.native.js @@ -22,9 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var tryRequire = require( '@stdlib/utils/try-require' ); +var isnan = require( '@stdlib/math/base/assert/is-nan' ); var abs = require( '@stdlib/math/base/special/abs' ); var EPS = require( '@stdlib/constants/float64/eps' ); +var tryRequire = require( '@stdlib/utils/try-require' ); // FIXTURES // @@ -48,38 +49,44 @@ tape( 'main export is a function', opts, function test( t ) { t.end(); }); +tape( 'the function returns `NaN` if provided `NaN` as the first argument', opts, function test( t ) { + var val = risingFactorial( NaN, -1.0 ); + t.strictEqual( isnan( val ), true, 'returns expected value' ); + t.end(); +}); + tape( 'the function returns `1` if provided `n = 0` and a nonnegative `x`', opts, function test( t ) { var val = risingFactorial( 2.0, 0 ); - t.equal( val, 1.0, 'returns expected value' ); + t.strictEqual( val, 1.0, 'returns expected value' ); val = risingFactorial( 0.2, 0 ); - t.equal( val, 1.0, 'returns expected value' ); + t.strictEqual( val, 1.0, 'returns expected value' ); val = risingFactorial( -2.0, 0 ); - t.equal( val, 1.0, 'returns expected value' ); + t.strictEqual( val, 1.0, 'returns expected value' ); val = risingFactorial( -0.2, 0 ); - t.equal( val, 1.0, 'returns expected value' ); + t.strictEqual( val, 1.0, 'returns expected value' ); t.end(); }); tape( 'the function returns `0` if provided `x = 0` and a positive `n`', opts, function test( t ) { var val = risingFactorial( 0.0, 4 ); - t.equal( val, 0.0, 'returns expected value' ); + t.strictEqual( val, 0.0, 'returns expected value' ); val = risingFactorial( 0.0, 1 ); - t.equal( val, 0.0, 'returns expected value' ); + t.strictEqual( val, 0.0, 'returns expected value' ); t.end(); }); tape( 'the function returns evaluates the rising factorial if provided `x = 0` and a negative `n`', opts, function test( t ) { var val = risingFactorial( 0.0, -1 ); - t.equal( val, -1.0, 'returns expected value' ); + t.strictEqual( val, -1.0, 'returns expected value' ); t.end(); }); -tape( 'the function evaluates the rising factorial', function test( t ) { +tape( 'the function evaluates the rising factorial', opts, function test( t ) { var expected; var delta; var tol; @@ -94,7 +101,7 @@ tape( 'the function evaluates the rising factorial', function test( t ) { for ( i = 0; i < x.length; i++ ) { y = risingFactorial( x[i], n[i] ); if ( y === expected[i] ) { - t.equal( y, expected[i], 'x: '+x[i]+'. n: '+n[i]+', y: '+y+'. expected: '+expected[i] ); + t.strictEqual( y, expected[i], 'x: '+x[i]+'. n: '+n[i]+', y: '+y+'. expected: '+expected[i] ); } else { delta = abs( y - expected[ i ] ); tol = 70.0 * EPS * abs( expected[ i ] ); From 56756e018a2a97ac424c6a4f8864f9f417377df2 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Mon, 12 May 2025 06:41:17 -0400 Subject: [PATCH 4/4] chore: apply suggestions from code review Signed-off-by: Philipp Burckhardt --- .../math/base/special/rising-factorial/src/main.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c index 0d2cce165bcd..fccd379e2b33 100644 --- a/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c +++ b/lib/node_modules/@stdlib/math/base/special/rising-factorial/src/main.c @@ -29,7 +29,6 @@ * ``` */ -#include "stdlib/math/base/assert/is_integer.h" #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/gamma_delta_ratio.h" #include "stdlib/math/base/special/falling_factorial.h" @@ -60,18 +59,6 @@ * @example * double v = stdlib_base_rising_factorial( 0.9, 5 ); * // returns ~94.766 -* -* @example -* double v = stdlib_base_rising_factorial( -9.0, 3 ); -* // returns -504.0 -* -* @example -* double v = stdlib_base_rising_factorial( 0.0, 2 ); -* // returns 0.0 -* -* @example -* double v = stdlib_base_rising_factorial( 3.0, -2 ); -* // returns 0.5 */ double stdlib_base_rising_factorial( const double x, const int32_t n ) { double result;