From db422d5472ead4287739eeeaa7e7ab0a5f5c0159 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 07:42:13 +0000 Subject: [PATCH 1/6] feat: add accessor arrays support --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../blas/ext/base/gcusumkbn2/README.md | 3 + .../ext/base/gcusumkbn2/docs/types/index.d.ts | 16 +- .../ext/base/gcusumkbn2/docs/types/test.ts | 7 +- .../blas/ext/base/gcusumkbn2/lib/accessors.js | 118 ++++++++ .../blas/ext/base/gcusumkbn2/lib/ndarray.js | 9 + .../ext/base/gcusumkbn2/test/test.main.js | 195 +++++++++++-- .../ext/base/gcusumkbn2/test/test.ndarray.js | 265 ++++++++++++++++-- 7 files changed, 572 insertions(+), 41 deletions(-) create mode 100644 lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/README.md b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/README.md index d91a5a5af5e2..009d0ae8e67d 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/README.md +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/README.md @@ -128,6 +128,7 @@ gcusumkbn2.ndarray( 4, 0.0, x, 2, 1, y, -1, y.length-1 ); ## Notes - If `N <= 0`, both functions return `y` unchanged. +- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]) - Depending on the environment, the typed versions ([`dcusumkbn2`][@stdlib/blas/ext/base/dcusumkbn2], [`scusumkbn2`][@stdlib/blas/ext/base/scusumkbn2], etc.) are likely to be significantly more performant. @@ -197,6 +198,8 @@ console.log( y ); [mdn-typed-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray +[@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor + [@klein:2005a]: https://doi.org/10.1007/s00607-005-0139-x diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts index d295706b2420..d29ab143eb3c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts @@ -20,7 +20,17 @@ /// -import { NumericArray } from '@stdlib/types/array'; +import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array'; + +/** +* Input array. +*/ +type InputArray = NumericArray | Collection | AccessorArrayLike; + +/** +* Input array. +*/ +type OutputArray = NumericArray | Collection | AccessorArrayLike; /** * Interface describing `gcusumkbn2`. @@ -44,7 +54,7 @@ interface Routine { * gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ( N: number, sum: number, x: NumericArray, strideX: number, y: NumericArray, strideY: number ): NumericArray; + ( N: number, sum: number, x: InputArray, strideX: number, y: OutputArray, strideY: number ): OutputArray; /** * Computes the cumulative sum of strided array elements using a second-order iterative Kahan–Babuška algorithm and alternative indexing semantics. @@ -66,7 +76,7 @@ interface Routine { * gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ndarray( N: number, sum: number, x: NumericArray, strideX: number, offsetX: number, y: NumericArray, strideY: number, offsetY: number ): NumericArray; + ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: OutputArray, strideY: number, offsetY: number ): OutputArray; } /** diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts index 4419b2d0814c..9ec94ae0ad03 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts @@ -16,6 +16,7 @@ * limitations under the License. */ +import AccessorArray = require( '@stdlib/array/base/accessor' ); import gcusumkbn2 = require( './index' ); @@ -26,7 +27,8 @@ import gcusumkbn2 = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); // $ExpectType NumericArray + gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); // $ExpectType OutputArray + gcusumkbn2( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType OutputArray } // The compiler throws an error if the function is provided a first argument which is not a number... @@ -139,7 +141,8 @@ import gcusumkbn2 = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType NumericArray + gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType OutputArray + gcusumkbn2.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType OutputArray } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js new file mode 100644 index 000000000000..079bab1e84ad --- /dev/null +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js @@ -0,0 +1,118 @@ +/** +* @license Apache-2.0 +* +* Copyright (c) 2025 The Stdlib Authors. +* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +'use strict'; + +// MODULES // + +var abs = require( '@stdlib/math/base/special/abs' ); + + +// MAIN // + +/** +* Computes the cumulative sum of strided array elements using a second-order iterative Kahan–Babuška algorithm. +* +* ## Method +* +* - This implementation uses a second-order iterative Kahan–Babuška algorithm, as described by Klein (2005). +* +* ## References +* +* - Klein, Andreas. 2005. "A Generalized Kahan-Babuška-Summation-Algorithm." _Computing_ 76 (3): 279–93. doi:[10.1007/s00607-005-0139-x](https://doi.org/10.1007/s00607-005-0139-x). +* +* @private +* @param {PositiveInteger} N - number of indexed elements +* @param {number} sum - initial sum +* @param {Object} x - input array object +* @param {Collection} x.data - input array data +* @param {Array} x.accessors - array element accessors +* @param {integer} strideX - stride length for `x` +* @param {NonNegativeInteger} offsetX - starting index for `x` +* @param {Object} y - output array object +* @param {Collection} y.data - output array data +* @param {Array} y.accessors - array element accessors +* @param {integer} strideY - stride length for `y` +* @param {NonNegativeInteger} offsetY - starting index for `y` +* @returns {Object} output array object +* +* @example +* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); +* var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); +* +* var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); +* var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); +* +* gcusumkbn( 4, 5.0, arraylike2object( x ), 2, 1 ); +*/ +function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { + var xbuf; + var ybuf; + var xget; + var yset; + var ccs; + var ix; + var iy; + var cs; + var cc; + var v; + var t; + var c; + var i; + + // Cache reference to array data: + xbuf = x.data; + ybuf = y.data; + + // Cache reference to the element accessors: + xget = x.accessors[ 0 ]; + yset = y.accessors[ 1 ]; + + ix = offsetX; + iy = offsetY; + ccs = 0.0; // second order correction term for lost low order bits + cs = 0.0; // first order correction term for lost low order bits + for ( i = 0; i < N; i++ ) { + v = xget( xbuf, ix ); + t = sum + v; + if ( abs( sum ) >= abs( v ) ) { + c = (sum-t) + v; + } else { + c = (v-t) + sum; + } + sum = t; + t = cs + c; + if ( abs( cs ) >= abs( c ) ) { + cc = (cs-t) + c; + } else { + cc = (c-t) + cs; + } + cs = t; + ccs += cc; + + yset( ybuf, iy, sum + cs + ccs ); + ix += strideX; + iy += strideY; + } + return y; +} + + +// EXPORTS // + +module.exports = gcusumkbn2; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js index 762d2127c58b..e65a95484de1 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js @@ -20,7 +20,9 @@ // MODULES // +var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); var abs = require( '@stdlib/math/base/special/abs' ); +var accessors = require( './accessors.js' ); // MAIN // @@ -57,6 +59,8 @@ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var ccs; var ix; var iy; + var ox; + var oy; var cs; var cc; var v; @@ -67,6 +71,11 @@ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { if ( N <= 0 ) { return y; } + ox = arraylike2object( x ); + oy = arraylike2object( y ); + if ( ox.accessorProtocol && oy.accessorProtocol ) { + return accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); + } ix = offsetX; iy = offsetY; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js index 04f73956e706..bead9645d529 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var Float64Array = require( '@stdlib/array/float64' ); var gcusumkbn2 = require( './../lib' ); @@ -128,6 +128,94 @@ tape( 'the function computes the cumulative sum', function test( t ) { t.end(); }); +tape( 'the function computes the cumulative sum (accessors)', function test( t ) { + var expected; + var x; + var y; + var i; + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + expected = [ + 1.0, + 3.0, + 6.0, + 10.0, + 15.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn2( x.length, 10.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + expected = [ + 11.0, + 13.0, + 16.0, + 20.0, + 25.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ NaN, NaN ]; + y = [ 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + for ( i = 0; i < y.length; i++ ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } + + x = [ 1.0, NaN, 3.0, NaN ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + expected = [ + 1.0, + NaN, + NaN, + NaN + ]; + for ( i = 0; i < y.length; i++ ) { + if ( isnan( expected[ i ] ) ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } else { + t.strictEqual( y[ i ], expected[ i ], true, 'returns expected value. i: ' + i ); + } + } + + x = [ 1.0, 1.0e100, 1.0, -1.0e100 ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + + expected = [ + 1.0, + 1.0e100, + 1.0e100, + 2.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = []; + y = []; + expected = []; + for ( i = 0; i < 1e3; i++ ) { + x.push( i+1 ); + y.push( 0.0 ); + if ( i === 0 ) { + expected.push( x[ i ] ); + } else { + expected.push( expected[ i-1 ] + x[ i ] ); + } + } + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 1 ); + t.deepEqual( y, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function returns a reference to the output array', function test( t ) { var out; var x; @@ -165,7 +253,6 @@ tape( 'the function supports an `x` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -181,9 +268,36 @@ tape( 'the function supports an `x` stride', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 2, y, 1 ); + gcusumkbn2( 3, 0.0, x, 2, y, 1 ); + + expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports an `x` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 2 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, + 0.0 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), 2, toAccessorArray( y ), 1 ); expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; @@ -195,7 +309,6 @@ tape( 'the function supports a `y` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -211,9 +324,36 @@ tape( 'the function supports a `y` stride', function test( t ) { 0.0, 0.0 // 2 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 1, y, 2 ); + gcusumkbn2( 3, 0.0, x, 1, y, 2 ); + + expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports a `y` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, // 1 + 3.0, // 2 + 4.0, + 5.0 + ]; + y = [ + 0.0, // 0 + 0.0, + 0.0, // 1 + 0.0, + 0.0 // 2 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), 1, toAccessorArray( y ), 2 ); expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; @@ -225,7 +365,6 @@ tape( 'the function supports negative strides', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 2 @@ -241,9 +380,36 @@ tape( 'the function supports negative strides', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, -2, y, -1 ); + gcusumkbn2( 3, 0.0, x, -2, y, -1 ); + + expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'deep equal' ); + t.end(); +}); + +tape( 'the function supports negative strides (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 2 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 0 + ]; + y = [ + 0.0, // 2 + 0.0, // 1 + 0.0, // 0 + 0.0, + 0.0 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), -2, toAccessorArray( y ), -1 ); expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; @@ -255,7 +421,6 @@ tape( 'the function supports complex access patterns', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -273,9 +438,8 @@ tape( 'the function supports complex access patterns', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 2, y, -1 ); + gcusumkbn2( 3, 0.0, x, 2, y, -1 ); expected = [ 9.0, 4.0, 1.0, 0.0, 0.0, 0.0 ]; @@ -289,7 +453,6 @@ tape( 'the function supports view offsets', function test( t ) { var y0; var x1; var y1; - var N; // Initial arrays... x0 = new Float64Array([ @@ -313,9 +476,7 @@ tape( 'the function supports view offsets', function test( t ) { x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // begin at 2nd element y1 = new Float64Array( y0.buffer, y0.BYTES_PER_ELEMENT*3 ); // begin at the 4th element - N = floor( x0.length / 2 ); - - gcusumkbn2( N, 0.0, x1, -2, y1, 1 ); + gcusumkbn2( 3, 0.0, x1, -2, y1, 1 ); expected = new Float64Array( [ 0.0, 0.0, 0.0, 6.0, 10.0, 12.0 ] ); t.deepEqual( y0, expected, 'deep equal' ); diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js index 3b194d7478e7..595454db7c68 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var gcusumkbn2 = require( './../lib/ndarray.js' ); @@ -126,6 +126,93 @@ tape( 'the function calculates the cumulative sum', function test( t ) { t.end(); }); +tape( 'the function calculates the cumulative sum (accessors)', function test( t ) { + var expected; + var x; + var y; + var i; + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + expected = [ + 1.0, + 3.0, + 6.0, + 10.0, + 15.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ 1.0, 2.0, 3.0, 4.0, 5.0 ]; + y = [ 0.0, 0.0, 0.0, 0.0, 0.0 ]; + + gcusumkbn2( x.length, 10.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + expected = [ + 11.0, + 13.0, + 16.0, + 20.0, + 25.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = [ NaN, NaN ]; + y = [ 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + for ( i = 0; i < y.length; i++ ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } + + x = [ 1.0, NaN, 3.0, NaN ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + expected = [ + 1.0, + NaN, + NaN, + NaN + ]; + for ( i = 0; i < y.length; i++ ) { + if ( isnan( expected[ i ] ) ) { + t.strictEqual( isnan( y[ i ] ), true, 'returns expected value. i: ' + i ); + } else { + t.strictEqual( y[ i ], expected[ i ], true, 'returns expected value. i: ' + i ); + } + } + + x = [ 1.0, 1.0e100, 1.0, -1.0e100 ]; + y = [ 0.0, 0.0, 0.0, 0.0 ]; + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + + expected = [ + 1.0, + 1.0e100, + 1.0e100, + 2.0 + ]; + t.deepEqual( y, expected, 'returns expected value' ); + + x = []; + y = []; + expected = []; + for ( i = 0; i < 1e3; i++ ) { + x.push( i+1 ); + if ( i === 0 ) { + expected.push( x[ i ] ); + } else { + expected.push( expected[ i-1 ] + x[ i ] ); + } + } + gcusumkbn2( x.length, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 1, 0 ); + t.deepEqual( y, expected, 'returns expected value' ); + + t.end(); +}); + tape( 'the function returns a reference to the output array', function test( t ) { var out; var x; @@ -163,7 +250,6 @@ tape( 'the function supports an `x` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -179,9 +265,36 @@ tape( 'the function supports an `x` stride', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 2, 0, y, 1, 0 ); + gcusumkbn2( 3, 0.0, x, 2, 0, y, 1, 0 ); + + expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports an `x` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 2 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, + 0.0 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), 2, 0, toAccessorArray( y ), 1, 0 ); expected = [ 1.0, 4.0, 9.0, 0.0, 0.0 ]; @@ -193,7 +306,6 @@ tape( 'the function supports a `y` stride', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -209,9 +321,36 @@ tape( 'the function supports a `y` stride', function test( t ) { 0.0, 0.0 // 2 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 1, 0, y, 2, 0 ); + gcusumkbn2( 3, 0.0, x, 1, 0, y, 2, 0 ); + + expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a `y` stride (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 0 + 2.0, // 1 + 3.0, // 2 + 4.0, + 5.0 + ]; + y = [ + 0.0, // 0 + 0.0, + 0.0, // 1 + 0.0, + 0.0 // 2 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 2, 0 ); expected = [ 1.0, 0.0, 3.0, 0.0, 6.0 ]; @@ -223,7 +362,6 @@ tape( 'the function supports negative strides', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 2 @@ -239,9 +377,36 @@ tape( 'the function supports negative strides', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, -2, x.length-1, y, -1, 2 ); + gcusumkbn2( 3, 0.0, x, -2, x.length-1, y, -1, 2 ); + + expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports negative strides (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 1.0, // 2 + 2.0, + 3.0, // 1 + 4.0, + 5.0 // 0 + ]; + y = [ + 0.0, // 2 + 0.0, // 1 + 0.0, // 0 + 0.0, + 0.0 + ]; + + gcusumkbn2( 3, 0.0, toAccessorArray( x ), -2, x.length-1, toAccessorArray( y ), -1, 2 ); expected = [ 9.0, 8.0, 5.0, 0.0, 0.0 ]; @@ -251,7 +416,6 @@ tape( 'the function supports negative strides', function test( t ) { tape( 'the function supports an `x` offset', function test( t ) { var expected; - var N; var x; var y; @@ -275,9 +439,42 @@ tape( 'the function supports an `x` offset', function test( t ) { 0.0, 0.0 ]; - N = floor( x.length / 2 ); - gcusumkbn2( N, 0.0, x, 2, 1, y, 1, 0 ); + gcusumkbn2( 4, 0.0, x, 2, 1, y, 1, 0 ); + + expected = [ 1.0, -1.0, 1.0, 5.0, 0.0, 0.0, 0.0, 0.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports an `x` offset (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 2.0, + 1.0, // 0 + 2.0, + -2.0, // 1 + -2.0, + 2.0, // 2 + 3.0, + 4.0 // 3 + ]; + y = [ + 0.0, // 0 + 0.0, // 1 + 0.0, // 2 + 0.0, // 3 + 0.0, + 0.0, + 0.0, + 0.0 + ]; + + gcusumkbn2( 4, 0.0, toAccessorArray( x ), 2, 1, toAccessorArray( y ), 1, 0 ); expected = [ 1.0, -1.0, 1.0, 5.0, 0.0, 0.0, 0.0, 0.0 ]; @@ -287,7 +484,6 @@ tape( 'the function supports an `x` offset', function test( t ) { tape( 'the function supports a `y` offset', function test( t ) { var expected; - var N; var x; var y; @@ -311,9 +507,42 @@ tape( 'the function supports a `y` offset', function test( t ) { 0.0, 0.0 // 3 ]; - N = floor( x.length / 2 ); - gcusumkbn2( N, 0.0, x, 1, 0, y, 2, 1 ); + gcusumkbn2( 4, 0.0, x, 1, 0, y, 2, 1 ); + + expected = [ 0.0, 2.0, 0.0, 3.0, 0.0, 5.0, 0.0, 3.0 ]; + + t.deepEqual( y, expected, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a `y` offset (accessors)', function test( t ) { + var expected; + var x; + var y; + + x = [ + 2.0, // 0 + 1.0, // 1 + 2.0, // 2 + -2.0, // 3 + -2.0, + 2.0, + 3.0, + 4.0 + ]; + y = [ + 0.0, + 0.0, // 0 + 0.0, + 0.0, // 1 + 0.0, + 0.0, // 2 + 0.0, + 0.0 // 3 + ]; + + gcusumkbn2( 4, 0.0, toAccessorArray( x ), 1, 0, toAccessorArray( y ), 2, 1 ); expected = [ 0.0, 2.0, 0.0, 3.0, 0.0, 5.0, 0.0, 3.0 ]; @@ -325,7 +554,6 @@ tape( 'the function supports complex access patterns', function test( t ) { var expected; var x; var y; - var N; x = [ 1.0, // 0 @@ -343,9 +571,8 @@ tape( 'the function supports complex access patterns', function test( t ) { 0.0, 0.0 ]; - N = 3; - gcusumkbn2( N, 0.0, x, 2, 0, y, -1, 2 ); + gcusumkbn2( 3, 0.0, x, 2, 0, y, -1, 2 ); expected = [ 9.0, 4.0, 1.0, 0.0, 0.0, 0.0 ]; From 891507185fac324752b6e5f8bad77927b4703c3f Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 13:40:23 +0500 Subject: [PATCH 2/6] refactor: apply review suggestion Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js index e65a95484de1..ea9cdfebd5ce 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js @@ -73,7 +73,7 @@ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { } ox = arraylike2object( x ); oy = arraylike2object( y ); - if ( ox.accessorProtocol && oy.accessorProtocol ) { + if ( ox.accessorProtocol || oy.accessorProtocol ) { return accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); } ix = offsetX; From 8d8d3efe754110ac7ebd15f7d879f1bb46997b7c Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 15:06:06 +0500 Subject: [PATCH 3/6] docs: apply review suggestion Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js index 079bab1e84ad..1a56041d778f 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js @@ -58,7 +58,7 @@ var abs = require( '@stdlib/math/base/special/abs' ); * var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); * var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); * -* gcusumkbn( 4, 5.0, arraylike2object( x ), 2, 1 ); +* gcusumkbn2( 4, 0.0, arraylike2object( x ), 2, 1, arraylike2object( y ), 1, 0 ); */ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var xbuf; From ac9a1c218aebe97c229a7efefc3e005ecc987794 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Sat, 1 Feb 2025 17:19:00 +0500 Subject: [PATCH 4/6] refactor: apply suggestions from code review Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> --- .../blas/ext/base/gcusumkbn2/docs/types/index.d.ts | 6 +++--- .../@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts index d29ab143eb3c..8559982f60da 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/index.d.ts @@ -28,7 +28,7 @@ import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array type InputArray = NumericArray | Collection | AccessorArrayLike; /** -* Input array. +* Output array. */ type OutputArray = NumericArray | Collection | AccessorArrayLike; @@ -54,7 +54,7 @@ interface Routine { * gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ( N: number, sum: number, x: InputArray, strideX: number, y: OutputArray, strideY: number ): OutputArray; + ( N: number, sum: number, x: InputArray, strideX: number, y: T, strideY: number ): T; /** * Computes the cumulative sum of strided array elements using a second-order iterative Kahan–Babuška algorithm and alternative indexing semantics. @@ -76,7 +76,7 @@ interface Routine { * gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); * // y => [ 1.0, -1.0, 1.0 ] */ - ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: OutputArray, strideY: number, offsetY: number ): OutputArray; + ndarray( N: number, sum: number, x: InputArray, strideX: number, offsetX: number, y: T, strideY: number, offsetY: number ): T; } /** diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts index 9ec94ae0ad03..dabc94378277 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts @@ -27,8 +27,8 @@ import gcusumkbn2 = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); // $ExpectType OutputArray - gcusumkbn2( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType OutputArray + gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); // $ExpectType Float64Array + gcusumkbn2( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType AccessorArray } // The compiler throws an error if the function is provided a first argument which is not a number... @@ -141,8 +141,8 @@ import gcusumkbn2 = require( './index' ); const x = new Float64Array( 10 ); const y = new Float64Array( 10 ); - gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType OutputArray - gcusumkbn2.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType OutputArray + gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType Float64Array + gcusumkbn2.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType AccessorArray } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... From ba462185403fc8a650ab4787cf32eaff9f9c5926 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 2 Feb 2025 12:56:36 -0800 Subject: [PATCH 5/6] fix: update return value Signed-off-by: Athan --- .../@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js index ea9cdfebd5ce..8ede952bef69 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/ndarray.js @@ -74,7 +74,8 @@ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { ox = arraylike2object( x ); oy = arraylike2object( y ); if ( ox.accessorProtocol || oy.accessorProtocol ) { - return accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); + accessors( N, sum, ox, strideX, offsetX, oy, strideY, offsetY ); + return y; } ix = offsetX; iy = offsetY; From 9e1f8f3a62d5ddb0ba8ff1998e7ec65be78dcfe7 Mon Sep 17 00:00:00 2001 From: Muhammad Haris <101793258+headlessNode@users.noreply.github.com> Date: Wed, 5 Feb 2025 09:09:04 +0000 Subject: [PATCH 6/6] refactor: apply suggestions from code review --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed --- --- .../blas/ext/base/gcusumkbn2/docs/types/test.ts | 4 ++-- .../blas/ext/base/gcusumkbn2/lib/accessors.js | 7 ++++--- .../blas/ext/base/gcusumkbn2/test/test.main.js | 14 ++++++++++++++ .../blas/ext/base/gcusumkbn2/test/test.ndarray.js | 14 ++++++++++++++ 4 files changed, 34 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts index dabc94378277..1fa93d7f054a 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/docs/types/test.ts @@ -28,7 +28,7 @@ import gcusumkbn2 = require( './index' ); const y = new Float64Array( 10 ); gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); // $ExpectType Float64Array - gcusumkbn2( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType AccessorArray + gcusumkbn2( x.length, 0.0, new AccessorArray( x ), 1, new AccessorArray( y ), 1 ); // $ExpectType AccessorArray } // The compiler throws an error if the function is provided a first argument which is not a number... @@ -142,7 +142,7 @@ import gcusumkbn2 = require( './index' ); const y = new Float64Array( 10 ); gcusumkbn2.ndarray( x.length, 0.0, x, 1, 0, y, 1, 0 ); // $ExpectType Float64Array - gcusumkbn2.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType AccessorArray + gcusumkbn2.ndarray( x.length, 0.0, new AccessorArray( x ), 1, 0, new AccessorArray( y ), 1, 0 ); // $ExpectType AccessorArray } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js index 1a56041d778f..6e9d177cce57 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/lib/accessors.js @@ -55,10 +55,11 @@ var abs = require( '@stdlib/math/base/special/abs' ); * var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); * var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); * -* var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); -* var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); +* var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ]; +* var y = [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ]; * -* gcusumkbn2( 4, 0.0, arraylike2object( x ), 2, 1, arraylike2object( y ), 1, 0 ); +* gcusumkbn2( 4, 0.0, arraylike2object( toAccessorArray( x ) ), 2, 1, arraylike2object( toAccessorArray( y ) ), 1, 0 ); +* // y => [ 1.0, -1.0, 1.0, 5.0, 0.0, 0.0, 0.0, 0.0 ] */ function gcusumkbn2( N, sum, x, strideX, offsetX, y, strideY, offsetY ) { var xbuf; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js index bead9645d529..edcb3ed4a4bb 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.main.js @@ -230,6 +230,20 @@ tape( 'the function returns a reference to the output array', function test( t ) t.end(); }); +tape( 'the function returns a reference to the output array (accessors)', function test( t ) { + var out; + var x; + var y; + + x = toAccessorArray( [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); + y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0 ] ); + + out = gcusumkbn2( x.length, 0.0, x, 1, y, 1 ); + + t.strictEqual( out, y, 'same reference' ); + t.end(); +}); + tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `y` unchanged', function test( t ) { var expected; var x; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js index 595454db7c68..8e889042ce50 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gcusumkbn2/test/test.ndarray.js @@ -227,6 +227,20 @@ tape( 'the function returns a reference to the output array', function test( t ) t.end(); }); +tape( 'the function returns a reference to the output array (accessors)', function test( t ) { + var out; + var x; + var y; + + x = toAccessorArray( [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); + y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0 ] ); + + out = gcusumkbn2( x.length, 0.0, x, 1, 0, y, 1, 0 ); + + t.strictEqual( out, y, 'same reference' ); + t.end(); +}); + tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `y` unchanged', function test( t ) { var expected; var x;