From 6d5d804bf3094e01c75e0e3cf9de2db72513fcf5 Mon Sep 17 00:00:00 2001 From: ekambains Date: Fri, 7 Feb 2025 14:35:14 -0500 Subject: [PATCH 1/5] Updated the required comment change in README.md Signed-off-by: ekambains --- .../@stdlib/stats/base/dists/degenerate/entropy/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md index e4a72808d075..8e1815a7e5c6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md @@ -190,7 +190,7 @@ int main( void ) { for ( i = 0; i < 10; i++ ) { mu = random_uniform( 0.0, 1.0 ); y = stdlib_base_dists_degenerate_entropy( mu ); - printf( "µ: %1f. H(X;µ): %lf\n", mu, y ); + printf( "µ: %lf. H(X;µ): %lf\n", mu, y ); } } ``` From 4cb10c5389fd5261ac849098be0e3ea798d7b933 Mon Sep 17 00:00:00 2001 From: ekambains Date: Fri, 7 Feb 2025 14:39:17 -0500 Subject: [PATCH 2/5] Updated according to comments on benchmark.c Signed-off-by: ekambains --- .../stats/base/dists/degenerate/entropy/benchmark/c/benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/benchmark/c/benchmark.c index 2cf971687df0..711fbc774f00 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/benchmark/c/benchmark.c @@ -99,7 +99,7 @@ static double benchmark( void ) { int i; for ( i = 0; i < 100; i++ ) { - mu[ i ] = random_uniform( -50.0, -40.0 ); + mu[ i ] = random_uniform( -50.0, 50.0 ); } t = tic(); From 82f3df6e142e8514c529d1193ab23f0ae9df6ec6 Mon Sep 17 00:00:00 2001 From: ekambains Date: Fri, 7 Feb 2025 14:41:28 -0500 Subject: [PATCH 3/5] Updated example.c as per requirements of the comments. Signed-off-by: ekambains --- .../stats/base/dists/degenerate/entropy/examples/c/example.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c index 8e72574f67fc..1375afd95298 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c @@ -33,6 +33,6 @@ int main( void ) { for ( i = 0; i < 10; i++ ) { mu = random_uniform( 0.0, 1.0 ); y = stdlib_base_dists_degenerate_entropy( mu ); - printf( "µ: %1f. H(X;µ): %lf\n", mu , y ); + printf( "µ: %lf. H(X;µ): %lf\n", mu , y ); } } From d24830868fcb3381b16712ae40373fd1aa9b3902 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Fri, 7 Feb 2025 21:09:01 -0500 Subject: [PATCH 4/5] chore: apply suggestions from code review Signed-off-by: Philipp Burckhardt --- .../@stdlib/stats/base/dists/degenerate/entropy/README.md | 2 +- .../stats/base/dists/degenerate/entropy/examples/c/example.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md index 8e1815a7e5c6..ed10ea838446 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/README.md @@ -190,7 +190,7 @@ int main( void ) { for ( i = 0; i < 10; i++ ) { mu = random_uniform( 0.0, 1.0 ); y = stdlib_base_dists_degenerate_entropy( mu ); - printf( "µ: %lf. H(X;µ): %lf\n", mu, y ); + printf( "µ: %lf, H(X;µ): %lf\n", mu, y ); } } ``` diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c index 1375afd95298..c2906b2f8143 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c @@ -33,6 +33,6 @@ int main( void ) { for ( i = 0; i < 10; i++ ) { mu = random_uniform( 0.0, 1.0 ); y = stdlib_base_dists_degenerate_entropy( mu ); - printf( "µ: %lf. H(X;µ): %lf\n", mu , y ); + printf( "µ: %lf, H(X;µ): %lf\n", mu , y ); } } From f806e1d74e19f44a8905ec36a25b0c3cc676398e Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Fri, 7 Feb 2025 21:11:06 -0500 Subject: [PATCH 5/5] Remove duplicate printf statement in example.c --- .../stats/base/dists/degenerate/entropy/examples/c/example.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c index d40f55fc4e7c..ebbea119bd32 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/degenerate/entropy/examples/c/example.c @@ -34,6 +34,5 @@ int main( void ) { mu = random_uniform( 0.0, 1.0 ); y = stdlib_base_dists_degenerate_entropy( mu ); printf( "µ: %lf, H(X;µ): %lf\n", mu, y ); - printf( "µ: %lf, H(X;µ): %lf\n", mu, y ); } }