Skip to content

bench: refactor random value generation #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2025
Merged

bench: refactor random value generation #5374

merged 6 commits into from
Feb 25, 2025

Conversation

@saurabhraghuvanshii
Copy link
Contributor

@saurabhraghuvanshii saurabhraghuvanshii commented Feb 22, 2025 •
edited
Loading

Resolves #none.

Description

What is the purpose of this pull request?

This pull request:

  • refractor random number generation in math/base/special/bernoulli*

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
bench: random value generatio
4a25fb1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 22, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/bernoulli $\color{green}239/239$
$\color{green}+100.00\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}239/239$
$\color{green}+100.00\%$
math/base/special/betainc $\color{green}110/110$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}110/110$
$\color{green}+100.00\%$
math/base/special/betaincinv $\color{green}133/133$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}133/133$
$\color{green}+100.00\%$
math/base/special/betaln $\color{red}382/389$
$\color{green}+98.20\%$ 		$\color{red}22/26$
$\color{green}+84.62\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{red}382/389$
$\color{green}+98.20\%$
math/base/special/binomcoefln $\color{green}217/217$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}217/217$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc
anandkaranubc requested changes Feb 22, 2025
View reviewed changes
@anandkaranubc
Copy link
Contributor

@saurabhraghuvanshii Thanks for fixing these. I have left some comments.

Could you also update the title (there is a typo in 'refactor') and update the test messages to be consistent with those in previous PRs ( like #5369)?

@anandkaranubc anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 22, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

yes I can and the one I am going to ask for change to do in test file , thanks

@saurabhraghuvanshii saurabhraghuvanshii changed the title bench: refractor random value generation bench: refactor random value generation Feb 22, 2025
@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into math-random
e9f7c45
@saurabhraghuvanshii
chore: refactor file and test file
c10c44e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: failed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 22, 2025
@anandkaranubc anandkaranubc removed the Needs Review A pull request which needs code review. label Feb 22, 2025
@saurabhraghuvanshii
chore: improve order in binomcoefln/benchmark
6de0ca4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Changes Pull request which needs changes before being merged. labels Feb 23, 2025
kgryte
kgryte approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte changed the title bench: refactor random value generation bench: refactor random value generation Feb 25, 2025
@kgryte kgryte merged commit 0e2afee into stdlib-js:develop Feb 25, 2025
10 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the math-random branch February 26, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc requested changes

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saurabhraghuvanshii @stdlib-bot @anandkaranubc @kgryte