From 8ecba02dfb2f8e6c7009b1c72cbc82b51b827e52 Mon Sep 17 00:00:00 2001 From: "nirved.mishra.eee23@itbhu.ac.in" Date: Mon, 3 Mar 2025 20:40:00 +0530 Subject: [PATCH] test(lib): addressed commit comments (commit 1f5d85a) #5712 test: rearranged reference section in README.md of normal/quantile and added closing and traling comment for
, arranged L96-102 in order of length in benchmark.c of same location and used sqrt_two library in main.c of same location --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../stats/base/dists/normal/quantile/README.md | 16 ++++++++++++---- .../normal/quantile/benchmark/c/benchmark.c | 6 +++--- .../stats/base/dists/normal/quantile/src/main.c | 3 ++- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md index a7a07a0ab581..7b0747159bbf 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md @@ -152,10 +152,6 @@ for ( i = 0; i < 10; i++ ) { - - -
- * * * @@ -249,6 +245,18 @@ int main( void ) {
+ + +
+ + + + + +
+ +
+ diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c index 06efcf2aaca6..434168e1c5ae 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/benchmark/c/benchmark.c @@ -93,13 +93,13 @@ static double random_uniform( const double min, const double max ) { * @return elapsed time in seconds */ static double benchmark( void ) { + int i; + double t; + double y; double elapsed; double p[ 100 ]; double mu[ 100 ]; double sigma[ 100 ]; - double y; - double t; - int i; for ( i = 0; i < 100; i++ ) { p[ i ] = random_uniform( 0.0, 1.0 ); diff --git a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c index 86e8c5b8fd30..039d7d8b12d3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c +++ b/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/src/main.c @@ -20,6 +20,7 @@ #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/math/base/special/sqrt.h" #include "stdlib/math/base/special/erfinv.h" +#include "stdlib/constants/float64/sqrt_two.h" /** * Evaluates the quantile function for a normal distribution with mean `mu` and standard deviation `sigma` at a probability `p`. @@ -47,5 +48,5 @@ double stdlib_base_dists_normal_quantile( const double p, const double mu, const if ( sigma == 0.0 ) { return mu; } - return mu + ( ( sigma * stdlib_base_sqrt( 2.0 ) ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); + return mu + ( ( sigma * STDLIB_CONSTANT_FLOAT64_SQRT2 ) * stdlib_base_erfinv( ( 2.0 * p ) - 1.0 ) ); }