From 8aac6fe87d1f04551101c345287502c837d1a60d Mon Sep 17 00:00:00 2001 From: jsndz Date: Mon, 10 Mar 2025 21:30:14 +0530 Subject: [PATCH] chore(sincosd): address commit comments in 6d7317a #5893 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- .../math/base/special/sincosd/README.md | 4 ++-- .../sincosd/benchmark/c/native/benchmark.c | 4 ++-- .../base/special/sincosd/docs/types/index.d.ts | 4 ++-- .../base/special/sincosd/docs/types/test.ts | 2 +- .../dists/levy/median/benchmark/benchmark.js | 6 +++--- .../levy/median/benchmark/benchmark.native.js | 6 +++--- .../base/dists/levy/median/test/test.native.js | 18 +++++++++--------- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/sincosd/README.md b/lib/node_modules/@stdlib/math/base/special/sincosd/README.md index 86681a27825a..276fdf307c16 100644 --- a/lib/node_modules/@stdlib/math/base/special/sincosd/README.md +++ b/lib/node_modules/@stdlib/math/base/special/sincosd/README.md @@ -128,8 +128,8 @@ stdlib_base_sincosd( 4.0, &sine, &cosine ); The function accepts the following arguments: -- **x**: `[in] double` input value. -- **sine**: `[out] double*` destination for the sine. +- **x**: `[in] double` input value. +- **sine**: `[out] double*` destination for the sine. - **cosine**: `[out] double*` destination for the cosine. ```c diff --git a/lib/node_modules/@stdlib/math/base/special/sincosd/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/sincosd/benchmark/c/native/benchmark.c index ecdd6d7ef11e..7fe87883122d 100644 --- a/lib/node_modules/@stdlib/math/base/special/sincosd/benchmark/c/native/benchmark.c +++ b/lib/node_modules/@stdlib/math/base/special/sincosd/benchmark/c/native/benchmark.c @@ -101,13 +101,13 @@ static double benchmark( void ) { for ( i = 0; i < ITERATIONS; i++ ) { x = ( 20.0 * rand_double() ) - 10.0; stdlib_base_sincosd( x, &sine, &cosine ); - if ( cosine != cosine || sine != sine) { + if ( cosine != cosine || sine != sine ) { printf( "unexpected results\n" ); break; } } elapsed = tic() - t; - if ( cosine != cosine || sine != sine) { + if ( cosine != cosine || sine != sine ) { printf( "unexpected results\n" ); } return elapsed; diff --git a/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/index.d.ts b/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/index.d.ts index 23f81560cd48..b4b96bdb1ad8 100644 --- a/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/index.d.ts @@ -20,7 +20,7 @@ /// -import { Collection } from '@stdlib/types/array'; +import { NumericArray } from '@stdlib/types/array'; interface sincosd { /** @@ -67,7 +67,7 @@ interface sincosd { * var bool = ( v === out ); * // returns true */ - assign( x: number, out: Collection, stride: number, offset: number ): Collection; + assign( x: number, out: T, stride: number, offset: number ): T ; } /** diff --git a/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/test.ts b/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/test.ts index 4909b4bbd365..df7f21c149d8 100644 --- a/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/test.ts +++ b/lib/node_modules/@stdlib/math/base/special/sincosd/docs/types/test.ts @@ -49,7 +49,7 @@ import sincosd = require( './index' ); { const out = [ 0.0, 0.0 ]; - sincosd.assign( 3.14e-319, out, 1, 0 ); // $ExpectType Collection + sincosd.assign( 3.14e-319, out, 1, 0 ); // $ExpectType number[] } // The compiler throws an error if the `assign` method is provided a first argument which is not a number... diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.js index 23325dcd8f8b..515172c01cb3 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.js @@ -22,9 +22,9 @@ var bench = require( '@stdlib/bench' ); var Float64Array = require( '@stdlib/array/float64' ); -var randu = require( '@stdlib/random/base/randu' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var EPS = require( '@stdlib/constants/float64/eps' ); +var uniform = require( '@stdlib/random/base/uniform' ); var pkg = require( './../package.json' ).name; var median = require( './../lib' ); @@ -42,8 +42,8 @@ bench( pkg, function benchmark( b ) { mu = new Float64Array( len ); c = new Float64Array( len ); for ( i = 0; i < len; i++ ) { - mu[ i ] = ( randu() * 100.0 ) - 50.0; - c[ i ] = ( randu() * 20.0 ) + EPS; + mu[ i ] = uniform( -50.0, 50.0 ); + c[ i ] = uniform( EPS, 20.0 + EPS ); } b.tic(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.native.js index 46739e3a12b6..4a6d20123966 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/benchmark.native.js @@ -24,9 +24,9 @@ var resolve = require( 'path' ).resolve; var bench = require( '@stdlib/bench' ); var Float64Array = require( '@stdlib/array/float64' ); var EPS = require( '@stdlib/constants/float64/eps' ); -var randu = require( '@stdlib/random/base/randu' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var uniform = require( '@stdlib/random/base/uniform' ); var pkg = require( './../package.json' ).name; @@ -51,8 +51,8 @@ bench( pkg+'::native', opts, function benchmark( b ) { mu = new Float64Array( len ); c = new Float64Array( len ); for ( i = 0; i < len; i++ ) { - mu[ i ] = ( randu() * 100.0 ) - 50.0; - c[ i ] = ( randu() * 20.0 ) + EPS; + mu[ i ] = uniform( -50.0, 50.0 ); + c[ i ] = uniform( EPS, 20.0 + EPS ); } b.tic(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/median/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/levy/median/test/test.native.js index bd799897c0d4..3520138ffd9e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/median/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/median/test/test.native.js @@ -53,9 +53,9 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'if provided `NaN` for any parameter, the function returns `NaN`', opts, function test( t ) { var y = median( NaN, 1.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( 1.0, NaN ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); t.end(); }); @@ -63,25 +63,25 @@ tape( 'if provided a nonpositive `c`, the function returns `NaN`', opts, functio var y; y = median( 2.0, 0.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( 2.0, -1.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( 2.0, -1.0 ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( 1.0, NINF ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( PINF, NINF ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( NINF, NINF ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); y = median( NaN, NINF ); - t.equal( isnan( y ), true, 'returns NaN' ); + t.equal( isnan( y ), true, 'returns expected value' ); t.end(); });