Skip to content

feat: add stats/incr/nanmsumprod #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add stats/incr/nanmsumprod #6098

wants to merge 4 commits into from

Conversation

Girish-Garg
Copy link
Contributor

Resolves #5613 .

Description

What is the purpose of this pull request?

This pull request:

  • feat: add incrnanmsumprod accumulator for computing moving sum of products while ignoring NaN values by making a wrapper over msumprod function which pre-exisits at stats/incr

test:
image

examples:
image

benchmark:
image

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmsumprod $\color{green}157/157$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}157/157$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Girish-Garg Girish-Garg changed the title feat: add incrnanmsumprod accumulator for computing moving sum of products while ignoring NaN values feat: add stats/incr/nansumprod Apr 23, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 29, 2025
@Girish-Garg
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@kgryte
Copy link
Member

kgryte commented Apr 30, 2025

@Girish-Garg You'll want to resolve the CI failures.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 30, 2025
@Girish-Garg Girish-Garg changed the title feat: add stats/incr/nansumprod feat: add stats/incr/nanmsumprod Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmsumprod

3 participants

@Girish-Garg @stdlib-bot @kgryte