From d164cb9518ac856c1791e1e59b893d48a6669dcb Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 15:07:37 +0530 Subject: [PATCH 1/7] Fix: Address commit comments Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../@stdlib/stats/base/dists/cauchy/cdf/README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md index 0aac4fe50b7a..3ffae41fa1ab 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md @@ -170,8 +170,8 @@ for ( i = 0; i < 10; i++ ) { Evaluates the [cumulative distribution function][cdf] (CDF) for a [Cauchy][cauchy-distribution] distribution with parameters `x0` (location parameter) and `gamma > 0` (scale parameter). ```c -double out = stdlib_base_dists_cauchy_cdf( 0.5, 0.0, 2.0 ); -// returns ~0.333 +double out = stdlib_base_dists_cauchy_cdf( 4.0, 0.0, 2.0 ); +// returns ~0.852 ``` The function accepts the following arguments: @@ -213,11 +213,11 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - double gamma; + int i; double x; - double x0; double y; - int i; + double x0; + double gamma; for ( i = 0; i < 25; i++ ) { x = random_uniform( 0.0, 10.0 ); From 1e95c8dcc78981c7048cc575bbafff21f896de5f Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 15:08:28 +0530 Subject: [PATCH 2/7] Fix Order of Variables According to Length Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../stats/base/dists/cauchy/cdf/examples/c/example.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c index 00b444b64f4d..a61a8797227b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c @@ -26,11 +26,11 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - double gamma; + int i; double x; - double x0; double y; - int i; + double x0; + double gamma; for ( i = 0; i < 25; i++ ) { x = random_uniform( 0.0, 10.0 ); From cfd6968f4e749a32fe38c7dc578ca417602f8f49 Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 15:09:35 +0530 Subject: [PATCH 3/7] Fix: Variable Changed from logcdf to cdf Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../base/dists/cauchy/cdf/benchmark/benchmark.native.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js index c1aa56e0f595..99608e07253d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js @@ -32,9 +32,9 @@ var pkg = require( './../package.json' ).name; // VARIABLES // -var logcdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); +var cdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); var opts = { - 'skip': ( logcdf instanceof Error ) + 'skip': ( cdf instanceof Error ) }; @@ -60,7 +60,7 @@ bench( pkg+'::native', opts, function benchmark( b ) { b.tic(); for ( i = 0; i < b.iterations; i++ ) { - y = logcdf( x[ i % len ], x0[ i % len ], gamma[ i % len ] ); + y = cdf( x[ i % len ], x0[ i % len ], gamma[ i % len ] ); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } From c62b9c1d9d1ba034f99a69036af7f4cabf0d992a Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 15:18:49 +0530 Subject: [PATCH 4/7] Fix: Description of Cauchy distribution Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h index 2f08f01d4e74..adaad150f91f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h @@ -27,7 +27,7 @@ extern "C" { #endif /** -* Evaluates the cumulative distribution function (CDF) for a Weibull distribution with shape parameter `k` and scale parameter `lambda` at a value `x`. +* Evaluates the cumulative distribution function (CDF) for a Cauchy distribution with location parameter `k` and scale parameter `x0` at a value `x`. */ double stdlib_base_dists_cauchy_cdf( const double x, const double x0, const double gamma ); From c86b1ff18b9c68fe2066aef026587b1e74d1843d Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 16:06:01 +0530 Subject: [PATCH 5/7] Fix: Order of Variables According to Length Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../@stdlib/stats/base/dists/cauchy/cdf/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md index 3ffae41fa1ab..267bd6a43b91 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/README.md @@ -213,11 +213,11 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - int i; - double x; - double y; - double x0; double gamma; + double x0; + double y; + double x; + int i; for ( i = 0; i < 25; i++ ) { x = random_uniform( 0.0, 10.0 ); From bfbbd3c803b88f549be49d98630f1417aa105d1f Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 16:06:33 +0530 Subject: [PATCH 6/7] Fix: Order of Variables According to Length Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../stats/base/dists/cauchy/cdf/examples/c/example.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c index a61a8797227b..dac84205ef31 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c @@ -26,11 +26,11 @@ static double random_uniform( const double min, const double max ) { } int main( void ) { - int i; - double x; - double y; - double x0; double gamma; + double x0; + double y; + double x; + int i; for ( i = 0; i < 25; i++ ) { x = random_uniform( 0.0, 10.0 ); From 7a44b35da5b60283a5158e437d7bca84c9a597cd Mon Sep 17 00:00:00 2001 From: MANI <77221000+Eternity0207@users.noreply.github.com> Date: Wed, 19 Mar 2025 16:08:41 +0530 Subject: [PATCH 7/7] Fix: Description of Cauchy distribution Signed-off-by: MANI <77221000+Eternity0207@users.noreply.github.com> --- .../cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h index adaad150f91f..1e6273b4cbdc 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/include/stdlib/stats/base/dists/cauchy/cdf.h @@ -27,7 +27,7 @@ extern "C" { #endif /** -* Evaluates the cumulative distribution function (CDF) for a Cauchy distribution with location parameter `k` and scale parameter `x0` at a value `x`. +* Evaluates the cumulative distribution function (CDF) for a Cauchy distribution with location parameter `x0` and scale parameter `gamma` at a value `x`. */ double stdlib_base_dists_cauchy_cdf( const double x, const double x0, const double gamma );