From 52f41e5f24af777662f4c63847556653ec6596df Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Tue, 25 Mar 2025 02:40:22 -0700 Subject: [PATCH 1/3] chore: replace pow with stdlib equivalent --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/math/base/special/floorn/manifest.json | 3 +++ .../@stdlib/math/base/special/floorn/src/floorn.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json b/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json index e3eeae49c0c1..80f4f2602e16 100644 --- a/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json @@ -41,6 +41,7 @@ "@stdlib/math/base/napi/binary", "@stdlib/math/base/special/abs", "@stdlib/math/base/special/floor", + "@stdlib/math/base/special/pow", "@stdlib/math/base/assert/is-infinite", "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/min-base10-exponent", @@ -65,6 +66,7 @@ "dependencies": [ "@stdlib/math/base/special/abs", "@stdlib/math/base/special/floor", + "@stdlib/math/base/special/pow", "@stdlib/math/base/assert/is-infinite", "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/min-base10-exponent", @@ -89,6 +91,7 @@ "dependencies": [ "@stdlib/math/base/special/abs", "@stdlib/math/base/special/floor", + "@stdlib/math/base/special/pow", "@stdlib/math/base/assert/is-infinite", "@stdlib/math/base/assert/is-nan", "@stdlib/constants/float64/min-base10-exponent", diff --git a/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c b/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c index 9f21b6044695..6867fe63ecc9 100644 --- a/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c +++ b/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c @@ -19,6 +19,7 @@ #include "stdlib/math/base/special/floorn.h" #include "stdlib/math/base/special/abs.h" #include "stdlib/math/base/special/floor.h" +#include "stdlib/math/base/special/pow.h" #include "stdlib/math/base/assert/is_infinite.h" #include "stdlib/math/base/assert/is_nan.h" #include "stdlib/constants/float64/min_base10_exponent.h" @@ -133,14 +134,14 @@ double stdlib_base_floorn( const double x, const int32_t n ) { } // If we overflow, return `x`, as the number of digits to the right of the decimal is too small (i.e., `x` is too large / lacks sufficient fractional precision) for there to be any effect when rounding... if ( n < STDLIB_CONSTANT_FLOAT64_MIN_BASE10_EXPONENT ) { - s = pow( 10.0, - ( n + STDLIB_CONSTANT_FLOAT64_MAX_BASE10_EXPONENT ) ); // TODO: replace use of `pow` once have stdlib equivalent + s = stdlib_base_pow( 10.0, - ( n + STDLIB_CONSTANT_FLOAT64_MAX_BASE10_EXPONENT ) ); y = ( x * HUGE_VALUE ) * s; // order of operation matters! if ( stdlib_base_is_infinite( y ) ) { return x; } return ( stdlib_base_floor( y ) / HUGE_VALUE ) / s; } - s = pow( 10.0, -n ); // TODO: replace use of `pow` once have stdlib equivalent + s = stdlib_base_pow( 10.0, -n ); y = x * s; if ( stdlib_base_is_infinite( y ) ) { return x; From 63d731e86779b6ec0985638a69676dc034049a99 Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Tue, 25 Mar 2025 02:42:02 -0700 Subject: [PATCH 2/3] chore: remove math.h include --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c b/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c index 6867fe63ecc9..5196f4cbc8a1 100644 --- a/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c +++ b/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c @@ -28,7 +28,6 @@ #include "stdlib/constants/float64/min_base10_exponent_subnormal.h" #include "stdlib/constants/float64/ninf.h" #include -#include // VARIABLES // From 8b8e311e2f8079c43b0755ff783e15317fd723de Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Tue, 25 Mar 2025 23:04:16 -0700 Subject: [PATCH 3/3] chore: rename C file --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/math/base/special/floorn/manifest.json | 6 +++--- .../math/base/special/floorn/src/{floorn.c => main.c} | 0 2 files changed, 3 insertions(+), 3 deletions(-) rename lib/node_modules/@stdlib/math/base/special/floorn/src/{floorn.c => main.c} (100%) diff --git a/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json b/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json index 80f4f2602e16..b2c253708c84 100644 --- a/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json +++ b/lib/node_modules/@stdlib/math/base/special/floorn/manifest.json @@ -28,7 +28,7 @@ { "task": "build", "src": [ - "./src/floorn.c" + "./src/main.c" ], "include": [ "./include" @@ -54,7 +54,7 @@ { "task": "benchmark", "src": [ - "./src/floorn.c" + "./src/main.c" ], "include": [ "./include" @@ -79,7 +79,7 @@ { "task": "examples", "src": [ - "./src/floorn.c" + "./src/main.c" ], "include": [ "./include" diff --git a/lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c b/lib/node_modules/@stdlib/math/base/special/floorn/src/main.c similarity index 100% rename from lib/node_modules/@stdlib/math/base/special/floorn/src/floorn.c rename to lib/node_modules/@stdlib/math/base/special/floorn/src/main.c