Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Apr 12, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the math/base/assert/int32-is-even, and math/base/assert/int32-is-odd packages.
  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Apr 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 12, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/int32-is-even $\color{green}149/149$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}149/149$
$\color{green}+100.00\%$
math/base/assert/int32-is-odd $\color{green}149/149$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}149/149$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Apr 13, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 13, 2025
@hrshya hrshya requested a review from kgryte April 13, 2025 13:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 13, 2025
@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Apr 13, 2025
@kgryte kgryte merged commit 3b07561 into stdlib-js:develop Apr 13, 2025
31 checks passed
@hrshya hrshya deleted the fix/int32even branch October 11, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants